iio: proximity: srf08: replace sprintf() with sysfs_emit()
Subsystems (2)
PATCH v3 1/1 iio: proximity: srf08: replace sprintf() with sysfs_emit()
This patch replaces sprintf() function calls with sysfs_emit() and sysfs_emit_at(). While the current code is fine, sysfs_emit() is preferred over sprintf(), and will help modernize the driver.
---
v2:
- Fixed indenting of sysfs_emit call in function srf08_show_range_mm.
- Optimized return sequence in function srf08_show_sensitivity by directly returning instead of modifying a variable and then returning.
v3:
- Changed indenting of sysfs_emit() call in function srf08_show_range_mm() per Andy Shevchenko's request.
- Clarified commit message details.
drivers/iio/proximity/srf08.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
drivers/iio/proximity/srf08.c +6 -9
@@ -226,7 +226,7 @@ static int srf08_read_raw(struct iio_dev *indio_dev,static ssize_t srf08_show_range_mm_available (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"[0.043 0.043 11.008]\n" ); +return sysfs_emit (buf,"[0.043 0.043 11.008]\n" ); } static IIO_DEVICE_ATTR(sensor_max_range_available, S_IRUGO,
@@ -238,8 +238,8 @@ static ssize_t srf08_show_range_mm(struct device *dev,struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct srf08_data *data =iio_priv (indio_dev); -return sprintf (buf,"%d.%03d\n" , data->range_mm /1000 , - data->range_mm %1000 ); +return sysfs_emit (buf,"%d.%03d\n" , + data->range_mm /1000 , data->range_mm %1000 ); }/*
@@ -316,10 +316,10 @@ static ssize_t srf08_show_sensitivity_available(struct device *dev,for (i =0 ; i < data->chip_info->num_sensitivity_avail; i++)if (data->chip_info->sensitivity_avail[i]) - len +=sprintf (buf + len,"%d " , + len +=sysfs_emit_at (buf, len,"%d " , data->chip_info->sensitivity_avail[i]); - len +=sprintf (buf + len,"\n" ); + len +=sysfs_emit_at (buf, len,"\n" );return len; }
@@ -332,11 +332,8 @@ static ssize_t srf08_show_sensitivity(struct device *dev, {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct srf08_data *data =iio_priv (indio_dev); -int len; - len =sprintf (buf,"%d\n" , data->sensitivity); - -return len; +return sysfs_emit (buf,"%d\n" , data->sensitivity); } static ssize_t srf08_write_sensitivity(struct srf08_data *data,
Signature · 1 line
2.53.0
Jonathan Cameron
maintainerQuoted 8 lines · On Mon, 20 Apr 2026 18:08:13 -0500 Maxwell Doose <[email protected]> wrote:
This patch replaces
sprintf()function calls withsysfs_emit()andsysfs_emit_at(). While the current code is fine,sysfs_emit()is preferred oversprintf(), and will help modernize the driver.Signed-off-by Maxwell Doose <[email protected]>---
v2:
- Fixed indenting ofsysfs_emitcall in functionsrf08_show_range_mm.
Not true unfortunately. Now broken differently.
Quoted 26 lines
- Optimized return sequence in function
srf08_show_sensitivityby directly returning instead of modifying a variable and then returning.v3:
- Changed indenting ofsysfs_emit()call in functionsrf08_show_range_mm()per Andy Shevchenko's request.
- Clarified commit message details.drivers/iio/proximity/srf08.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)drivers/iio/proximity/srf08.c +1
-1@@ -226,7 +226,7 @@ static int srf08_read_raw(struct iio_dev *indio_dev,static ssize_t srf08_show_range_mm_available (struct device *dev,struct device_attribute *attr,char *buf) { -return sprintf (buf,"[0.043 0.043 11.008]\n" ); +return sysfs_emit (buf,"[0.043 0.043 11.008]\n" ); } static IIO_DEVICE_ATTR(sensor_max_range_available, S_IRUGO,
drivers/iio/proximity/srf08.c static ssize_t srf08_show_range_mm(struct device *dev, · line 242
Quoted 7 lines
drivers/iio/proximity/srf08.c +2
-2@@ -238,8 +238,8 @@ static ssize_t srf08_show_range_mm(struct device *dev,struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct srf08_data *data =iio_priv (indio_dev); -return sprintf (buf,"%d.%03d\n" , data->range_mm /1000 , - data->range_mm %1000 ); +return sysfs_emit (buf,"%d.%03d\n" , + data->range_mm /1000 , data->range_mm %1000 );
Should be:
return sysfs_emit(buf, "%d.%03d\n", data->range_mm / 1000, data->range_mm % 1000); Or return sysfs_emit(buf, "%d.%03d\n", data->range_mm / 1000, data->range_mm % 1000);
Quoted 29 lines
drivers/iio/proximity/srf08.c +3
-6}/* @@ -316,10 +316,10 @@ static ssize_t srf08_show_sensitivity_available(struct device *dev,for (i =0 ; i < data->chip_info->num_sensitivity_avail; i++)if (data->chip_info->sensitivity_avail[i]) - len +=sprintf (buf + len,"%d " , + len +=sysfs_emit_at (buf, len,"%d " , data->chip_info->sensitivity_avail[i]); - len +=sprintf (buf + len,"\n" ); + len +=sysfs_emit_at (buf, len,"\n" );return len; }@@ -332,11 +332,8 @@ static ssize_t srf08_show_sensitivity(struct device *dev, {struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct srf08_data *data =iio_priv (indio_dev); -int len; - len =sprintf (buf,"%d\n" , data->sensitivity); - -return len; +return sysfs_emit (buf,"%d\n" , data->sensitivity); } static ssize_t srf08_write_sensitivity(struct srf08_data *data,
Quoted 10 lines · Jonathan Cameron
Not true unfortunately. Now broken differently.
Should be:
return sysfs_emit(buf, "%d.%03d\n", data->range_mm / 1000, data->range_mm % 1000); Or return sysfs_emit(buf, "%d.%03d\n", data->range_mm / 1000, data->range_mm % 1000);
Sorry, still figuring out the indenting for the multi-line parameter lists. I'll get that fixed in a v4 once I've got free time.
best regards,
maxwell
Quoted 3 lines · Maxwell Doose
This patch replaces
sprintf()function calls withsysfs_emit()andsysfs_emit_at(). While the current code is fine,sysfs_emit()is preferred oversprintf(), and will help modernize the driver.
...
drivers/iio/proximity/srf08.c static ssize_t srf08_show_range_mm(struct device *dev, · line 242
Quoted 9 lines
static
ssize_tsrf08_show_range_mm(struct device *dev,drivers/iio/proximity/srf08.c +2
-2struct iio_dev *indio_dev =dev_to_iio_dev (dev);struct srf08_data *data =iio_priv (indio_dev); -return sprintf (buf,"%d.%03d\n" , data->range_mm /1000 , - data->range_mm %1000 ); +return sysfs_emit (buf,"%d.%03d\n" , + data->range_mm /1000 , data->range_mm %1000 );
Wrong indentation.
Quoted 1 line
}
...
drivers/iio/proximity/srf08.c static ssize_t srf08_show_sensitivity_available(struct device *dev, · line 320
Quoted 5 lines
drivers/iio/proximity/srf08.c +1
-1for (i =0 ; i < data->chip_info->num_sensitivity_avail; i++)if (data->chip_info->sensitivity_avail[i]) - len +=sprintf (buf + len,"%d " , + len +=sysfs_emit_at (buf, len,"%d " , data->chip_info->sensitivity_avail[i]);
Ditto.
...
The rest is okay.
Signature · 2 lines
With Best Regards, Andy Shevchenko