Skip to contentSkip to conversation

ovl: Fix possible NULL pointer dereference in ovl_destroy_inode

PATCH In review [email protected] 3 participants 4 messages Apr 21 – Apr 22

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ovl: Fix possible NULL pointer dereference in ovl_destroy_inode

From: sunliming <[email protected]>

In the ovl_destroy_inode function, a variable reference oi->lowerdata_redirect that might be NULL is directly freed. Add a non-null check, and only free the space when it is not NULL.

---
 fs/overlayfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/overlayfs/super.c +1 -1
index 60f0b7ceef0a..4b8b5fd4ab59 100644
@@ -218,7 +218,7 @@ static void ovl_destroy_inode(struct inode *inode)
 	ovl_stack_put(ovl_lowerstack(oi->oe), ovl_numlower(oi->oe));
 	if (S_ISDIR(inode->i_mode))
 		ovl_dir_cache_free(inode);
-	else
+	else if (oi->lowerdata_redirect)
 		kfree(oi->lowerdata_redirect);
 }
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 6 lines · On Tue, Apr 21, 2026 at 11:24 AM <[email protected]> wrote:

From: sunliming <[email protected]>

In the ovl_destroy_inode function, a variable reference oi->lowerdata_redirect that might be NULL is directly freed. Add a non-null check, and only free the space when it is not NULL.

Sunliming,

This is nonsense.
kfree() is not a dereference and kfree(NULL) is allowed.

Please be more considerate of my time and the time of other volunteer maintainers and do not post patches that you do not understand yourself.

Thanks,
Amir.

Quoted 22 lines
---
 fs/overlayfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/overlayfs/super.c +1 -2
index 60f0b7ceef0a..4b8b5fd4ab59 100644
@@ -218,7 +218,7 @@ static void ovl_destroy_inode(struct inode *inode)
        ovl_stack_put(ovl_lowerstack(oi->oe), ovl_numlower(oi->oe));
        if (S_ISDIR(inode->i_mode))
                ovl_dir_cache_free(inode);
-       else
+       else if (oi->lowerdata_redirect)
                kfree(oi->lowerdata_redirect);
 }
 
--

2.25.1

#2 lore raw

2026年4月21日 17:45, "Amir Goldstein" <[email protected] mailto:[email protected]?to=%22Amir%20Goldstein%22%20%3Camir73il%40gmail.com%3E > 写到:

Quoted 15 lines · On Tue, Apr 21, 2026 at 11:24 AM <[email protected]> wrote:
Quoted 8 lines

From: sunliming <[email protected]>

In the ovl_destroy_inode function, a variable reference oi->lowerdata_redirect that might be NULL is directly freed. Add a non-null check, and only free the space when it is not NULL.

Sunliming,

This is nonsense.
kfree() is not a dereference and kfree(NULL) is allowed.

Quoted 7 lines

Please be more considerate of my time and the time of other volunteer maintainers and do not post patches that you do not understand yourself.

Thanks,
Amir.

I understand, I apologize for this patch, thank you.

Quoted 23 lines
Quoted 22 lines

---

 fs/overlayfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 60f0b7ceef0a..4b8b5fd4ab59 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -218,7 +218,7 @@ static void ovl_destroy_inode(struct inode *inode) ovl_stack_put(ovl_lowerstack(oi->oe), ovl_numlower(oi->oe)); if (S_ISDIR(inode->i_mode))
ovl_dir_cache_free(inode);
- else
+ else if (oi->lowerdata_redirect) kfree(oi->lowerdata_redirect);
}

--
2.25.1

maintainer
#3 lore raw
In reply to [email protected]
Quoted 5 lines · On Tue, Apr 21, 2026 at 05:23:49PM +0800, [email protected] wrote:

From: sunliming <[email protected]>

In the ovl_destroy_inode function, a variable reference oi->lowerdata_redirect that might be NULL is directly freed. Add a non-null check, and only free the space when it is not NULL.

Which NULL pointer dereferencing is that change supposed to prevent? If oi is NULL, your condition would have exact same NULL pointer dereference (as would several places in earlier lines, while we are at it).

And kfree(NULL) is NOT dereferencing anything; it's explicitly defined as an empty operation, same as for userland free(NULL) and for the same reason.