hw/sh4/sh7750: Remove forgotten abort() in the MM_ITLB_DATA handler
PATCH 1/1 hw/sh4/sh7750: Remove forgotten abort() in the MM_ITLB_DATA handler
From: Thomas Huth <[email protected]>
QEMU currently aborts when the guest writes to the MM_ITLB_DATA register:
echo "writel 0xf3000000 0x11223344" | \
./qemu-system-sh4 -M r2d -display none -accel qtest -qtest stdio
[I 0.000000] OPENED
[R +0.004476] writel 0xf3000000 0x11223344
Aborted (core dumped)
Looking at the history of the code, the abort() here has likely just been forgotten when the register handler had been implemented (it used to be a reminder about unimplemented functionality initially):
https://gitlab.com/qemu-project/qemu/-/commit/9f97309a70f12df5f9104f1f
Thus simply remove the abort() now to get rid of the problem.
Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3420
--- hw/sh4/sh7750.c | 1 - 1 file changed, 1 deletion(-)
hw/sh4/sh7750.c +0 -1
@@ -687,7 +687,6 @@ static void sh7750_mmct_write(void *opaque, hwaddr addr,break ;case MM_ITLB_DATA :cpu_sh4_write_mmaped_itlb_data (&s->cpu->env, addr, mem_value); -abort ();break ;case MM_OCACHE_ADDR :case MM_OCACHE_DATA :
Signature · 1 line
2.53.0
Quoted 16 lines · Thomas Huth
From: Thomas Huth <[email protected]>
QEMU currently aborts when the guest writes to the
MM_ITLB_DATAregister:echo "writel 0xf3000000 0x11223344" | \ ./qemu-system-sh4 -M r2d -display none -accel qtest -qtest stdio [I 0.000000] OPENED [R +0.004476] writel 0xf3000000 0x11223344 Aborted (core dumped)Looking at the history of the code, the
abort()here has likely just been forgotten when the register handler had been implemented (it used to be a reminder about unimplemented functionality initially):https://gitlab.com/qemu-project/qemu/-/commit/9f97309a70f12df5f9104f1f
Quoted 7 lines
Thus simply remove the
abort()now to get rid of the problem.Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3420
Signed-off-by Thomas Huth <[email protected]>--- hw/sh4/sh7750.c | 1 - 1 file changed, 1 deletion(-)
Quoted 16 lines · Thomas Huth
From: Thomas Huth <[email protected]>
QEMU currently aborts when the guest writes to the
MM_ITLB_DATAregister:echo "writel 0xf3000000 0x11223344" | \ ./qemu-system-sh4 -M r2d -display none -accel qtest -qtest stdio [I 0.000000] OPENED [R +0.004476] writel 0xf3000000 0x11223344 Aborted (core dumped)Looking at the history of the code, the
abort()here has likely just been forgotten when the register handler had been implemented (it used to be a reminder about unimplemented functionality initially):https://gitlab.com/qemu-project/qemu/-/commit/9f97309a70f12df5f9104f1f
Quoted 7 lines
Thus simply remove the
abort()now to get rid of the problem.Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3420
Signed-off-by Thomas Huth <[email protected]>--- hw/sh4/sh7750.c | 1 - 1 file changed, 1 deletion(-)
Patch queued, thanks!
Quoted 14 lines · Thomas Huth
From: Thomas Huth <[email protected]>
QEMU currently aborts when the guest writes to the
MM_ITLB_DATAregister:echo "writel 0xf3000000 0x11223344" | \ ./qemu-system-sh4 -M r2d -display none -accel qtest -qtest stdio [I 0.000000] OPENED [R +0.004476] writel 0xf3000000 0x11223344 Aborted (core dumped)Looking at the history of the code, the
abort()here has likely just been forgotten when the register handler had been implemented (it used to be a reminder about unimplemented functionality initially):
Quoted 5 lines
https://gitlab.com/qemu-project/qemu/-/commit/9f97309a70f12df5f9104f1f
Thus simply remove the
abort()now to get rid of the problem.Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3420
This too, seems to be a good candidate for the stable series, - despite the issue is very old. Picked it up now.
Thanks,
/mjt