efivarfs: use QSTR() in efivarfs_alloc_dentry
Subsystems (2)
PATCH 1/1 efivarfs: use QSTR() in efivarfs_alloc_dentry
Use QSTR() and drop strlen() in efivarfs_alloc_dentry().
Signed-off-by Thorsten Blum <[email protected]>
--- fs/efivarfs/super.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
fs/efivarfs/super.c +1 -4
@@ -192,12 +192,9 @@ static const struct dentry_operations efivarfs_d_ops = {static struct dentry *efivarfs_alloc_dentry (struct dentry *parent,char *name) {struct dentry *d; -struct qstr q; +struct qstr q =QSTR (name);int err; - q.name = name; - q.len =strlen (name); - err =efivarfs_d_hash (parent, &q);if (err)return ERR_PTR (err);
Ard Biesheuvel
maintainerHi Thorsten,
Quoted 7 lines · Thorsten Blum
Use
QSTR()and dropstrlen()inefivarfs_alloc_dentry().Signed-off-by Thorsten Blum <[email protected]>--- fs/efivarfs/super.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
I'll queue this up once -rc1 comes around. Thanks.
Quoted 18 lines
fs/efivarfs/super.c +1
-4@@ -192,12 +192,9 @@ static const struct dentry_operations efivarfs_d_ops = {static struct dentry *efivarfs_alloc_dentry (struct dentry *parent,char *name) {struct dentry *d; -struct qstr q; +struct qstr q =QSTR (name);int err; - q.name = name; - q.len =strlen (name); - err =efivarfs_d_hash (parent, &q);if (err)return ERR_PTR (err);
Quoted 1 line · Thorsten Blum
Use
QSTR()and dropstrlen()inefivarfs_alloc_dentry().
QSTR contains strlen(), so it's not really accurate to say it's been dropped; this is merely changing to use a #define that does exactly the same as the original code.
Regards,
James