Skip to contentSkip to conversation

Improve handoff prepare on SoCFPGA

PATCH Superseded Brian Sune 3 participants 10 messages Apr 25 – Apr 30

Subsystems (3)
lore
Share & tools
lore

Brian Sune

author
#0 lore raw

PATCH v6 1/1 Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ "$${HANDOFF_KEEP:-0}" != "0" ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
- Rename old files to .h.handoff_backup.<timestamp> when the keep option is selected.

---
 arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 3 deletions(-)
arch/arm/mach-socfpga/config.mk +36 -3
index 1ca1d33cb16..f341aaaea56 100644
@@ -1,6 +1,18 @@
 # SPDX-License-Identifier: GPL-2.0+
 #
 # Brian Sune <[email protected]>
+#
+# HANDOFF_PATH
+# ------------
+# Unset - Board path where qts locates and "hps_isw_handoff" should be placed.
+# Set   - Custom path points to "hps_isw_handoff" folder.
+#
+# HANDOFF_KEEP
+# ------------
+# Unset	- Clean header files.
+# Set	- HANDOFF_KEEP= , Clean header files.
+#	  HANDOFF_KEEP=0, Clean header files.
+#	  HANDOFF_KEEP=1, Backup header files and rename to ".h.handoff_backup.<timestamp>".
 
 ifeq ($(CONFIG_ARCH_SOCFPGA_CYCLONE5),y)
 archprepare: socfpga_g5_handoff_prepare
@@ -43,6 +55,27 @@ socfpga_g5_handoff_prepare:
 			exit 0; \
 		fi; \
 		echo "[INFO] Found hiof file: $$HIOF_FILE"; \
-		echo "[INFO] Running BSP generator..."; \
-		python3 $(srctree)/tools/cv_bsp_generator/cv_bsp_generator.py -i "$$HANDOFF_PATH" -o "$$BOARD_DIR/qts" || echo "[WARN] BSP generator failed, continuing..."; \
-		echo "[DONE] SoCFPGA QTS handoff conversion complete."
+		echo "[INFO] Try BSP generator..."; \
+		TEMP_DIR=$$(mktemp -dp "$$BOARD_DIR/"); \
+		trap 'rm -rf "$$TEMP_DIR"' EXIT; \
+		if python3 $(srctree)/tools/cv_bsp_generator/cv_bsp_generator.py -i "$$HANDOFF_PATH" -o "$$TEMP_DIR"; then \
+			if [ "$${HANDOFF_KEEP:-0}" != "0" ]; then \
+				echo "[INFO] Preserving old BSP files..."; \
+				TIMESTAMP=$$(date +%Y%m%d_%H%M%S); \
+				for f in "$$BOARD_DIR"/qts/*.h; do \
+					[ -e "$$f" ] || continue; \
+					echo "[INFO] $$f -> $${f%.h}.h.handoff_backup.$$TIMESTAMP"; \
+					mv "$$f" "$${f%.h}.h.handoff_backup.$$TIMESTAMP"; \
+				done; \
+			else \
+				echo "[INFO] Clean old BSP files..."; \
+				if ls "$$BOARD_DIR/qts"/*.h >/dev/null 2>&1; then \
+					rm "$$BOARD_DIR/qts"/*.h; \
+					echo "[INFO] Removed old BSP files..."; \
+				fi; \
+			fi; \
+			mv "$$TEMP_DIR"/*.h "$$BOARD_DIR"/qts; \
+			echo "[INFO] SoCFPGA QTS handoff conversion complete."; \
+		else \
+			echo "[WARN] BSP generator failed!"; \
+		fi;
Signature · 1 line
2.34.1
#1 lore raw

Hi Brian,

Quoted 22 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

Quoted 2 lines

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

Regards,
Simon

author
#2 lore raw
Quoted 29 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

With all respect,
Brian

Quoted 3 lines

Regards,
Simon

#3 lore raw

Hi Brian,

Quoted 61 lines · Sune Brian
Quoted 29 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

Regards,
Simon

author
#4 lore raw
Quoted 65 lines · Simon Glass

Hi Brian,

Quoted 61 lines · Sune Brian
Quoted 29 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 6 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!
Brian

Quoted 10 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

Regards,
Simon

#5 lore raw

Hi Sune,

Quoted 76 lines · Sune Brian
Quoted 65 lines · Simon Glass

Hi Brian,

Quoted 61 lines · Sune Brian
Quoted 29 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 6 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

Quoted 7 lines

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!

Oh, sorry about that and also the server being down, etc.. The maintainer for SoCFPGA will handle applying this in any case.

Quoted 9 lines

Brian

Quoted 7 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

- Simon

Reviewed-by
#6 lore raw
Quoted 94 lines · Simon Glass

Hi Sune,

Quoted 76 lines · Sune Brian
Quoted 65 lines · Simon Glass

Hi Brian,

Quoted 61 lines · Sune Brian
Quoted 29 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

 1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 6 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

Quoted 7 lines

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!

Oh, sorry about that and also the server being down, etc.. The maintainer for SoCFPGA will handle applying this in any case.

Quoted 3 lines

Brian

Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

- Simon

Since I've reviewed it and we are only talking formatting:

#7 lore raw

Hi Brian,

Quoted 90 lines · Simon Glass

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Quoted 87 lines · Simon Glass

Hi Sune,

Quoted 66 lines · Sune Brian
Quoted 58 lines · Simon Glass

Hi Brian,

Quoted 55 lines · Sune Brian
Quoted 27 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

  1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 5 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

Quoted 7 lines

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!

Oh, sorry about that and also the server being down, etc.. The maintainer for SoCFPGA will handle applying this in any case.

Quoted 8 lines

Brian

Quoted 6 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

I have reviewed this patch.

While the functional change appears reasonable, the patch cannot be applied in its current form because the commit message and version history do not follow U-Boot patch submission conventions. Specifically:

- Per-version change history must be placed below the '---' separator.
- The required format is 'Changes in vN:'. Custom formats such as 'Changelog vN -> vN+1:' are not acceptable.

Maintainers rely on these conventions so patches can be applied directly using git am without manual rework. I will not correct the commit history on behalf of the contributor.

Please resend the patch with the commit message formatted correctly. Further review or application will only proceed once this requirement is met.

Best regards,

Tien Fong

author
#8 lore raw
Quoted 108 lines · Tien Fong

Hi Brian,

Quoted 90 lines · Simon Glass

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Quoted 87 lines · Simon Glass

Hi Sune,

Quoted 66 lines · Sune Brian
Quoted 58 lines · Simon Glass

Hi Brian,

Quoted 55 lines · Sune Brian
Quoted 27 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

  1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 5 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

Quoted 7 lines

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!

Oh, sorry about that and also the server being down, etc.. The maintainer for SoCFPGA will handle applying this in any case.

Quoted 8 lines

Brian

Quoted 6 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

I have reviewed this patch.

While the functional change appears reasonable, the patch cannot be applied in its current form because the commit message and version history do not follow U-Boot patch submission conventions. Specifically:

- Per-version change history must be placed below the '---' separator.
- The required format is 'Changes in vN:'. Custom formats such as 'Changelog vN -> vN+1:' are not acceptable.

Quoted 7 lines

Maintainers rely on these conventions so patches can be applied directly using git am without manual rework. I will not correct the commit history on behalf of the contributor.

Please resend the patch with the commit message formatted correctly. Further review or application will only proceed once this requirement is met.

Hi T.F.,

Drop this, I don't care.

Thanks,
Brian

Quoted 5 lines

Best regards,

Tien Fong

author
#9 lore raw
Quoted 119 lines · Sune Brian
Quoted 108 lines · Tien Fong

Hi Brian,

Quoted 90 lines · Simon Glass

[CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]

Quoted 87 lines · Simon Glass

Hi Sune,

Quoted 66 lines · Sune Brian
Quoted 58 lines · Simon Glass

Hi Brian,

Quoted 55 lines · Sune Brian
Quoted 27 lines · Simon Glass

Hi Brian,

Quoted 24 lines · Sune Brian

Improve handoff prepare on SoCFPGA

Ensure qts folder header files are properly updated by isolating the Python execution environment. This prevents partial or failed script runs from corrupting the target directory.

Changelog v5 -> v6:
- Clean HANDOFF_KEEP comments.

Changelog v4 -> v5:
- Change HANDOFF_KEEP condition to if [ '$${HANDOFF_KEEP:-0}' != '0' ]
- Add HANDOFF_KEEP and HANDOFF_PATH comments in config.mk

Changes:
- Implement a temp folder for Python script execution.
- Clean temp folder automatically despite execution failures.
- Gate the file replacement process on the successful exit of the Python scripts.
- Execute the replacement (with or without keep) only upon script success via the NEW HANDOFF_KEEP=xxx variable.
[...]

arch/arm/mach-socfpga/config.mk | 39 ++++++++++++++++++++++++++++++++++++---

  1 file changed, 36 insertions(+), 3 deletions(-)

Dear Simon,

B.C. the server is down and I don't expect Google to have an auto fail mailing recovery.

Quoted 2 lines

I see 6 copies of this v6 patch in patchwork, so I wonder if I got the right one?

I will try to respond to this email as politely as possible. Please reference from "patchwork.ozlabs.org" list.

Quoted 8 lines

The per-version changelogs belong below the '---' separator, not in the commit body. Also U-Boot convention is 'Changes in vN:' rather than 'Changelog vN -> vN+1:'.

You could try using 'patman' which will get this right for you automatically:

https://docs.u-boot.org/en/latest/develop/patman.html

1) I only do basic software
2) I used ./script/checkpatch.pl There are no errors, warnings etc.
3) There is nothing to do with the patch itself either the software nor the file itself.
4) I am not too familiar with patman
5) There are many better things to do rather than complaining about the patch headers.

Quoted 5 lines
Quoted 4 lines

So forgive me I really don't give a damn on whatever the header requirements. If you feel this is not passing the patch standard simply reject or label all patches to
"Changes Requested".

That's up to whoever applies this patch. I am just a reviewer :-)

Hi Simon,

Quoted 7 lines

I am going to ignore all your mail in the future.
So review whatever you like, don't care.
There are many patch not following whatever rules or guidelines you mentioned.
Just review those as well. What a waste of time on your emails.

As politely as possible!!!

Oh, sorry about that and also the server being down, etc.. The maintainer for SoCFPGA will handle applying this in any case.

Quoted 8 lines

Brian

Quoted 6 lines

The reason for the formatting rules is mostly so that maintainers can apply them without manually redoing the patch, etc.

There is also this which might help (although you might not want more reading):

https://docs.u-boot.org/en/latest/develop/sending_patches.html#commit-message-conventions

I have reviewed this patch.

While the functional change appears reasonable, the patch cannot be applied in its current form because the commit message and version history do not follow U-Boot patch submission conventions. Specifically:

- Per-version change history must be placed below the '---' separator.
- The required format is 'Changes in vN:'. Custom formats such as 'Changelog vN -> vN+1:' are not acceptable.

Quoted 7 lines

Maintainers rely on these conventions so patches can be applied directly using git am without manual rework. I will not correct the commit history on behalf of the contributor.

Please resend the patch with the commit message formatted correctly. Further review or application will only proceed once this requirement is met.

Quoted 12 lines

Hi T.F.,

Drop this, I don't care.

Thanks,
Brian

Quoted 5 lines

Best regards,

Tien Fong

Dear Tom,

Sorry for the trouble.
Please reject this patch series.

Thanks,
Brian