mm: Convert vmemmap_p?d_populate() to static functions
Subsystems (2)
PATCH 1/1 mm: Convert vmemmap_p?d_populate() to static functions
From: Chengkaitao <[email protected]>
Since the vmemmap_p?d_populate functions are unused outside the mm subsystem, we can remove their external declarations and convert them to static functions.
Signed-off-by Chengkaitao <[email protected]>
--- include/linux/mm.h | 7 ------- mm/sparse-vmemmap.c | 10 +++++----- 2 files changed, 5 insertions(+), 12 deletions(-)
include/linux/mm.h +0 -7
@@ -4860,13 +4860,6 @@ unsigned long section_map_size(void);struct page *__populate_section_memmap (unsigned long pfn,unsigned long nr_pages,int nid,struct vmem_altmap *altmap,struct dev_pagemap *pgmap); -pgd_t *vmemmap_pgd_populate (unsigned long addr,int node); -p4d_t *vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node); -pud_t *vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node); -pmd_t *vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node); -pte_t *vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node, -struct vmem_altmap *altmap,unsigned long ptpfn, -unsigned long flags);void *vmemmap_alloc_block (unsigned long size,int node);struct vmem_altmap ; void *vmemmap_alloc_block_buf(unsigned long size, int node,
mm/sparse-vmemmap.c +5 -5
@@ -151,7 +151,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node, start, end - 1); } -pte_t *__meminit vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node, +static pte_t *__meminit vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node,struct vmem_altmap *altmap,unsigned long ptpfn,unsigned long flags) {
@@ -195,7 +195,7 @@ static void * __meminit vmemmap_alloc_block_zero(unsigned long size, int node)return p; } -pmd_t *__meminit vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node) +static pmd_t *__meminit vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node) {pmd_t *pmd =pmd_offset (pud, addr);if (pmd_none (*pmd)) {
@@ -208,7 +208,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node)return pmd; } -pud_t *__meminit vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node) +static pud_t *__meminit vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node) {pud_t *pud =pud_offset (p4d, addr);if (pud_none (*pud)) {
@@ -221,7 +221,7 @@ pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node)return pud; } -p4d_t *__meminit vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node) +static p4d_t *__meminit vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node) {p4d_t *p4d =p4d_offset (pgd, addr);if (p4d_none (*p4d)) {
@@ -234,7 +234,7 @@ p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node)return p4d; } -pgd_t *__meminit vmemmap_pgd_populate (unsigned long addr,int node) +static pgd_t *__meminit vmemmap_pgd_populate (unsigned long addr,int node) {pgd_t *pgd =pgd_offset_k (addr);if (pgd_none (*pgd)) {
Signature · 1 line
2.50.1 (Apple Git-155)
Quoted 8 lines · Kaitao cheng
From: Chengkaitao <[email protected]>
Since the vmemmap_p?d_populate functions are unused outside the mm subsystem, we can remove their external declarations and convert them to static functions.
Signed-off-by Chengkaitao <[email protected]>
Quoted 75 lines
--- include/linux/mm.h | 7 ------- mm/sparse-vmemmap.c | 10 +++++----- 2 files changed, 5 insertions(+), 12 deletions(-)include/linux/mm.h +0
-7@@ -4860,13 +4860,6 @@ unsigned long section_map_size(void);struct page *__populate_section_memmap (unsigned long pfn,unsigned long nr_pages,int nid,struct vmem_altmap *altmap,struct dev_pagemap *pgmap); -pgd_t *vmemmap_pgd_populate (unsigned long addr,int node); -p4d_t *vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node); -pud_t *vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node); -pmd_t *vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node); -pte_t *vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node, -struct vmem_altmap *altmap,unsigned long ptpfn, -unsigned long flags);void *vmemmap_alloc_block (unsigned long size,int node);struct vmem_altmap ; void *vmemmap_alloc_block_buf(unsigned long size, int node,mm/sparse-vmemmap.c +5
-5@@ -151,7 +151,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node, start, end - 1); } -pte_t *__meminit vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node, +static pte_t *__meminit vmemmap_pte_populate (pmd_t *pmd,unsigned long addr,int node,struct vmem_altmap *altmap,unsigned long ptpfn,unsigned long flags) {@@ -195,7 +195,7 @@ static void * __meminit vmemmap_alloc_block_zero(unsigned long size, int node)return p; } -pmd_t *__meminit vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node) +static pmd_t *__meminit vmemmap_pmd_populate (pud_t *pud,unsigned long addr,int node) {pmd_t *pmd =pmd_offset (pud, addr);if (pmd_none (*pmd)) {@@ -208,7 +208,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node)return pmd; } -pud_t *__meminit vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node) +static pud_t *__meminit vmemmap_pud_populate (p4d_t *p4d,unsigned long addr,int node) {pud_t *pud =pud_offset (p4d, addr);if (pud_none (*pud)) {@@ -221,7 +221,7 @@ pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node)return pud; } -p4d_t *__meminit vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node) +static p4d_t *__meminit vmemmap_p4d_populate (pgd_t *pgd,unsigned long addr,int node) {p4d_t *p4d =p4d_offset (pgd, addr);if (p4d_none (*p4d)) {@@ -234,7 +234,7 @@ p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node)return p4d; } -pgd_t *__meminit vmemmap_pgd_populate (unsigned long addr,int node) +static pgd_t *__meminit vmemmap_pgd_populate (unsigned long addr,int node) {pgd_t *pgd =pgd_offset_k (addr);if (pgd_none (*pgd)) {Signature · 1 line
2.50.1 (Apple Git-155)
Signature · 2 lines
Sincerely yours, Mike.
Quoted 8 lines · Kaitao cheng
From: Chengkaitao <[email protected]>
Since the vmemmap_p?d_populate functions are unused outside the mm subsystem, we can remove their external declarations and convert them to static functions.
Signed-off-by Chengkaitao <[email protected]>
Acked-by Oscar Salvador <[email protected]>
Signature · 2 lines
Oscar Salvador SUSE Labs