Enable and Add new tests for DC3CO
v3 cover Enable and Add new tests for DC3CO
Enable DC3CO tests for PSR/PR for display versions >= 35, add a new test for DC3CO to validate frame drops, and test DC3CO with LOBF.
v3: Adds a test to verify DC3CO continues to function properly
after a DC6 power cycle and rename function name in first patch.
Jeevan B (6):
tests: s/check_dc_counter/assert_dc_counter tests/intel/kms_pm_dc: Replace require with proper assertion tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes tests/kms_vrr: Add new test for DC3CO validation with LOBF tests/intel/kms_pm_dc: Add new test for dc3co framedrop validation
RFC: tests/intel/kms_pm_dc: Add new test for DC3CO recovery after DC6
tests/intel/kms_pm_dc.c | 237 ++++++++++++++++++++++++++++++++++++---- tests/kms_vrr.c | 33 ++++++ 2 files changed, 250 insertions(+), 20 deletions(-)
Signature · 1 line
2.43.0
PATCH v3 3/6 tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes
Enable DC3CO with PSR2/PR mode on TGL and for platforms with display version greater than 35.
v2: Fix debug, remove trailing dash and merge mode and char to
single strcut array.
v3: Minor cosmetic changes.
--- tests/intel/kms_pm_dc.c | 50 ++++++++++++++++++++++++++++++++--------- 1 file changed, 39 insertions(+), 11 deletions(-)
tests/intel/kms_pm_dc.c +39 -11
@@ -110,6 +110,11 @@ typedef struct {bool runtime_suspend_disabled; } data_t; +struct dc3co_test_mode { +enum psr_mode mode; +const char *name; +}; +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count);static void set_output_on_pipe_b (data_t *data)
@@ -319,18 +324,20 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)assert_dc_counter (data,IGT_INTEL_CHECK_DC3CO , dc3co_prev_cnt); } -static void setup_dc3co (data_t *data) +static void setup_dc3co (data_t *data,enum psr_mode mode) { + data->op_psr_mode = mode;psr_enable (data->drm_fd, data->debugfs_fd, data->op_psr_mode, data->output); -igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output), -"PSR2 is not enabled\n" ); +igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode,NULL ), +"%s is not enabled\n" , + mode ==PSR_MODE_2 ?"PSR2" :"Panel Replay" ); } -static void test_dc3co_vpb_simulation (data_t *data) +static void test_dc3co_vpb_simulation (data_t *data,enum psr_mode mode) {igt_require_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO );setup_output (data); -setup_dc3co (data); +setup_dc3co (data, mode);setup_videoplayback (data);check_dc3co_with_videoplayback_like_load (data);cleanup_dc3co_fbs (data);
@@ -658,12 +665,33 @@ int igt_main() }igt_describe ("In this test we make sure that system enters DC3CO " -"when PSR2 is active and system is in SLEEP state" ); - igt_subtest("dc3co-vpb-simulation") { - data.op_psr_mode =PSR_MODE_2 ; -igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, - data.op_psr_mode,NULL )); -test_dc3co_vpb_simulation (&data); +"when PSR2 or PR is active and system is in SLEEP state" ); + igt_subtest_with_dynamic("dc3co-vpb-simulation") { +static const struct dc3co_test_mode dc3co_modes[] = { + {PSR_MODE_2 ,"psr2" }, + {PR_MODE ,"pr" }, + }; + +for (int i =0 ; i <ARRAY_SIZE (dc3co_modes); i++) { +enum psr_mode mode = dc3co_modes[i].mode; +const char *name = dc3co_modes[i].name; + + igt_dynamic_f("%s", name) { +igt_require (psr_sink_support (data.drm_fd, + data.debugfs_fd, + mode,NULL )); + +if (mode ==PSR_MODE_2 ) +igt_require_f (IS_TIGERLAKE (data.devid) || +intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with PSR2\n" ); +else +igt_require_f (intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with Panel Replay\n" ); + +test_dc3co_vpb_simulation (&data, mode); + } + } } igt_describe("This test validates display engine entry to DC5 state "
Signature · 1 line
2.43.0
PATCH v3 2/6 tests/intel/kms_pm_dc: Replace require with proper assertion
In reply to Jeevan BThe DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert.
--- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
tests/intel/kms_pm_dc.c +1 -2
@@ -316,8 +316,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)usleep (delay); } -igt_require_f (igt_dc_state_wait_entry (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO , - dc3co_prev_cnt),"dc3co-vpb-simulation not enabled\n" ); +assert_dc_counter (data,IGT_INTEL_CHECK_DC3CO , dc3co_prev_cnt); }static void setup_dc3co (data_t *data)
Signature · 1 line
2.43.0
PATCH v3 6/6 RFC: tests/intel/kms_pm_dc: Add new test for DC3CO recovery after DC6
In reply to Jeevan BAdds a test to verify DC3CO continues to function properly after a DC6 power cycle.
--- tests/intel/kms_pm_dc.c | 65 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+)
tests/intel/kms_pm_dc.c +65 -0
@@ -55,6 +55,11 @@* Description: Verify that DC3CO entry does not cause frame drops and successfully * enters the power state * +* SUBTEST: dc3co-after-dc6 +* Description: Verify DC3CO entry is still functional after a DC6 entry and +* exit cycle, ensuring DC3CO is not broken by deeper power state +* transitions. +* * SUBTEST: dc5-dpms * Description: Validate display engine entry to DC5 state while all connectors's * DPMS property set to OFF
@@ -629,6 +634,42 @@ static int has_panels_without_dc_support(igt_display_t *display)return external_panel; } +static void test_dc3co_after_dc6 (data_t *data,enum psr_mode mode) +{ +uint32_t dc6_prev_cnt; + +igt_require_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO ); +igt_require_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC6 ); + +setup_output (data); + +/* Enable PSR2/PR */ + data->op_psr_mode = mode; +psr_enable (data->drm_fd, data->debugfs_fd, data->op_psr_mode,NULL ); +igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode,NULL ), +"%s is not enabled\n" , + mode ==PSR_MODE_2 ?"PSR2" :"Panel Replay" ); + +/* Trigger a DC6 cycle */ + dc6_prev_cnt =igt_read_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC6 ); +setup_dc_dpms (data); +dpms_off (data); +assert_dc_counter (data,IGT_INTEL_CHECK_DC6 , dc6_prev_cnt); +dpms_on (data); +cleanup_dc_dpms (data); + +/* Re-enable PSR2/PR after DC6 exit */ +psr_enable (data->drm_fd, data->debugfs_fd, data->op_psr_mode,NULL ); +igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode,NULL ), +"%s not re-enabled after DC6 exit\n" , + mode ==PSR_MODE_2 ?"PSR2" :"Panel Replay" ); + +/* Verify DC3CO still works after DC6 */ +setup_videoplayback (data); +check_dc3co_with_videoplayback_like_load (data); +cleanup_dc3co_fbs (data); +} +static void test_deep_pkgc_state (data_t *data) {unsigned int pre_val =0 , cur_val =0 ;
@@ -799,6 +840,30 @@ int igt_main() } } +igt_describe ("Verify DC3CO entry is still functional after a DC6 entry " +"and exit cycle" ); + igt_subtest_with_dynamic("dc3co-after-dc6") { + igt_dynamic("psr2") { +igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, +PSR_MODE_2 ,NULL )); +igt_require_f (IS_TIGERLAKE (data.devid) || +intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with PSR2\n" ); +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +test_dc3co_after_dc6 (&data,PSR_MODE_2 ); + } + igt_dynamic("pr") { +igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, +PR_MODE ,NULL )); +igt_require_f (intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with Panel Replay\n" ); +igt_require_f (igt_pm_pc8_plus_residencies_enabled (data.msr_fd), +"PC8+ residencies not supported\n" ); +test_dc3co_after_dc6 (&data,PR_MODE ); + } + } +igt_describe ("This test validates display engine entry to DC5 state " "while PSR is active" ); igt_subtest("dc5-psr") {
Signature · 1 line
2.43.0
PATCH v3 5/6 tests/intel/kms_pm_dc: Add new test for dc3co framedrop validation
In reply to Jeevan BAdd a new subtest to validate that no frame drops occur during DC3CO entry, ensuring that no frame drops are detected and DC3CO is successfully triggered during the test.
v2: update check_dc3co_framedrop for detecting frame drops via
drmWaitVBlank vblank sequence numbers, checks DC3CO counter to confirm entry and cast variable 'delay'.
v3: Rename function name from check_dc3co* to detect_dc3co*.
--- tests/intel/kms_pm_dc.c | 105 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)
tests/intel/kms_pm_dc.c +105 -0
@@ -51,6 +51,10 @@* Description: Make sure that system enters DC3CO when PSR2 is active and system * is in SLEEP state * +* SUBTEST: dc3co-framedrop-check +* Description: Verify that DC3CO entry does not cause frame drops and successfully +* enters the power state +* * SUBTEST: dc5-dpms * Description: Validate display engine entry to DC5 state while all connectors's * DPMS property set to OFF
@@ -343,6 +347,87 @@ static void test_dc3co_vpb_simulation(data_t *data, enum psr_mode mode)cleanup_dc3co_fbs (data); } +static void detect_dc3co_framedrop (data_t *data) +{ +igt_plane_t *primary; +uint32_t dc3co_prev_cnt; +int delay; +int frame_count =0 , frame_drops =0 ; +int max_count =60 ; +bool dc3co_flag = false; +bool front = false; +struct drm_event_vblank ev; +uint64_t last_flip_ns =0 , cur_flip_ns; +uint64_t frame_time_ns; + +igt_require_f (data->mode->vrefresh !=0 ,"Invalid vrefresh rate of 0\n" ); + + frame_time_ns =UINT64_C (1000000000 ) / data->mode->vrefresh; + + primary =igt_output_get_plane_type (data->output,DRM_PLANE_TYPE_PRIMARY ); +igt_plane_set_fb (primary,NULL ); +igt_display_commit (&data->display); + + dc3co_prev_cnt =igt_read_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO ); + + delay = (int )(1.5 * (1000000 / data->mode->vrefresh)); + +igt_plane_set_fb (primary, &data->fb_rgb); +igt_assert_eq (igt_display_try_commit_atomic (&data->display, +DRM_MODE_ATOMIC_NONBLOCK | +DRM_MODE_PAGE_FLIP_EVENT , + data),0 ); +igt_assert_eq (read (data->drm_fd, &ev,sizeof (ev)),sizeof (ev)); + last_flip_ns = (uint64_t )ev.tv_sec *UINT64_C (1000000000 ) + + (uint64_t )ev.tv_usec *1000 ; + +while (frame_count < max_count) { + front = !front; +igt_plane_set_fb (primary, front ? &data->fb_rgr : &data->fb_rgb); +usleep (delay); + +igt_assert_eq (igt_display_try_commit_atomic (&data->display, +DRM_MODE_ATOMIC_NONBLOCK | +DRM_MODE_PAGE_FLIP_EVENT , + data),0 ); + +igt_set_timeout (2 ,"Waiting for flip event\n" ); +igt_assert_eq (read (data->drm_fd, &ev,sizeof (ev)),sizeof (ev)); +igt_reset_timeout (); + + cur_flip_ns = (uint64_t )ev.tv_sec *UINT64_C (1000000000 ) + + (uint64_t )ev.tv_usec *1000 ; + +if (last_flip_ns !=0 && + (cur_flip_ns - last_flip_ns) >2 * frame_time_ns) + frame_drops++; + + last_flip_ns = cur_flip_ns; + +if (!dc3co_flag && +igt_read_dc_counter (data->debugfs_fd, +IGT_INTEL_CHECK_DC3CO ) > dc3co_prev_cnt) + dc3co_flag = true; + + frame_count++; + } + +igt_assert_f (dc3co_flag,"DC3CO was not entered during the test\n" ); +igt_assert_f (frame_drops ==0 , +"Frame drops detected: %d drops out of %d frames\n" , + frame_drops, frame_count); +} + +static void test_dc3co_framedrop (data_t *data,enum psr_mode mode) +{ +igt_require_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO ); +setup_output (data); +setup_dc3co (data, mode); +setup_videoplayback (data); +detect_dc3co_framedrop (data); +cleanup_dc3co_fbs (data); +} +static void test_dc5_retention_flops (data_t *data,int dc_flag) {uint32_t dc_counter_before_psr;
@@ -694,6 +779,26 @@ int igt_main() } } +igt_describe ("Validate that no frame drops occur during DC3CO entry " +"while alternating framebuffers with PSR2 or Panel Replay active" ); + igt_subtest_with_dynamic("dc3co-framedrop-check") { + igt_dynamic("psr2") { +igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, +PSR_MODE_2 ,NULL )); +igt_require_f (IS_TIGERLAKE (data.devid) || +intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with PSR2\n" ); +test_dc3co_framedrop (&data,PSR_MODE_2 ); + } + igt_dynamic("pr") { +igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, +PR_MODE ,NULL )); +igt_require_f (intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with Panel Replay\n" ); +test_dc3co_framedrop (&data,PR_MODE ); + } + } +igt_describe ("This test validates display engine entry to DC5 state " "while PSR is active" ); igt_subtest("dc5-psr") {
Signature · 1 line
2.43.0
PATCH v3 1/6 tests: s/check_dc_counter/assert_dc_counter
In reply to Jeevan BRename function name.
--- tests/intel/kms_pm_dc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
tests/intel/kms_pm_dc.c +7 -7
@@ -110,7 +110,7 @@ typedef struct {bool runtime_suspend_disabled; } data_t; -static void check_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count); +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count);static void set_output_on_pipe_b (data_t *data) {
@@ -257,7 +257,7 @@ static void create_color_fb(data_t *data, igt_fb_t *fb, color_t *fb_color)paint_rectangles (data, data->mode, fb_color, fb); } -static void check_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count) +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count) { igt_assert_f(igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count), "%s state is not achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),
@@ -265,7 +265,7 @@ static void check_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count) PWR_DOMAIN_INFO)); } -static void check_dc_counter_negative (data_t *data,int dc_flag,uint32_t prev_dc_count) +static void assert_dc_counter_negative (data_t *data,int dc_flag,uint32_t prev_dc_count) { igt_assert_f(!igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count), "%s state is achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),
@@ -346,7 +346,7 @@ static void test_dc5_retention_flops(data_t *data, int dc_flag)set_output_on_pipe_b (data);setup_primary (data);igt_assert (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output)); -check_dc_counter (data, dc_flag, dc_counter_before_psr); +assert_dc_counter (data, dc_flag, dc_counter_before_psr);cleanup_dc_psr (data); }
@@ -360,7 +360,7 @@ static void test_dc_state_psr(data_t *data, int dc_flag)setup_primary (data);igt_require (!psr_disabled_check (data->debugfs_fd));igt_assert (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output)); -check_dc_counter (data, dc_flag, dc_counter_before_psr); +assert_dc_counter (data, dc_flag, dc_counter_before_psr);psr_sink_error_check (data->debugfs_fd, data->op_psr_mode, data->output);cleanup_dc_psr (data); }
@@ -439,7 +439,7 @@ static void test_dc_state_dpms(data_t *data, int dc_flag)setup_dc_dpms (data); dc_counter =igt_read_dc_counter (data->debugfs_fd, dc_flag);dpms_off (data); -check_dc_counter (data, dc_flag, dc_counter); +assert_dc_counter (data, dc_flag, dc_counter);dpms_on (data);cleanup_dc_dpms (data); }
@@ -452,7 +452,7 @@ static void test_dc_state_dpms_negative(data_t *data, int dc_flag)setup_dc_dpms (data); dc_counter =igt_read_dc_counter (data->debugfs_fd, dc_flag);dpms_on (data); -check_dc_counter_negative (data, dc_flag, dc_counter); +assert_dc_counter_negative (data, dc_flag, dc_counter);cleanup_dc_dpms (data); }
Signature · 1 line
2.43.0
PATCH v3 4/6 tests/kms_vrr: Add new test for DC3CO validation with LOBF
In reply to Jeevan BAdd lobf-dc3co subtest to validate DC3CO entry during link-off between frames.
v2: Fix the flow logic.
--- tests/kms_vrr.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
tests/kms_vrr.c +33 -0
@@ -29,6 +29,7 @@*/ #include "igt.h" +#include "igt_pm.h" #include "igt_psr.h" #include "i915/intel_drrs.h" #include "sw_sync.h"
@@ -80,6 +81,9 @@* * SUBTEST: negative-basic * Description: Make sure that VRR should not be enabled on the Non-VRR panel. +* +* SUBTEST: lobf-dc3co +* Description: Test DC3CO entry during LOBF. */ #define NSECS_PER_SEC (1000000000ull)
@@ -947,6 +951,25 @@ test_lobf(data_t *data, igt_crtc_t *crtc, igt_output_t *output,igt_assert_f (lobf_enabled,"LOBF not enabled\n" ); } +static void test_lobf_dc3co (data_t *data,igt_crtc_t *crtc, +igt_output_t *output,uint32_t flags) +{ +unsigned long dc3co_count_before, dc3co_count_after; + + dc3co_count_before =igt_read_dc_counter (data->debugfs_fd, +IGT_INTEL_CHECK_DC3CO ); + +test_lobf (data, crtc, output, flags); + + dc3co_count_after =igt_read_dc_counter (data->debugfs_fd, +IGT_INTEL_CHECK_DC3CO ); + +igt_assert_f (dc3co_count_after > dc3co_count_before, +"DC3CO should be entered during link-off periods. " +"Before: %lu, After: %lu\n" , + dc3co_count_before, dc3co_count_after); +} +static void test_cmrr (data_t *data,igt_crtc_t *crtc,igt_output_t *output,uint32_t flags)
@@ -1242,6 +1265,16 @@ int igt_main_args("drs:", long_opts, help_str, opt_handler, &data)run_vrr_test (&data, test_lobf,TEST_LINK_OFF ); } + +igt_describe ("Test to validate DC3CO entry during link-off between active " +"frames in non-PSR operation." ); + igt_subtest_with_dynamic("lobf-dc3co") { +igt_require (intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=35 ); + +igt_require_dc_counter (data.debugfs_fd,IGT_INTEL_CHECK_DC3CO ); + +run_vrr_test (&data, test_lobf_dc3co,TEST_LINK_OFF ); + } } igt_fixture() {
Signature · 1 line
2.43.0
Patchwork
CI✓ Xe.CI.BAT: success for Enable and Add new tests for DC3CO (rev4)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: Enable and Add new tests for DC3CO (rev4)
URL : https://patchwork.freedesktop.org/series/162479/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_8872_BAT -> XEIGTPW_15048_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* IGT: IGT_8872 -> IGTPW_15048
IGTPW_15048: 9cf0068fe91cb1232306c2bab32ce0fda7682f49 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8872: e70db143b7bafe09bdea4d33188cb10d2070d0e5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4929-ecb61ba4a1f619b6944f4d0741b4d8a0910f460c: ecb61ba4a1f619b6944f4d0741b4d8a0910f460c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/index.html
Patchwork
CI✗ i915.CI.BAT: failure for Enable and Add new tests for DC3CO (rev4)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: Enable and Add new tests for DC3CO (rev4)
URL : https://patchwork.freedesktop.org/series/162479/
State : failure
== Summary ==
CI Bug Log - changes from IGT_8872 -> IGTPW_15048
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_15048 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_15048, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/index.html
Participating hosts (42 -> 40)
------------------------------
Missing (2): bat-dg2-13 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_15048:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@evict:
- bat-mtlp-8: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/bat-mtlp-8/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/bat-mtlp-8/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_selftest@live:
- bat-mtlp-8: [DMESG-FAIL][3] ([i915#12061]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/bat-mtlp-8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/bat-mtlp-8/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_15048 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/bat-dg2-9/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/bat-dg2-9/igt@i915_selftest@[email protected]
- bat-mtlp-9: [PASS][7] -> [DMESG-FAIL][8] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/bat-mtlp-9/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/bat-mtlp-9/igt@i915_selftest@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- fi-tgl-1115g4: [PASS][9] -> [FAIL][10] ([i915#14867])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/fi-tgl-1115g4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/fi-tgl-1115g4/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-mtlp-8: [DMESG-FAIL][11] ([i915#12061]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8872/bat-mtlp-8/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/bat-mtlp-8/igt@i915_selftest@[email protected]
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#14867]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14867
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_8872 -> IGTPW_15048
CI-20190529: 20190529
CI_DRM_18358: ecb61ba4a1f619b6944f4d0741b4d8a0910f460c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_15048: 9cf0068fe91cb1232306c2bab32ce0fda7682f49 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8872: e70db143b7bafe09bdea4d33188cb10d2070d0e5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15048/index.html
Patchwork
CI✗ Xe.CI.FULL: failure for Enable and Add new tests for DC3CO (rev4)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: Enable and Add new tests for DC3CO (rev4)
URL : https://patchwork.freedesktop.org/series/162479/
State : failure
== Summary ==
CI Bug Log - changes from XEIGT_8872_FULL -> XEIGTPW_15048_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with XEIGTPW_15048_FULL absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_15048_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_15048_FULL:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_pm_dc@dc3co-after-dc6@psr2} (NEW):
- shard-lnl: NOTRUN -> [SKIP][1] +8 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-lnl-3/igt@kms_pm_dc@[email protected]
* igt@kms_vrr@lobf-dc3co (NEW):
- shard-bmg: NOTRUN -> [SKIP][2] +5 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
#### Warnings ####
* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-lnl: [SKIP][3] ([Intel XE#7339]) -> [SKIP][4]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-lnl-5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-lnl-5/igt@[email protected]
- shard-bmg: [SKIP][5] ([Intel XE#7794]) -> [SKIP][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-5/igt@[email protected]
* igt@kms_pm_dc@dc6-psr:
- shard-lnl: [FAIL][7] ([Intel XE#7340]) -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-lnl-6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-lnl-7/igt@[email protected]
New tests
---------
New tests have been introduced between XEIGT_8872_FULL and XEIGTPW_15048_FULL:
### New IGT tests (9) ###
* igt@kms_pm_dc@dc3co-after-dc6:
- Statuses : 1 skip(s)
- Exec time: [0.00] s
* igt@kms_pm_dc@dc3co-after-dc6@pr:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pm_dc@dc3co-after-dc6@psr2:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pm_dc@dc3co-framedrop-check:
- Statuses : 2 skip(s)
- Exec time: [0.00] s
* igt@kms_pm_dc@dc3co-framedrop-check@pr:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_pm_dc@dc3co-framedrop-check@psr2:
- Statuses : 2 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_pm_dc@dc3co-vpb-simulation@pr:
- Statuses : 2 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_pm_dc@dc3co-vpb-simulation@psr2:
- Statuses : 2 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_vrr@lobf-dc3co:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in XEIGTPW_15048_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_flip@flip-vs-suspend@a-hdmi-a3:
- shard-bmg: [PASS][9] -> [INCOMPLETE][10] ([Intel XE#2049] / [Intel XE#2597]) +1 other test incomplete
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-6/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@kms_flip@[email protected]
* igt@kms_pm_rpm@modeset-stress-extra-wait:
- shard-bmg: [PASS][11] -> [ABORT][12] ([Intel XE#5545] / [Intel XE#6652])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-10/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@[email protected]
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-lnl: [PASS][13] -> [SKIP][14] ([Intel XE#4692] / [Intel XE#7508])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-lnl-6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-lnl-1/igt@[email protected]
* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-bmg: [PASS][15] -> [INCOMPLETE][16] ([Intel XE#6321])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@[email protected]
* igt@xe_sriov_flr@flr-twice:
- shard-bmg: [PASS][17] -> [FAIL][18] ([Intel XE#6569]) +1 other test fail
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-7/igt@[email protected]
#### Possible fixes ####
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-bmg: [FAIL][19] ([Intel XE#7809]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-bmg: [FAIL][21] ([Intel XE#7571]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
* igt@kms_flip@blocking-wf_vblank@b-dp2:
- shard-bmg: [FAIL][23] ([Intel XE#7705]) -> [PASS][24] +1 other test pass
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-3/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@kms_flip@[email protected]
* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [INCOMPLETE][25] ([Intel XE#6321]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-10/igt@[email protected]
#### Warnings ####
* igt@kms_content_protection@lic-type-0-hdcp14@pipe-a-dp-2:
- shard-bmg: [FAIL][27] ([Intel XE#1178] / [Intel XE#3304] / [Intel XE#7374]) -> [TIMEOUT][28] ([Intel XE#7799]) +1 other test timeout
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-3/igt@kms_content_protection@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-3/igt@kms_content_protection@[email protected]
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [FAIL][29] ([Intel XE#1729] / [Intel XE#7424]) -> [SKIP][30] ([Intel XE#2426] / [Intel XE#5848])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-10/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
* igt@xe_module_load@load:
- shard-bmg: ([PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [SKIP][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56]) ([Intel XE#2457] / [Intel XE#7405]) -> ([PASS][57], [PASS][58], [PASS][59], [PASS][60], [DMESG-WARN][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80]) ([Intel XE#7725])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-3/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-10/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-10/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-10/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-8/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-5/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-2/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-2/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-3/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8872/shard-bmg-9/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-5/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-9/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-3/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-7/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-8/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-3/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-10/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-10/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/shard-bmg-10/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2457]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2457
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#4692]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4692
[Intel XE#5545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5545
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6569
[Intel XE#6652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6652
[Intel XE#7339]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7339
[Intel XE#7340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7340
[Intel XE#7374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7374
[Intel XE#7405]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7405
[Intel XE#7424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7424
[Intel XE#7508]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7508
[Intel XE#7571]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7571
[Intel XE#7705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7705
[Intel XE#7725]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7725
[Intel XE#7794]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7794
[Intel XE#7799]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7799
[Intel XE#7809]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7809
Build changes
-------------
* IGT: IGT_8872 -> IGTPW_15048
IGTPW_15048: 9cf0068fe91cb1232306c2bab32ce0fda7682f49 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8872: e70db143b7bafe09bdea4d33188cb10d2070d0e5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4929-ecb61ba4a1f619b6944f4d0741b4d8a0910f460c: ecb61ba4a1f619b6944f4d0741b4d8a0910f460c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15048/index.html
Re: [PATCH i-g-t v3 1/6] tests: s/check_dc_counter/assert_dc_counter
In reply to Jeevan BQuoted 3 lines · Jeevan B
Rename function name.
Signed-off-by Jeevan B <[email protected]>
LGTM:
Quoted 71 lines
--- tests/intel/kms_pm_dc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)tests/intel/kms_pm_dc.c +7
-7@@ -110,7 +110,7 @@ typedef struct {bool runtime_suspend_disabled; } data_t; -static void check_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count); +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count);static void set_output_on_pipe_b (data_t *data) {@@ -257,7 +257,7 @@ static void create_color_fb(data_t *data, igt_fb_t *fb, color_t *fb_color)paint_rectangles (data, data->mode, fb_color, fb); } -static void check_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count) +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count) { igt_assert_f(igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count), "%s state is not achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),@@ -265,7 +265,7 @@ static void check_dc_counter(data_t *data, int dc_flag, uint32_t prev_dc_count) PWR_DOMAIN_INFO)); } -static void check_dc_counter_negative (data_t *data,int dc_flag,uint32_t prev_dc_count) +static void assert_dc_counter_negative (data_t *data,int dc_flag,uint32_t prev_dc_count) { igt_assert_f(!igt_dc_state_wait_entry(data->debugfs_fd, dc_flag, prev_dc_count), "%s state is achieved\n%s:\n%s\n", igt_dc_state_name(dc_flag),@@ -346,7 +346,7 @@ static void test_dc5_retention_flops(data_t *data, int dc_flag)set_output_on_pipe_b (data);setup_primary (data);igt_assert (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output)); -check_dc_counter (data, dc_flag, dc_counter_before_psr); +assert_dc_counter (data, dc_flag, dc_counter_before_psr);cleanup_dc_psr (data); }@@ -360,7 +360,7 @@ static void test_dc_state_psr(data_t *data, int dc_flag)setup_primary (data);igt_require (!psr_disabled_check (data->debugfs_fd));igt_assert (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output)); -check_dc_counter (data, dc_flag, dc_counter_before_psr); +assert_dc_counter (data, dc_flag, dc_counter_before_psr);psr_sink_error_check (data->debugfs_fd, data->op_psr_mode, data->output);cleanup_dc_psr (data); }@@ -439,7 +439,7 @@ static void test_dc_state_dpms(data_t *data, int dc_flag)setup_dc_dpms (data); dc_counter =igt_read_dc_counter (data->debugfs_fd, dc_flag);dpms_off (data); -check_dc_counter (data, dc_flag, dc_counter); +assert_dc_counter (data, dc_flag, dc_counter);dpms_on (data);cleanup_dc_dpms (data); }@@ -452,7 +452,7 @@ static void test_dc_state_dpms_negative(data_t *data, int dc_flag)setup_dc_dpms (data); dc_counter =igt_read_dc_counter (data->debugfs_fd, dc_flag);dpms_on (data); -check_dc_counter_negative (data, dc_flag, dc_counter); +assert_dc_counter_negative (data, dc_flag, dc_counter);cleanup_dc_dpms (data); }
Re: [PATCH i-g-t v3 3/6] tests/intel/kms_pm_dc: Enable DC3CO test for PSR2/PR modes
In reply to Jeevan BQuoted 8 lines · Jeevan B
Enable DC3CO with PSR2/PR mode on TGL and for platforms with display version greater than 35.
v2: Fix debug, remove trailing dash and merge mode and char to
single strcut array.
v3: Minor cosmetic changes.Signed-off-by Jeevan B <[email protected]>
LGTM:
Quoted 86 lines
--- tests/intel/kms_pm_dc.c | 50 ++++++++++++++++++++++++++++++++--------- 1 file changed, 39 insertions(+), 11 deletions(-)tests/intel/kms_pm_dc.c +39
-11@@ -110,6 +110,11 @@ typedef struct {bool runtime_suspend_disabled; } data_t; +struct dc3co_test_mode { +enum psr_mode mode; +const char *name; +}; +static void assert_dc_counter (data_t *data,int dc_flag,uint32_t prev_dc_count);static void set_output_on_pipe_b (data_t *data)@@ -319,18 +324,20 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)assert_dc_counter (data,IGT_INTEL_CHECK_DC3CO , dc3co_prev_cnt); } -static void setup_dc3co (data_t *data) +static void setup_dc3co (data_t *data,enum psr_mode mode) { + data->op_psr_mode = mode;psr_enable (data->drm_fd, data->debugfs_fd, data->op_psr_mode, data->output); -igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode, data->output), -"PSR2 is not enabled\n" ); +igt_require_f (psr_wait_entry (data->debugfs_fd, data->op_psr_mode,NULL ), +"%s is not enabled\n" , + mode ==PSR_MODE_2 ?"PSR2" :"Panel Replay" ); } -static void test_dc3co_vpb_simulation (data_t *data) +static void test_dc3co_vpb_simulation (data_t *data,enum psr_mode mode) {igt_require_dc_counter (data->debugfs_fd,IGT_INTEL_CHECK_DC3CO );setup_output (data); -setup_dc3co (data); +setup_dc3co (data, mode);setup_videoplayback (data);check_dc3co_with_videoplayback_like_load (data);cleanup_dc3co_fbs (data);@@ -658,12 +665,33 @@ int igt_main() }igt_describe ("In this test we make sure that system enters DC3CO " -"when PSR2 is active and system is in SLEEP state" ); - igt_subtest("dc3co-vpb-simulation") { - data.op_psr_mode =PSR_MODE_2 ; -igt_require (psr_sink_support (data.drm_fd, data.debugfs_fd, - data.op_psr_mode,NULL )); -test_dc3co_vpb_simulation (&data); +"when PSR2 or PR is active and system is in SLEEP state" ); + igt_subtest_with_dynamic("dc3co-vpb-simulation") { +static const struct dc3co_test_mode dc3co_modes[] = { + {PSR_MODE_2 ,"psr2" }, + {PR_MODE ,"pr" }, + }; + +for (int i =0 ; i <ARRAY_SIZE (dc3co_modes); i++) { +enum psr_mode mode = dc3co_modes[i].mode; +const char *name = dc3co_modes[i].name; + + igt_dynamic_f("%s", name) { +igt_require (psr_sink_support (data.drm_fd, + data.debugfs_fd, + mode,NULL )); + +if (mode ==PSR_MODE_2 ) +igt_require_f (IS_TIGERLAKE (data.devid) || +intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with PSR2\n" ); +else +igt_require_f (intel_display_ver (data.devid) >=35 , +"Platform does not support DC3CO with Panel Replay\n" ); + +test_dc3co_vpb_simulation (&data, mode); + } + } } igt_describe("This test validates display engine entry to DC5 state "
Re: [PATCH i-g-t v3 4/6] tests/kms_vrr: Add new test for DC3CO validation with LOBF
In reply to Jeevan BQuoted 59 lines · Jeevan B
Add lobf-dc3co subtest to validate DC3CO entry during link-off between frames.
v2: Fix the flow logic.
Signed-off-by Jeevan B <[email protected]>--- tests/kms_vrr.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)tests/kms_vrr.c +23
-0@@ -29,6 +29,7 @@*/ #include "igt.h" +#include "igt_pm.h" #include "igt_psr.h" #include "i915/intel_drrs.h" #include "sw_sync.h" @@ -80,6 +81,9 @@* * SUBTEST: negative-basic * Description: Make sure that VRR should not be enabled on the Non-VRR panel. +* +* SUBTEST: lobf-dc3co +* Description: Test DC3CO entry during LOBF. */ #define NSECS_PER_SEC (1000000000ull)@@ -947,6 +951,25 @@ test_lobf(data_t *data, igt_crtc_t *crtc, igt_output_t *output,igt_assert_f (lobf_enabled,"LOBF not enabled\n" ); } +static void test_lobf_dc3co (data_t *data,igt_crtc_t *crtc, +igt_output_t *output,uint32_t flags) +{ +unsigned long dc3co_count_before, dc3co_count_after; + + dc3co_count_before =igt_read_dc_counter (data->debugfs_fd, +IGT_INTEL_CHECK_DC3CO ); + +test_lobf (data, crtc, output, flags); + + dc3co_count_after =igt_read_dc_counter (data->debugfs_fd, +IGT_INTEL_CHECK_DC3CO ); + +igt_assert_f (dc3co_count_after > dc3co_count_before, +"DC3CO should be entered during link-off periods. " +"Before: %lu, After: %lu\n" , + dc3co_count_before, dc3co_count_after); +} +static void test_cmrr (data_t *data,igt_crtc_t *crtc,igt_output_t *output,uint32_t flags)
tests/kms_vrr.c int igt_main_args("drs:", long_opts, help_str, opt_handler, &data) · line 1270
Quoted 6 lines
tests/kms_vrr.c +3
-0@@ -1242,6 +1265,16 @@ int igt_main_args("drs:", long_opts, help_str, opt_handler, &data)run_vrr_test (&data, test_lobf,TEST_LINK_OFF ); } + +igt_describe ("Test to validate DC3CO entry during link-off between active " +"frames in non-PSR operation." );
--> Better to have message like: This test validates DC3CO entry during LOBF (Link-Off Between Frames) periods while VRR is active or similar. With this changes, LGTM:
Quoted 10 lines
tests/kms_vrr.c +7
-0+ igt_subtest_with_dynamic("lobf-dc3co") { +igt_require (intel_display_ver (intel_get_drm_devid (data.drm_fd)) >=35 ); + +igt_require_dc_counter (data.debugfs_fd,IGT_INTEL_CHECK_DC3CO ); + +run_vrr_test (&data, test_lobf_dc3co,TEST_LINK_OFF ); + } } igt_fixture() {