Skip to contentSkip to conversation

contrib/vim: remove

PATCH New Trevor Woerner 1 participant 1 message Apr 23

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 contrib/vim: remove

Vim already includes support for bitbake syntax highlighting. This support was first added in vim commit b529cfb[1] and has been kept up-to-date ever since:

- 2041478e2a4f 2026-04-15 "support forward-slashes in bitbake varflags"
- 15e988810e7f 2026-04-07 "Update syntax script"
- 5fe4faa711b5 2025-10-13 "fix multiline Python function parameter syntax"
- b529cfbd04c0 2022-07-25 initial import

Initial support for bitbake syntax highlighting in upstream vim made it into release 9.0.0067; major release 9.1.0000.

Features that bitbake's code supports that upstream vim does not:

- bbStatementRestCont: a dedicated region that highlights addtask / EXPORT_FUNCTIONS / etc. lines that wrap with trailing \. Vim's runtime collapsed this back to a single-line rule, so multi-line statement lines do not highlight properly there.
- bbIncludeRest still contains bbVarPyValue (so ${@…} python expressions inside inherit/require/include paths get highlighted). Vim's runtime dropped that, leaving only bbString,bbVarDeref.

[1] https://github.com/vim/vim/commit/b529cfbd04c02e31cfa88f2c8d88b5ff532d4f7d

---
 contrib/vim/LICENSE.txt            |  18 --
 contrib/vim/ftdetect/bitbake.vim   |  32 ---
 contrib/vim/ftplugin/bitbake.vim   |  13 --
 contrib/vim/indent/bitbake.vim     | 343 -----------------------------
 contrib/vim/plugin/newbb.vim       |  88 --------
 contrib/vim/plugin/newbbappend.vim |  46 ----
 contrib/vim/syntax/bitbake.vim     | 131 -----------
 7 files changed, 671 deletions(-)
 delete mode 100644 contrib/vim/LICENSE.txt
 delete mode 100644 contrib/vim/ftdetect/bitbake.vim
 delete mode 100644 contrib/vim/ftplugin/bitbake.vim
 delete mode 100644 contrib/vim/indent/bitbake.vim
 delete mode 100644 contrib/vim/plugin/newbb.vim
 delete mode 100644 contrib/vim/plugin/newbbappend.vim
 delete mode 100644 contrib/vim/syntax/bitbake.vim
contrib/vim/LICENSE.txt deleted +0 -18
deleted file mode 100644
index c7d915024d9f..000000000000
@@ -1,18 +0,0 @@
-The MIT License (MIT)
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of
-this software and associated documentation files (the "Software"), to deal in
-the Software without restriction, including without limitation the rights to
-use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
-the Software, and to permit persons to whom the Software is furnished to do so,
-subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
-FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
-COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
-IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
contrib/vim/ftdetect/bitbake.vim deleted +0 -32
deleted file mode 100644
index 1d958fec5477..000000000000
@@ -1,32 +0,0 @@
-" Vim filetype detection file
-" Language:     BitBake
-" Author:       Ricardo Salveti <[email protected]>
-" Copyright:    Copyright (C) 2008  Ricardo Salveti <[email protected]>
-" Licence:      You may redistribute this under the same terms as Vim itself
-"
-" This sets up the syntax highlighting for BitBake files, like .bb, .bbclass and .inc
-
-if &compatible || version < 600 || exists("b:loaded_bitbake_plugin")
-    finish
-endif
-
-" .bb, .bbappend and .bbclass
-au BufNewFile,BufRead *.{bb,bbappend,bbclass}  setfiletype bitbake
-
-" .inc -- meanwhile included upstream
-if !has("patch-9.1.1732")
-    au BufNewFile,BufRead *.inc                call s:BBIncDetect()
-    def s:BBIncDetect()
-        var lines = getline(1) .. getline(2) .. getline(3)
-        if lines =~# '\<\%(require\|inherit\)\>' || lines =~# '[A-Z][A-Za-z0-9_:${}/]*\s\+\%(??\|[?:+.]\)\?=.\? '
-            set filetype=bitbake
-        endif
-    enddef
-endif
-
-" .conf
-au BufNewFile,BufRead *.conf
-    \ if (match(expand("%:p:h"), "conf") > 0) |
-    \     set filetype=bitbake |
-    \ endif
-
contrib/vim/ftplugin/bitbake.vim deleted +0 -13
deleted file mode 100644
index 9e8d3e13cee4..000000000000
@@ -1,13 +0,0 @@
-" Only do this when not done yet for this buffer
-if exists("b:did_ftplugin")
-  finish
-endif
-
-" Don't load another plugin for this buffer
-let b:did_ftplugin = 1
-
-let b:undo_ftplugin = "setl cms< sts< sw< et< sua<"
-
-setlocal commentstring=#\ %s
-setlocal softtabstop=4 shiftwidth=4 expandtab
-setlocal suffixesadd+=.bb,.bbclass
contrib/vim/indent/bitbake.vim deleted +0 -343

343 lines not on this page · raw message

contrib/vim/plugin/newbb.vim deleted +0 -88

88 lines not on this page · raw message

contrib/vim/plugin/newbbappend.vim deleted +0 -46

46 lines not on this page · raw message

contrib/vim/syntax/bitbake.vim deleted +0 -131

131 lines not on this page · raw message

Signature · 1 line
2.51.0