media: ti: vpe: unwind v4l2 device registration on probe error
Subsystems (3)
PATCH 1/1 media: ti: vpe: unwind v4l2 device registration on probe error
From: Myeonghun Pak <[email protected]>
If the vpe_top resource is missing, vpe_probe() returns -ENODEV after v4l2_device_register() has succeeded. Probe failures do not call the driver's remove callback, so the v4l2 device remains registered on that error path.
Route that failure through the existing v4l2_device_unregister() unwind label, matching the other errors after v4l2_device_register().
---
Notes for send preparation:
- Fixes tag was validated against upstream history; the local row worktree remains shallow/grafted and cannot verify it by itself.
- Build was not completed because this worktree has no .config.
drivers/media/platform/ti/vpe/vpe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/ti/vpe/vpe.c +2 -1
@@ -2539,7 +2539,8 @@ static int vpe_probe(struct platform_device *pdev) "vpe_top");if (!dev->res) {dev_err (&pdev->dev,"missing 'vpe_top' resources data\n" ); -return -ENODEV ; + ret = -ENODEV ; + goto v4l2_dev_unreg; }/*
Signature · 1 line
2.39.5
Hi,
Quoted 15 lines · 박명훈
From: Myeonghun Pak <[email protected]>
If the
vpe_topresource is missing,vpe_probe()returns-ENODEVafterv4l2_device_register()has succeeded. Probe failures do not call the driver's remove callback, so the v4l2 device remains registered on that error path.Route that failure through the existing
v4l2_device_unregister()unwind label, matching the other errors afterv4l2_device_register().Fixes 4d59c7d45585 ("media: ti-vpe: vpe: Add missing null pointer checks")Co-developed-by Ijae Kim <[email protected]>Signed-off-by Ijae Kim <[email protected]>Signed-off-by Myeonghun Pak <[email protected]>
Quoted 6 lines
---
Notes for send preparation:
- Fixes tag was validated against upstream history; the local row worktree remains shallow/grafted and cannot verify it by itself.
- Build was not completed because this worktree has no .config.
Why can't you build test?
Having said that, the fix seems trivial and correct to me. Hence
Quoted 17 lines
drivers/media/platform/ti/vpe/vpe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/media/platform/ti/vpe/vpe.c +2
-1@@ -2539,7 +2539,8 @@ static int vpe_probe(struct platform_device *pdev) "vpe_top");if (!dev->res) {dev_err (&pdev->dev,"missing 'vpe_top' resources data\n" ); -return -ENODEV ; + ret = -ENODEV ; + goto v4l2_dev_unreg; }/*