sched_ext: Relocate cpu_acquire/cpu_release to end of struct sched_ext_ops
Subsystems (2)
Tejun Heo
reviewerPATCH 5/17 sched_ext: Relocate cpu_acquire/cpu_release to end of struct sched_ext_ops
cpu_acquire and cpu_release are deprecated and slated for removal. Move their declarations to the end of struct sched_ext_ops so an upcoming cid-form struct (sched_ext_ops_cid) can omit them entirely without disturbing the offsets of the shared fields.
Switch the two SCX_HAS_OP() callers for these ops to direct field checks since the relocated ops sit outside the SCX_OPI_END range covered by the has_op bitmap.
scx_kf_allow_flags[] auto-sizes to the highest used SCX_OP_IDX, so SCX_OP_IDX(cpu_release) moving to a higher index just enlarges the sparse array; the lookup logic is unchanged.
Signed-off-by Tejun Heo <[email protected]>
Reviewed-by Cheng-Yang Chou <[email protected]>
--- kernel/sched/ext.c | 4 +-- kernel/sched/ext_internal.h | 54 ++++++++++++++++++++++--------------- 2 files changed, 34 insertions(+), 24 deletions(-)
kernel/sched/ext.c +2 -2
@@ -2814,7 +2814,7 @@ static int balance_one(struct rq *rq, struct task_struct *prev)* core. This callback complements ->cpu_release(), which is * emitted in switch_class(). */ -if (SCX_HAS_OP (sch, cpu_acquire)) +if (sch->ops.cpu_acquire)SCX_CALL_OP (sch, cpu_acquire, rq, cpu,NULL ); rq->scx.cpu_released = false; }
@@ -2960,7 +2960,7 @@ static void switch_class(struct rq *rq, struct task_struct *next)* next time that balance_one() is invoked. */ if (!rq->scx.cpu_released) { -if (SCX_HAS_OP (sch, cpu_release)) { +if (sch->ops.cpu_release) {struct scx_cpu_release_args args = { .reason =preempt_reason_from_class (next_class), .task = next,
kernel/sched/ext_internal.h +32 -22
66 lines not on this page · raw message
Signature · 1 line
2.53.0