Skip to contentSkip to conversation

drm/panel: feiyang-fy07024di26a30d: return display-on error

PATCH Applied Christian Van 2 participants 3 messages Apr 25 – May 5

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: feiyang-fy07024di26a30d: return display-on error

mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable() currently ignores it and always reports success.

Return the DCS command result so callers can observe enable failures.

---
 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +1 -3
index 4f8d6d8c0..dbdb7e3cb 100644
@@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
 	/* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
 	msleep(200);
 
-	mipi_dsi_dcs_set_display_on(ctx->dsi);
-
-	return 0;
+	return mipi_dsi_dcs_set_display_on(ctx->dsi);
 }
 
 static int feiyang_disable(struct drm_panel *panel)
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Christian Van

mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable() currently ignores it and always reports success.

Return the DCS command result so callers can observe enable failures.

---
  drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +0 -0
index 4f8d6d8c0..dbdb7e3cb 100644

drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c static int feiyang_enable(struct drm_panel *panel) · line 104

Quoted 10 lines
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +1 -3
@@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
  	/* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
  	msleep(200);
 
-	mipi_dsi_dcs_set_display_on(ctx->dsi);
-
-	return 0;
+	return mipi_dsi_dcs_set_display_on(ctx->dsi);
  }
 
  static int feiyang_disable(struct drm_panel *panel)

Thanks,
Neil

maintainer Applied
#2 lore raw
In reply to Christian Van

Hi,

Quoted 4 lines · Christian Van

mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable() currently ignores it and always reports success.

Return the DCS command result so callers can observe enable failures.

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: feiyang-fy07024di26a30d: return display-on error

      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c67e8787f6743101c90c7a9c4bb7cf6f1f739f83
Signature · 1 line
Neil