Skip to contentSkip to conversation

ASoC: tegra: Remove stale snd-soc-tegra-utils composite module definition

PATCH In review Sasha Levin 2 participants 2 messages Apr 26 – Apr 27

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tegra: Remove stale snd-soc-tegra-utils composite module definition

kconfiglint reports two warnings for sound/soc/tegra/Makefile:

M002: composite module 'snd-soc-tegra-utils' defined but not in any obj-*
M008: composite module 'snd-soc-tegra-utils': tegra_asoc_utils.o has no
source file

The composite module definition
snd-soc-tegra-utils-y += tegra_asoc_utils.o references a source file that no longer exists and defines a module that is never included in any obj-* target.

The tegra_asoc_utils module was originally introduced in commit a3cd50deef7b ("ASoC: Tegra: Move utilities to separate module") by Stephen Warren in 2011 to provide shared clock/rate utility functions for Tegra machine drivers. At that time, the Makefile had both the composite definition (snd-soc-tegra-utils-objs) and the build target (obj-$(CONFIG_SND_TEGRA_SOC) += snd-soc-tegra-utils.o).

In 2021,
commit 8c1b3b159300 ("ASoC: tegra: Squash utils into common machine driver")
by Dmitry Osipenko merged tegra_asoc_utils.c into tegra_asoc_machine.c, deleting both the .c and .h files. That commit correctly removed the obj-* build target line but overlooked the composite module definition line (snd-soc-tegra-utils-objs += tegra_asoc_utils.o).

The orphaned line persisted unnoticed and was even mechanically updated in 2024 by
commit 51a50d6ad727 ("ASoC: tegra: Use *-y instead of *-objs in Makefile")
by Takashi Iwai, which converted it from -objs to -y syntax as part of a treewide cleanup — inadvertently refreshing a stale definition.

Remove the orphaned composite module definition since it serves no purpose:
the source file was deleted, the obj-* target was already removed, and the functionality now lives in tegra_asoc_machine.c.

Assisted-by Claude:claude-opus-4-6 kconfiglint
---
 sound/soc/tegra/Makefile | 1 -
 1 file changed, 1 deletion(-)
sound/soc/tegra/Makefile +0 -1
index 3f396c87802ed..1c18ef6971c09 100644
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 # Tegra platform Support
 snd-soc-tegra-pcm-y := tegra_pcm.o
-snd-soc-tegra-utils-y += tegra_asoc_utils.o
 snd-soc-tegra20-ac97-y := tegra20_ac97.o
 snd-soc-tegra20-das-y := tegra20_das.o
 snd-soc-tegra20-i2s-y := tegra20_i2s.o
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 1 line · Sasha Levin

ASoC: tegra: Remove stale snd-soc-tegra-utils composite module definition

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/1] ASoC: tegra: Remove stale snd-soc-tegra-utils composite module definition

      https://git.kernel.org/broonie/sound/c/dad701bdb743

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark