Skip to contentSkip to conversation

firmware: tegra: Make TEGRA_IVC a hidden Kconfig symbol

PATCH Applied Sasha Levin 2 participants 2 messages Apr 26 – May 28 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: tegra: Make TEGRA_IVC a hidden Kconfig symbol

kconfiglint reports:

K002: config TEGRA_BPMP selects visible symbol TEGRA_IVC which has
dependencies

TEGRA_IVC was originally introduced in
commit ca791d7f4256 ("firmware: tegra:
Add IVC library") as a user-visible
bool with a prompt ("Tegra IVC protocol"). At that time, TEGRA_BPMP depended on TEGRA_IVC, requiring users to manually enable it.

Recently,
commit 78eb18020a88 ("firmware: tegra: Fix IVC dependency problems") recognized that TEGRA_IVC is library code that should be activated via select rather than user selection. That commit changed TEGRA_BPMP from depends on TEGRA_IVC to select TEGRA_IVC, and restricted TEGRA_IVC's prompt to only appear under COMPILE_TEST
(bool "Tegra IVC protocol" if COMPILE_TEST). The commit message explicitly states: "The IVC code is library code that other drivers need to select if they need that library."

However, the if COMPILE_TEST qualifier still leaves TEGRA_IVC as a technically visible symbol, triggering K002 when TEGRA_BPMP selects it. Since TEGRA_IVC depends on ARCH_TEGRA, it cannot be independently enabled under COMPILE_TEST without ARCH_TEGRA anyway, limiting the value of the standalone COMPILE_TEST path. TEGRA_BPMP itself provides adequate COMPILE_TEST coverage for the IVC library through its own dependency chain.

Complete the transition to a pure library symbol by removing the prompt entirely, making TEGRA_IVC a hidden bool activated only via select from TEGRA_BPMP. This is consistent with the intent expressed in 78eb18020a88.

Assisted-by Claude:claude-opus-4-6 kconfiglint
---
 drivers/firmware/tegra/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/tegra/Kconfig +1 -1
index 91f2320c0d0f8..3a91627064390 100644
@@ -2,7 +2,7 @@
 menu "Tegra firmware driver"
 
 config TEGRA_IVC
-	bool "Tegra IVC protocol" if COMPILE_TEST
+	bool
 	depends on ARCH_TEGRA
 	help
 	  IVC (Inter-VM Communication) protocol is part of the IPC
Signature · 1 line
2.53.0
maintainer Applied
#1 lore raw

From: Thierry Reding <[email protected]>

Quoted 5 lines · Sasha Levin

kconfiglint reports:

K002: config TEGRA_BPMP selects visible symbol TEGRA_IVC which has
dependencies

Quoted 7 lines

TEGRA_IVC was originally introduced in
commit ca791d7f4256 ("firmware: tegra:
Add IVC library") as a user-visible
bool with a prompt ("Tegra IVC protocol"). At that time, TEGRA_BPMP depended on TEGRA_IVC, requiring users to manually enable it.

[...]

Applied, thanks!

[1/1] firmware: tegra: Make TEGRA_IVC a hidden Kconfig symbol

      commit: 55ee4d297e3929beac865714b681a4f25759868f

Best regards,

Signature · 1 line
Thierry Reding <[email protected]>