Skip to contentSkip to conversation

media: tegra-vde: Add HAS_IOMEM dependency to match SRAM select

PATCH New Sasha Levin 1 participant 1 message Apr 26

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: tegra-vde: Add HAS_IOMEM dependency to match SRAM select

kconfiglint reports:

K002: config VIDEO_TEGRA_VDE selects visible symbol SRAM which has
dependencies

VIDEO_TEGRA_VDE selects SRAM, which is defined in drivers/misc/Kconfig as:

config SRAM
bool "Generic on-chip SRAM driver"
depends on HAS_IOMEM

The NVIDIA Tegra video decoder driver was originally introduced in commit cd6c56feb591 ("media: staging: media: Introduce NVIDIA Tegra video decoder driver")
as a staging driver with `depends on
ARCH_TEGRA || COMPILE_TEST` and
select SRAM. Since all Tegra SoCs have HAS_IOMEM, the SRAM dependency was implicitly satisfied for real hardware configurations.

The driver was later de-staged in commit 8bd4aaf438e3 ("media: staging:
tegra-vde: De-stage driver") and relocated to drivers/media/platform/nvidia/tegra-vde/ in commit 9b18ef7c9ff4 ("media:
platform: rename tegra/vde/ to nvidia/tegra-vde/"). Throughout these moves, the select SRAM remained without a corresponding HAS_IOMEM dependency.

Under COMPILE_TEST on a hypothetical architecture without HAS_IOMEM (such as UML in some configurations), the select would force SRAM on without its HAS_IOMEM dependency being met. Add an explicit depends on HAS_IOMEM to make the dependency chain complete and prevent this misconfiguration under COMPILE_TEST.

Assisted-by Claude:claude-opus-4-6 kconfiglint
---
 drivers/media/platform/nvidia/tegra-vde/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/nvidia/tegra-vde/Kconfig +1 -0
index 2fe13f39c95bb..f05fcc94decaf 100644
@@ -2,6 +2,7 @@ config VIDEO_TEGRA_VDE
 	tristate "NVIDIA Tegra Video Decoder Engine driver"
 	depends on V4L_MEM2MEM_DRIVERS
 	depends on ARCH_TEGRA || COMPILE_TEST
+	depends on HAS_IOMEM
 	depends on VIDEO_DEV
 	select DMA_SHARED_BUFFER
 	select IOMMU_IOVA
Signature · 1 line
2.53.0