hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference
PATCH 1/1 hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference
kconfiglint reports:
X001: CONFIG_SENSORS_SBRMI referenced in Makefile but not defined
in any Kconfig
The SB-RMI hardware monitoring driver was originally introduced in commit 5a0f50d110b3 ("hwmon: Add support for SB-RMI power module") with both a Kconfig entry (CONFIG_SENSORS_SBRMI) and a Makefile line (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) in drivers/hwmon/.
Commit e156586764050 ("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc")
moved the driver to drivers/misc/amd-sbi/ to support additional functionality beyond hardware monitoring. That commit correctly removed the Kconfig entry from drivers/hwmon/Kconfig, moved the source file drivers/hwmon/sbrmi.c to drivers/misc/amd-sbi/sbrmi.c, and created new Kconfig/Makefile entries in drivers/misc/amd-sbi/ with a renamed symbol (CONFIG_AMD_SBRMI_I2C).
However, the Makefile line in drivers/hwmon/Makefile was not removed in that commit. The orphaned line references a CONFIG symbol that no longer exists and a source file that is no longer present, so it has no effect on the build — but it is dead code that should be cleaned up.
Remove the stale Makefile reference.
--- drivers/hwmon/Makefile | 1 - 1 file changed, 1 deletion(-)
drivers/hwmon/Makefile +0 -1
@@ -201,7 +201,6 @@ obj-$(CONFIG_SENSORS_PWM_FAN) += pwm-fan.o obj-$(CONFIG_SENSORS_QNAP_MCU_HWMON) += qnap-mcu-hwmon.o obj-$(CONFIG_SENSORS_RASPBERRYPI_HWMON) += raspberrypi-hwmon.o obj-$(CONFIG_SENSORS_SBTSI) += sbtsi_temp.o -obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o obj-$(CONFIG_SENSORS_SCH56XX_COMMON)+= sch56xx-common.o obj-$(CONFIG_SENSORS_SCH5627) += sch5627.o obj-$(CONFIG_SENSORS_SCH5636) += sch5636.o
Signature · 1 line
2.53.0
Quoted 24 lines · Sasha Levin
kconfiglint reports:
X001:
CONFIG_SENSORS_SBRMIreferenced inMakefilebut not defined
in anyKconfigThe SB-RMI hardware monitoring driver was originally introduced in commit
5a0f50d110b3("hwmon: Add support for SB-RMI power module") with both aKconfigentry (CONFIG_SENSORS_SBRMI) and aMakefileline (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) indrivers/hwmon/.Commit
e156586764050("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc")
moved the driver todrivers/misc/amd-sbi/to support additional functionality beyond hardware monitoring. That commit correctly removed theKconfigentry fromdrivers/hwmon/Kconfig, moved the source filedrivers/hwmon/sbrmi.ctodrivers/misc/amd-sbi/sbrmi.c, and created new Kconfig/Makefile entries indrivers/misc/amd-sbi/with a renamed symbol (CONFIG_AMD_SBRMI_I2C).However, the
Makefileline indrivers/hwmon/Makefilewas not removed in that commit. The orphaned line references a CONFIG symbol that no longer exists and a source file that is no longer present, so it has no effect on the build — but it is dead code that should be cleaned up.
Quoted 4 lines
Remove the stale
Makefilereference.Assisted-by Claude:claude-opus-4-6 kconfiglintSigned-off-by Sasha Levin <[email protected]>
Applied.
Thanks,
Guenter