leds: as3668: Fix Kconfig symbol name mismatch in Makefile
PATCH 1/1 leds: as3668: Fix Kconfig symbol name mismatch in Makefile
kconfiglint reports:
X001: CONFIG_LEDS_AS3668 referenced in Makefile but not defined
in any Kconfig
The AS3668 LED driver was introduced in
commit c7dd343a3756 ("leds:
as3668: Driver for the ams Osram 4-channel i2c LED driver"). That commit defined the Kconfig symbol as LEDS_OSRAM_AMS_AS3668 in drivers/leds/Kconfig but used the shorter name LEDS_AS3668 in the Makefile's obj-* line.
Because the Makefile references CONFIG_LEDS_AS3668 which does not exist, the driver can never be built — the obj-* line always evaluates to obj- += leds-as3668.o (empty config), so the object file is never compiled regardless of what the user selects in menuconfig.
Fix the Makefile to reference the correct Kconfig symbol CONFIG_LEDS_OSRAM_AMS_AS3668, matching what is defined in drivers/leds/Kconfig.
--- drivers/leds/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/Makefile +1 -1
@@ -15,7 +15,7 @@ obj-$(CONFIG_LEDS_ADP5520) += leds-adp5520.o obj-$(CONFIG_LEDS_AN30259A) += leds-an30259a.o obj-$(CONFIG_LEDS_APU) += leds-apu.o obj-$(CONFIG_LEDS_ARIEL) += leds-ariel.o -obj-$(CONFIG_LEDS_AS3668) += leds-as3668.o +obj-$(CONFIG_LEDS_OSRAM_AMS_AS3668) += leds-as3668.o obj-$(CONFIG_LEDS_AW200XX) += leds-aw200xx.o obj-$(CONFIG_LEDS_AW2013) += leds-aw2013.o obj-$(CONFIG_LEDS_BCM6328) += leds-bcm6328.o
Signature · 1 line
2.53.0
Quoted 12 lines · Sasha Levin
kconfiglint reports:
X001:
CONFIG_LEDS_AS3668referenced inMakefilebut not defined
in anyKconfigThe AS3668 LED driver was introduced in
commitc7dd343a3756("leds:
as3668: Driver for the ams Osram 4-channel i2c LED driver"). That commit defined theKconfigsymbol asLEDS_OSRAM_AMS_AS3668indrivers/leds/Kconfigbut used the shorter nameLEDS_AS3668in the Makefile's obj-* line.
Quoted 4 lines
Because the
MakefilereferencesCONFIG_LEDS_AS3668which does not exist, the driver can never be built — the obj-* line always evaluates to obj- += leds-as3668.o (empty config), so the object file is never compiled regardless of what the user selects in menuconfig.
Thanks for pointing that out. Seems like I tested with an older .config or something like that.
Quoted 28 lines
Fix the
Makefileto reference the correctKconfigsymbolCONFIG_LEDS_OSRAM_AMS_AS3668, matching what is defined indrivers/leds/Kconfig.Assisted-by Claude:claude-opus-4-6 kconfiglintSigned-off-by Sasha Levin <[email protected]>--- drivers/leds/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/leds/Makefile +1
-1@@ -15,7 +15,7 @@ obj-$(CONFIG_LEDS_ADP5520) += leds-adp5520.o obj-$(CONFIG_LEDS_AN30259A) += leds-an30259a.o obj-$(CONFIG_LEDS_APU) += leds-apu.o obj-$(CONFIG_LEDS_ARIEL) += leds-ariel.o -obj-$(CONFIG_LEDS_AS3668) += leds-as3668.o +obj-$(CONFIG_LEDS_OSRAM_AMS_AS3668) += leds-as3668.o obj-$(CONFIG_LEDS_AW200XX) += leds-aw200xx.o obj-$(CONFIG_LEDS_AW2013) += leds-aw2013.o obj-$(CONFIG_LEDS_BCM6328) += leds-bcm6328.oSignature · 1 line
2.53.0
Re: (subset) [PATCH] leds: as3668: Fix Kconfig symbol name mismatch in Makefile
In reply to Sasha LevinQuoted 5 lines · Sasha Levin
kconfiglint reports:
X001:
CONFIG_LEDS_AS3668referenced inMakefilebut not defined
in anyKconfig
Quoted 8 lines
The AS3668 LED driver was introduced in
commitc7dd343a3756("leds:
as3668: Driver for the ams Osram 4-channel i2c LED driver"). That commit defined theKconfigsymbol asLEDS_OSRAM_AMS_AS3668indrivers/leds/Kconfigbut used the shorter nameLEDS_AS3668in the Makefile's obj-* line.[...]
Applied, thanks!
[1/1] leds: as3668: Fix Kconfig symbol name mismatch in Makefile
commit: b24e1049a5a53f0912046a8f4112d2d43dec74e7
--
Lee Jones [李琼斯]