Skip to contentSkip to conversation

Rust DRM build fix

PATCH Applied Mukesh Kumar Chaurasiya (IBM) 2 participants 3 messages Apr 26 – Apr 27

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Rust DRM build fix

rust drm gem shmem doesn't builds due to an import error of ARef from types instead of sync.

Changelog:

V1 -> V2:
- Removed the 2nd patch as it was by design
- Removed unnecessary braces around the Opaque mod
- Minor change in commit message
V1: https://lore.kernel.org/all/[email protected]/

Mukesh Kumar Chaurasiya (IBM) (1):
rust/drm: import ARef from sync crate

 rust/kernel/drm/gem/shmem.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH v2 1/1 rust/drm: import ARef from sync crate

ARef is defined in sync and is getting used from types causing the build to fail.

Fix this by using ARef from sync module.

---
 rust/kernel/drm/gem/shmem.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
rust/kernel/drm/gem/shmem.rs +2 -4
index d025fb035195..e1b648920d2f 100644
@@ -19,10 +19,8 @@
     },
     error::to_result,
     prelude::*,
-    types::{
-        ARef,
-        Opaque, //
-    }, //
+    sync::aref::ARef,
+    types::Opaque, //
 };
 use core::{
     ops::{
Signature · 1 line
2.53.0
maintainer Applied
#2 lore raw
In reply to Mukesh Kumar Chaurasiya (IBM)
Quoted 1 line · Mukesh Kumar Chaurasiya (IBM)

[PATCH V2 0/1] Rust DRM build fix

Applied, thanks!

Branch: drm-rust-next
Tree: https://gitlab.freedesktop.org/drm/rust/kernel.git

[1/1] rust/drm: import ARef from sync crate
commit: 5f69165b7e42

[ Add missing Fixes: tag. - Danilo ]

The patch will appear in the next linux-next integration (typically within 24 hours on weekdays).

The patch is queued up for the upcoming merge window for the next major kernel release.