iio: ssp_sensors: cleanup codestyle warning
PATCH 1/1 iio: ssp_sensors: cleanup codestyle warning
From: Sanjay Chitroda <[email protected]>
Reported by checkpatch:
FILE: drivers/iio/common/ssp_sensors/ssp_iio.c
WARNING: Block comments use a trailing */ on a separate line
+ * */
--- drivers/iio/common/ssp_sensors/ssp_iio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/common/ssp_sensors/ssp_iio.c +3 -2
@@ -24,9 +24,10 @@ int ssp_common_buffer_postenable(struct iio_dev *indio_dev)struct ssp_sensor_data *spd =iio_priv (indio_dev);struct ssp_data *data =dev_get_drvdata (indio_dev->dev.parent->parent); -/* the allocation is made in post because scan size is known in this +/* +* the allocation is made in post because scan size is known in this * moment -* */ +*/ spd->buffer =kmalloc (indio_dev->scan_bytes,GFP_KERNEL |GFP_DMA );if (!spd->buffer)return -ENOMEM ;
Signature · 1 line
2.34.1
Jonathan Cameron
maintainerQuoted 18 lines · On Sun, 26 Apr 2026 16:26:53 +0530 Sanjay Chitroda…
From: Sanjay Chitroda <[email protected]>
Reported by checkpatch:
FILE:drivers/iio/common/ssp_sensors/ssp_iio.cWARNING: Block comments use a trailing */ on a separate line
(quoted diff) +1
-0+ * */Signed-off-by Sanjay Chitroda <[email protected]>--- drivers/iio/common/ssp_sensors/ssp_iio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/common/ssp_sensors/ssp_iio.c +0
-0
drivers/iio/common/ssp_sensors/ssp_iio.c int ssp_common_buffer_postenable(struct iio_dev *indio_dev) · line 31
Quoted 10 lines
drivers/iio/common/ssp_sensors/ssp_iio.c +3
-2@@ -24,9 +24,10 @@ int ssp_common_buffer_postenable(struct iio_dev *indio_dev)struct ssp_sensor_data *spd =iio_priv (indio_dev);struct ssp_data *data =dev_get_drvdata (indio_dev->dev.parent->parent); -/* the allocation is made in post because scan size is known in this +/* +* the allocation is made in post because scan size is known in this * moment -* */ +*/ spd->buffer =kmalloc (indio_dev->scan_bytes,GFP_KERNEL |GFP_DMA );
Hmm - I missed this in previous but you dropped a GFP_DMA marking and it's just possible this platform has restricted DMA addressing and needs them.
Otherwise it should be easy to cap how big this buffer can get and hence do similar change to make it fixed size in ssp_sensor_data.
Quoted 2 lines
drivers/iio/common/ssp_sensors/ssp_iio.c +0
-0if (!spd->buffer)return -ENOMEM ;
Quoted 5 lines · Sanjay Chitroda
Reported by checkpatch:
FILE:drivers/iio/common/ssp_sensors/ssp_iio.cWARNING: Block comments use a trailing */ on a separate line
(quoted diff) +1
-0+ * */
...
drivers/iio/common/ssp_sensors/ssp_iio.c int ssp_common_buffer_postenable(struct iio_dev *indio_dev) · line 30
Quoted 6 lines
drivers/iio/common/ssp_sensors/ssp_iio.c +3
-2-/* the allocation is made in post because scan size is known in this +/* +* the allocation is made in post because scan size is known in this * moment -* */ +*/
Fix the English grammar and punctuations at the same time.
Signature · 2 lines
With Best Regards, Andy Shevchenko