dt-bindings: regulator: fcs,fan53555: Remove vsel-gpios property

The vsel-gpios property is currently documented in the binding but is not used by the driver. The FAN53555 family of regulators supports two voltage selector registers (VSEL0/VSEL1), and the selection between them is intended to be controlled by an external hardware pin (VSEL). However, the driver does not support dynamic toggling of this pin via a GPIO, it only uses the fcs,suspend-voltage-selector property to statically assign which register is used for runtime voltage and which for suspend voltage.
Remove the vsel-gpios property from the binding to prevent incorrect DT usage and to reflect the actual hardware description supported by the driver.

Signed-off-by Alexander Shiyan <[email protected]>

---
 .../devicetree/bindings/regulator/fcs,fan53555.yaml          | 5 -----
 1 file changed, 5 deletions(-)

Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml +0 -5

index 69bae90fc4b2..7f3b74ccf8db 100644
@@ -43,11 +43,6 @@ properties:
   vin-supply:
     description: Supply for the vin pin
 
-  vsel-gpios:
-    description: Voltage Select. When this pin is LOW, VOUT is set by the
-      VSEL0 register. When this pin is HIGH, VOUT is set by the VSEL1 register.
-    maxItems: 1
-
 required:
   - compatible
   - reg

Signature · 1 line

2.52.0

Quoted 11 lines

The vsel-gpios property is currently documented in the binding but is not used by the driver. The FAN53555 family of regulators supports two voltage selector registers (VSEL0/VSEL1), and the selection between them is intended to be controlled by an external hardware pin (VSEL). However, the driver does not support dynamic toggling of this pin via a GPIO, it only uses the fcs,suspend-voltage-selector property to statically assign which register is used for runtime voltage and which for suspend voltage.
Remove the vsel-gpios property from the binding to prevent incorrect DT usage and to reflect the actual hardware description supported by the driver.

From the wording/justification here, I disagree with this patch. The binding should document what the hardware can do, not what the driver can.

Maybe instead you should make fcs,suspend-voltage-selector mutually exclusive with vsel-gpios?

Hello Comor.

Quoted 17 lines · Alexander Shiyan

Quoted 11 lines

The vsel-gpios property is currently documented in the binding but is not used by the driver. The FAN53555 family of regulators supports two voltage selector registers (VSEL0/VSEL1), and the selection between them is intended to be controlled by an external hardware pin (VSEL). However, the driver does not support dynamic toggling of this pin via a GPIO, it only uses the fcs,suspend-voltage-selector property to statically assign which register is used for runtime voltage and which for suspend voltage.
Remove the vsel-gpios property from the binding to prevent incorrect DT usage and to reflect the actual hardware description supported by the driver.

From the wording/justification here, I disagree with this patch. The binding should document what the hardware can do, not what the driver can.

Quoted 2 lines

Maybe instead you should make fcs,suspend-voltage-selector mutually exclusive with vsel-gpios?

The main problem here is that this feature (vsel-gpios) was never implemented in the driver. So, the patch consists solely of removing a non-existent property.

Rob's 2023 patch that added the property even says "Add the undocumented 'vsel-gpios' property used to control the VSEL pin.", so having it was an intentional decision by the main binding maintainer!