ALSA: usb-audio: Avoid potential endless loop in convert_chmap_v3()
PATCH 1/1 ALSA: usb-audio: Avoid potential endless loop in convert_chmap_v3()
The convert_chmap_v3() has a loop with its increment size of cs_len->wLength, but we forgot to validate cs_desc->wLength itself, which may lead to potential endless loop by a malformed descriptor.
Add a proper size check to abort the loop for plugging the hole.
Fixes ecfd41166b72 ("ALSA: usb-audio: Validate UAC3 cluster segment descriptors")
Cc <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/usb/stream.c | 2 ++ 1 file changed, 2 insertions(+)
sound/usb/stream.c +2 -0
@@ -353,6 +353,8 @@ snd_pcm_chmap_elem *convert_chmap_v3(struct uac3_cluster_header_descriptorif (len <sizeof (*cs_desc))break ; cs_len =le16_to_cpu (cs_desc->wLength); +if (cs_len <sizeof (*cs_desc)) +break ;if (len < cs_len)break ; cs_type = cs_desc->bSegmentType;
Signature · 1 line
2.54.0