FAILED: patch "[PATCH] leds: qcom-lpg: Check for array overflow when selecting the" failed to apply to 5.15-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x d45963a93c1495e9f1338fde91d0ebba8fd22474
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026042743-vacancy-unread-9565@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From d45963a93c1495e9f1338fde91d0ebba8fd22474 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <[email protected]>
Date: Thu, 19 Feb 2026 15:34:35 +0100
Subject: [PATCH] leds: qcom-lpg: Check for array overflow when selecting the
high resolution
When selecting the high resolution values from the array, FIELD_GET() is used to pull from a 3 bit register, yet the array being indexed has only 5 values in it. Odds are the hardware is sane, but just to be safe, properly check before just overflowing and reading random data and then setting up chip values based on that.
drivers/leds/rgb/leds-qcom-lpg.c +6 -1
@@ -1273,7 +1273,12 @@ static int lpg_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,return ret;if (chan->subtype ==LPG_SUBTYPE_HI_RES_PWM ) { - refclk = lpg_clk_rates_hi_res[FIELD_GET (PWM_CLK_SELECT_HI_RES_MASK , val)]; +unsigned int clk_idx =FIELD_GET (PWM_CLK_SELECT_HI_RES_MASK , val); + +if (clk_idx >=ARRAY_SIZE (lpg_clk_rates_hi_res)) +return -EINVAL ; + + refclk = lpg_clk_rates_hi_res[clk_idx]; resolution = lpg_pwm_resolution_hi_res[FIELD_GET (PWM_SIZE_HI_RES_MASK , val)]; }else { refclk = lpg_clk_rates[FIELD_GET (PWM_CLK_SELECT_MASK , val)];