Skip to contentSkip to conversation

m68k: coldfire: select legacy gpiolib interface for mcfqspi

PATCH Applied Arnd Bergmann 3 participants 3 messages Apr 28 – Apr 29 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: coldfire: select legacy gpiolib interface for mcfqspi

From: Arnd Bergmann <[email protected]>

The common coldfire code uses the old GPIO number based interfaces for at least the QSPI chipselect lines. Select the required Kconfig symbol to keep it building when that becomes optional.

Apparently there are no devices attached to a QSPI controller in any of the coldfire boards, so this is not actually used in upstream kernels.

---
 arch/m68k/Kconfig.cpu | 1 +
 1 file changed, 1 insertion(+)
arch/m68k/Kconfig.cpu +1 -0
index c9a7e602d8a4..148f8a79d206 100644
@@ -30,6 +30,7 @@ config COLDFIRE
 	select CPU_HAS_NO_MULDIV64
 	select GENERIC_CSUM
 	select GPIOLIB
+	select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
 	select HAVE_LEGACY_CLK
 	select HAVE_PAGE_SIZE_8KB if !MMU
 
Signature · 1 line
2.39.5
#1 lore raw

CC Greg

Quoted 28 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The common coldfire code uses the old GPIO number based interfaces for at least the QSPI chipselect lines. Select the required Kconfig symbol to keep it building when that becomes optional.

Apparently there are no devices attached to a QSPI controller in any of the coldfire boards, so this is not actually used in upstream kernels.

---
 arch/m68k/Kconfig.cpu | 1 +
 1 file changed, 1 insertion(+)
arch/m68k/Kconfig.cpu +1 -1
index c9a7e602d8a4..148f8a79d206 100644
@@ -30,6 +30,7 @@ config COLDFIRE
        select CPU_HAS_NO_MULDIV64
        select GENERIC_CSUM
        select GPIOLIB
+       select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
        select HAVE_LEGACY_CLK
        select HAVE_PAGE_SIZE_8KB if !MMU
 
--

2.39.5

Applied
#2 lore raw
In reply to Arnd Bergmann

Hi Arnd,

Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The common coldfire code uses the old GPIO number based interfaces for at least the QSPI chipselect lines. Select the required Kconfig symbol to keep it building when that becomes optional.

Apparently there are no devices attached to a QSPI controller in any of the coldfire boards, so this is not actually used in upstream kernels.

Thanks, applied to m68knommu for-next branch.

Regards
Greg

Quoted 16 lines
---
  arch/m68k/Kconfig.cpu | 1 +
  1 file changed, 1 insertion(+)
arch/m68k/Kconfig.cpu +1 -0
index c9a7e602d8a4..148f8a79d206 100644
@@ -30,6 +30,7 @@ config COLDFIRE
  	select CPU_HAS_NO_MULDIV64
  	select GENERIC_CSUM
  	select GPIOLIB
+	select GPIOLIB_LEGACY if SPI_COLDFIRE_QSPI
  	select HAVE_LEGACY_CLK
  	select HAVE_PAGE_SIZE_8KB if !MMU