hv: utils: replace deprecated strcpy with strscpy in kvp_register
Subsystems (2)
PATCH 1/1 hv: utils: replace deprecated strcpy with strscpy in kvp_register
strcpy() has been deprecated [1] because it performs no bounds checking on the destination buffer, which can lead to buffer overflows. While the current code works correctly, replace strcpy() with the safer strscpy() to follow secure coding best practices. Use ->body.kvp_register.version directly as the destination buffer and remove the local variable.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
---
Based on my other patch [1] which needs to be applied first.
[1] https://lore.kernel.org/lkml/[email protected]/
--- drivers/hv/hv_kvp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/hv/hv_kvp.c +2 -4
@@ -27,6 +27,7 @@#include <linux/connector.h> #include <linux/workqueue.h> #include <linux/hyperv.h> +#include <linux/string.h> #include <hyperv/hvhdk.h> #include "hyperv_vmbus.h"
@@ -130,18 +131,15 @@ static void kvp_register_done(void)static int kvp_register (int reg_value) { -struct hv_kvp_msg *kvp_msg; -char *version;int ret; kvp_msg =kzalloc_obj (*kvp_msg);if (!kvp_msg)return -ENOMEM ; - version = kvp_msg->body.kvp_register.version; kvp_msg->kvp_hdr.operation = reg_value; -strcpy (version,HV_DRV_VERSION ); +strscpy (kvp_msg->body.kvp_register.version,HV_DRV_VERSION ); ret =hvutil_transport_send (hvt, kvp_msg,sizeof (*kvp_msg), kvp_register_done);
Quoted 9 lines · Thorsten Blum
strcpy()has been deprecated [1] because it performs no bounds checking on the destination buffer, which can lead to buffer overflows. While the current code works correctly, replacestrcpy()with the saferstrscpy()to follow secure coding best practices. Use ->body.kvp_register.version directly as the destination buffer and remove the local variable.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by Thorsten Blum <[email protected]>
Applied. Thanks.