Skip to contentSkip to conversation

staging: media: atomisp: ov2722: clean up ov2722_startup()

PATCH In review Jack Lee 2 participants 2 messages Apr 29 – Apr 30

Subsystems (4)
lore
Share & tools
lore

Jack Lee

author
#0 lore raw

PATCH 1/1 staging: media: atomisp: ov2722: clean up ov2722_startup()

Remove stale TODO comment that has been present since the file was first added to staging in 2017 and was never really acted on. Also replace return ret with return 0 since ret is guaranteed to be zero at that point, both write calls return early on failure.

---
 drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +1 -2
index 2c41c496daa6..fcd71cc55731 100644
@@ -599,7 +599,6 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on)
 	return ret;
 }
 
-/* TODO: remove it. */
 static int ov2722_startup(struct v4l2_subdev *sd)
 {
 	struct ov2722_device *dev = to_ov2722_sensor(sd);
@@ -619,7 +618,7 @@ static int ov2722_startup(struct v4l2_subdev *sd)
 		return ret;
 	}
 
-	return ret;
+	return 0;
 }
 
 static int ov2722_set_fmt(struct v4l2_subdev *sd,
Signature · 1 line
2.54.0
#1 lore raw
Quoted 5 lines · Jack Lee

Remove stale TODO comment that has been present since the file was first added to staging in 2017 and was never really acted on. Also replace return ret with return 0 since ret is guaranteed to be zero at that point, both write calls return early on failure.

NAK. This is not a real change. It has no value on itself. Moreover, it removes a comment without actually addressing it.

Signature · 2 lines
With Best Regards,
Andy Shevchenko