Skip to contentSkip to conversation

BUG: KASAN: slab-out-of-bounds in ice_start_xmit+0x57cc/0x5ef0 [ice]

DISCUSSION Thomas Bogendoerfer 1 participant 1 message Apr 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

While working on another ice issue, I've noticed a KASAN splat, when using xskxceiver test program. This is caused by

        eth = (struct ethhdr *)skb_mac_header(skb);
...
	                           eth->h_proto == htons(ETH_P_LLDP)) &&

in ice_xmit_frame_ring().

It would be easy to check for the unset mac_header condition in ice driver (there are other drivers using skb_mac_header() in .ndo_start_xmit). But since __dev_queue_xmit() is doing a skb_reset_mac_header(), shouldn't __dev_direct_xmit() do the same ?

Thomas.

Signature · 3 lines
SUSE Software Solutions Germany GmbH__dev_queue_xmit
HRB 36809 (AG Nürnberg)
Geschäftsführer: Jochen Jaser, Andrew McDonald, Werner Knoblich