Skip to contentSkip to conversation

talitos: allocate channels with main struct

PATCH Superseded Rosen Penev 2 participants 2 messages Apr 30 – May 5 Crypto API

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH 1/1 talitos: allocate channels with main struct

Use a flexible array member to combine allocations.

Add __counted_by for extra runtime analysis.

Signed-off-by Rosen Penev <[email protected]>
---
 drivers/crypto/talitos.c | 17 +++++------------
 drivers/crypto/talitos.h |  5 +++--
 2 files changed, 8 insertions(+), 14 deletions(-)
drivers/crypto/talitos.c +5 -12
index bc61d0fe3514..98323c154031 100644
@@ -3409,14 +3409,18 @@ static int talitos_probe(struct platform_device *ofdev)
 	struct device *dev = &ofdev->dev;
 	struct device_node *np = ofdev->dev.of_node;
 	struct talitos_private *priv;
+	unsigned int num_channels;
 	int i, err;
 	int stride;
 	struct resource *res;
 
-	priv = devm_kzalloc(dev, sizeof(struct talitos_private), GFP_KERNEL);
+	of_property_read_u32(np, "fsl,num-channels", &num_channels);
+	priv = devm_kzalloc(dev, struct_size(priv, chan, num_channels), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
 
+	priv->num_channels = num_channels;
+
 	INIT_LIST_HEAD(&priv->alg_list);
 
 	dev_set_drvdata(dev, priv);

@@ -3436,7 +3440,6 @@ static int talitos_probe(struct platform_device *ofdev)
 	}
 
 	/* get SEC version capabilities from device tree */
-	of_property_read_u32(np, "fsl,num-channels", &priv->num_channels);
 	of_property_read_u32(np, "fsl,channel-fifo-len", &priv->chfifo_len);
 	of_property_read_u32(np, "fsl,exec-units-mask", &priv->exec_units);
 	of_property_read_u32(np, "fsl,descriptor-types-mask",

@@ -3511,16 +3514,6 @@ static int talitos_probe(struct platform_device *ofdev)
 		}
 	}
 
-	priv->chan = devm_kcalloc(dev,
-				  priv->num_channels,
-				  sizeof(struct talitos_channel),
-				  GFP_KERNEL);
-	if (!priv->chan) {
-		dev_err(dev, "failed to allocate channel management space\n");
-		err = -ENOMEM;
-		goto err_out;
-	}
-
 	priv->fifo_len = roundup_pow_of_two(priv->chfifo_len);
 
 	for (i = 0; i < priv->num_channels; i++) {
drivers/crypto/talitos.h +3 -2
index 1a93ee355929..34b0b5fab7e7 100644
@@ -139,8 +139,6 @@ struct talitos_private {
 	 */
 	unsigned int fifo_len;
 
-	struct talitos_channel *chan;
-
 	/* next channel to be assigned next incoming descriptor */
 	atomic_t last_chan ____cacheline_aligned;
 

@@ -153,6 +151,9 @@ struct talitos_private {
 	/* hwrng device */
 	struct hwrng rng;
 	bool rng_registered;
+
+	struct talitos_channel chan[] __counted_by(num_channels);
+
 };
 
 /* .features flag */
Signature · 1 line
2.54.0
maintainer
#1 lore raw

drivers/crypto/talitos.c static int talitos_probe(struct platform_device *ofdev) · line 3417

Quoted 3 lines · Rosen Penev
drivers/crypto/talitos.c +1 -1
-	priv = devm_kzalloc(dev, sizeof(struct talitos_private), GFP_KERNEL);
+	of_property_read_u32(np, "fsl,num-channels", &num_channels);

Sashiko suggests that you check the return value of this call:

https://sashiko.dev/#/patchset/20260430214340.59588-1-rosenp%40gmail.com

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt