Skip to contentSkip to conversation

dt-bindings: hwmon: zyxel,nsa320-mcu: convert to DT schema

PATCH Applied Manish Baing 4 participants 5 messages May 1 – May 5

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: hwmon: zyxel,nsa320-mcu: convert to DT schema

Convert the ZyXEL NSA320 MCU bindings from text format to YAML schema.

---
 .../devicetree/bindings/hwmon/nsa320-mcu.txt  | 20 -------
 .../bindings/hwmon/zyxel,nsa320-mcu.yaml      | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml
Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt deleted +0 -20
deleted file mode 100644
index 0863e067c85b..000000000000
@@ -1,20 +0,0 @@
-Bindings for the fan / temperature monitor microcontroller used on
-the Zyxel NSA 320 and several subsequent models.
-
-Required properties:
-- compatible	: "zyxel,nsa320-mcu"
-- data-gpios	: The GPIO pin connected to the data line on the MCU
-- clk-gpios	: The GPIO pin connected to the clock line on the MCU
-- act-gpios	: The GPIO pin connected to the active line on the MCU
-
-Example:
-
-	hwmon {
-		compatible = "zyxel,nsa320-mcu";
-		pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
-		pinctrl-names = "default";
-
-		data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
-		clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
-		act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
-	};
Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 96 lines · Manish Baing

Convert the ZyXEL NSA320 MCU bindings from text format to YAML schema.

---
  .../devicetree/bindings/hwmon/nsa320-mcu.txt  | 20 -------
  .../bindings/hwmon/zyxel,nsa320-mcu.yaml      | 54 +++++++++++++++++++
  2 files changed, 54 insertions(+), 20 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt create mode 100644 Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml

Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt deleted +0 -20
deleted file mode 100644
index 0863e067c85b..000000000000
@@ -1,20 +0,0 @@
-Bindings for the fan / temperature monitor microcontroller used on
-the Zyxel NSA 320 and several subsequent models.
-
-Required properties:
-- compatible	: "zyxel,nsa320-mcu"
-- data-gpios	: The GPIO pin connected to the data line on the MCU
-- clk-gpios	: The GPIO pin connected to the clock line on the MCU
-- act-gpios	: The GPIO pin connected to the active line on the MCU
-
-Example:
-
-	hwmon {
-		compatible = "zyxel,nsa320-mcu";
-		pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
-		pinctrl-names = "default";
-
-		data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
-		clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
-		act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
-	};
Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml new file +54 -0
new file mode 100644
index 000000000000..a111f8125e09
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/zyxel,nsa320-mcu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ZyXEL NSA320 MCU
+
+maintainers:
+  - Adam Baker <[email protected]>
+  - Guenter Roeck <[email protected]>
+
+description:
+  The ZyXEL NSA320 uses a dedicated microcontroller to manage system-critical
+  functions like fan speed and power monitoring. It is connected to the SoC
+  via a GPIO-based serial protocol.
+
+properties:
+  compatible:
+    const: zyxel,nsa320-mcu
+
+  data-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the data line on the MCU.
+
+  clk-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the clock line on the MCU.
+
+  act-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the active line on the MCU.
+
+required:
+  - compatible
+  - data-gpios
+  - clk-gpios
+  - act-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    hwmon {
+        compatible = "zyxel,nsa320-mcu";
+        pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
+        pinctrl-names = "default";
+
+        data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+        clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+        act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
+    };
Reviewed-by on v1 1/1
#3 lore raw
In reply to Manish Baing
Quoted 9 lines · Manish Baing

Convert the ZyXEL NSA320 MCU bindings from text format to YAML schema.

---
 .../devicetree/bindings/hwmon/nsa320-mcu.txt  | 20 -------
 .../bindings/hwmon/zyxel,nsa320-mcu.yaml      | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml

Best regards,
Krzysztof

maintainer Applied
#4 lore raw
In reply to Manish Baing
Quoted 5 lines · Manish Baing

Convert the ZyXEL NSA320 MCU bindings from text format to YAML schema.

Applied, after fixing Acked-By: -> Acked-by: as above.

Thanks,
Guenter

Quoted 93 lines
---
 .../devicetree/bindings/hwmon/nsa320-mcu.txt  | 20 -------
 .../bindings/hwmon/zyxel,nsa320-mcu.yaml      | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml
Documentation/devicetree/bindings/hwmon/nsa320-mcu.txt deleted +0 -20
deleted file mode 100644
index 0863e067c85b..000000000000
@@ -1,20 +0,0 @@
-Bindings for the fan / temperature monitor microcontroller used on
-the Zyxel NSA 320 and several subsequent models.
-
-Required properties:
-- compatible	: "zyxel,nsa320-mcu"
-- data-gpios	: The GPIO pin connected to the data line on the MCU
-- clk-gpios	: The GPIO pin connected to the clock line on the MCU
-- act-gpios	: The GPIO pin connected to the active line on the MCU
-
-Example:
-
-	hwmon {
-		compatible = "zyxel,nsa320-mcu";
-		pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
-		pinctrl-names = "default";
-
-		data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
-		clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
-		act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
-	};
Documentation/devicetree/bindings/hwmon/zyxel,nsa320-mcu.yaml new file +54 -0
new file mode 100644
index 000000000000..a111f8125e09
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/zyxel,nsa320-mcu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ZyXEL NSA320 MCU
+
+maintainers:
+  - Adam Baker <[email protected]>
+  - Guenter Roeck <[email protected]>
+
+description:
+  The ZyXEL NSA320 uses a dedicated microcontroller to manage system-critical
+  functions like fan speed and power monitoring. It is connected to the SoC
+  via a GPIO-based serial protocol.
+
+properties:
+  compatible:
+    const: zyxel,nsa320-mcu
+
+  data-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the data line on the MCU.
+
+  clk-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the clock line on the MCU.
+
+  act-gpios:
+    maxItems: 1
+    description: GPIO pin connected to the active line on the MCU.
+
+required:
+  - compatible
+  - data-gpios
+  - clk-gpios
+  - act-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    hwmon {
+        compatible = "zyxel,nsa320-mcu";
+        pinctrl-0 = <&pmx_mcu_data &pmx_mcu_clk &pmx_mcu_act>;
+        pinctrl-names = "default";
+
+        data-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+        clk-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+        act-gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
+    };