Subject: xfs: fix use of uninitialized imap in xfs_fs_map_blocks error path
Subsystems (3)
Dai Ngo
reviewerPATCH 1/1 Subject: xfs: fix use of uninitialized imap in xfs_fs_map_blocks error path
xfs_fs_map_blocks() acquires the data map lock and then calls xfs_bmapi_read(). If xfs_bmapi_read() fails, the function currently still falls through to xfs_bmbt_to_iomap(), which consumes an uninitialized imap record and may return invalid data to the caller.
Fix this by releasing the data map lock and returning immediately when xfs_bmapi_read() reports an error. This prevents xfs_bmbt_to_iomap() from being called with an uninitialized xfs_bmbt_irec.
Fixes 527851124d10f ("xfs: implement pNFS export operations")
Signed-off-by Dai Ngo <[email protected]>
--- fs/xfs/xfs_pnfs.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/xfs/xfs_pnfs.c +4 -0
@@ -174,6 +174,10 @@ xfs_fs_map_blocks( lock_flags =xfs_ilock_data_map_shared (ip); error =xfs_bmapi_read (ip, offset_fsb, end_fsb - offset_fsb, &imap, &nimaps, bmapi_flags); +if (error) { +xfs_iunlock (ip, lock_flags); + goto out_unlock; + } seq =xfs_iomap_inode_sequence (ip,0 );ASSERT (!nimaps || imap.br_startblock !=DELAYSTARTBLOCK );
Signature · 1 line
2.47.3