glibc: Fix recipe bug that disabled stack protector
PATCH 1/1 glibc: Fix recipe bug that disabled stack protector
Fixes [YOCTO #16265]
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but some CACHED_CONFIGVARS values are actually breaking this, causing glibc to be built with no stack protector at all.
Remove these CACHED_CONFIGVARS values so that stack protector support is detected properly in do_configure and then enabled properly during do_compile.
Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265
---
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but some CACHED_CONFIGVARS values are actually breaking this, causing glibc to be built with no stack protector at all.
Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265
--- meta/recipes-core/glibc/glibc.inc | 3 --- 1 file changed, 3 deletions(-)
meta/recipes-core/glibc/glibc.inc +0 -3
@@ -21,9 +21,6 @@ CACHED_CONFIGUREVARS += " \ libc_cv_slibdir=${base_libdir} \ libc_cv_rootsbindir=${base_sbindir} \ libc_cv_localedir=${localedir} \ - libc_cv_ssp_strong=no \ - libc_cv_ssp_all=no \ - libc_cv_ssp=no \ libc_cv_include_x86_isa_level=no \ "
---
base-commit: 9ca41405e6bca276468a3b6f67eaa328b8016485
change-id: 20260504-glibc-fix-stackprot-47134ada0b7f
Best regards,
Signature · 1 line
Ivan Nestlerode <[email protected]>
The patch is fine, but there was interest on the patch review in finding out where and why these lines were introduced. The earliest commit is this one:
https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=bddc141e7cec18744902787ab53c21bf28e71f78
Alex
Quoted 63 lines · Ivan Nestlerode via lists.openembedded.org
From: Ivan Nestlerode <[email protected]>
Fixes [YOCTO #16265]
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but some
CACHED_CONFIGVARSvalues are actually breaking this, causing glibc to be built with no stack protector at all.Remove these
CACHED_CONFIGVARSvalues so that stack protector support is detected properly indo_configureand then enabled properly duringdo_compile.Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265Signed-off-by Ivan Nestlerode <[email protected]>---
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but someCACHED_CONFIGVARSvalues are actually breaking this, causing glibc to be built with no stack protector at all.Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265--- meta/recipes-core/glibc/glibc.inc | 3 --- 1 file changed, 3 deletions(-)meta/recipes-core/glibc/glibc.inc +0
-4@@ -21,9 +21,6 @@ CACHED_CONFIGUREVARS += " \ libc_cv_slibdir=${base_libdir} \ libc_cv_rootsbindir=${base_sbindir} \ libc_cv_localedir=${localedir} \ - libc_cv_ssp_strong=no \ - libc_cv_ssp_all=no \ - libc_cv_ssp=no \ libc_cv_include_x86_isa_level=no \ " ---base-commit:
9ca41405e6bca276468a3b6f67eaa328b8016485
change-id: 20260504-glibc-fix-stackprot-47134ada0b7fBest regards,
--
Ivan Nestlerode <[email protected]>-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#236458): https://lists.openembedded.org/g/openembedded-core/message/236458
Mute This Topic: https://lists.openembedded.org/mt/119151502/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
In olden days we had to solve bootstrap issues and there were chicken egg issues between glibc and gcc which we do not have today. I think this patch is fine. Please apply
Quoted 81 lines · Alexander Kanavin via lists.openembedded.org
The patch is fine, but there was interest on the patch review in finding out where and why these lines were introduced. The earliest commit is this one:
Alex
Quoted 24 lines · Ivan Nestlerode via lists.openembedded.org
From: Ivan Nestlerode <[email protected]>
Fixes [YOCTO #16265]
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but some
CACHED_CONFIGVARSvalues are actually breaking this, causing glibc to be built with no stack protector at all.Remove these
CACHED_CONFIGVARSvalues so that stack protector support is detected properly indo_configureand then enabled properly duringdo_compile.Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265Signed-off-by Ivan Nestlerode <[email protected]>---
The glibc recipe is supposed to be building with --enable-stack-protector=strong, but someCACHED_CONFIGVARSvalues are actually breaking this, causing glibc to be built with no stack protector at all.Review
Quoted 7 lines
Full details are here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=16265--- meta/recipes-core/glibc/glibc.inc | 3 --- 1 file changed, 3 deletions(-)(quoted diff) +0
-0b/meta/recipes-core/glibc/glibc.inc
Quoted 18 lines
index
30d93bca77..dae087d53f100644meta/recipes-core/glibc/glibc.inc +0
-4@@ -21,9 +21,6 @@ CACHED_CONFIGUREVARS += " \ libc_cv_slibdir=${base_libdir} \ libc_cv_rootsbindir=${base_sbindir} \ libc_cv_localedir=${localedir} \ - libc_cv_ssp_strong=no \ - libc_cv_ssp_all=no \ - libc_cv_ssp=no \ libc_cv_include_x86_isa_level=no \ " ---base-commit:
9ca41405e6bca276468a3b6f67eaa328b8016485
change-id: 20260504-glibc-fix-stackprot-47134ada0b7fQuoted 8 lines
Best regards,
--
Ivan Nestlerode <[email protected]>-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#236571):
https://lists.openembedded.org/g/openembedded-core/message/236571
Mute This Topic: https://lists.openembedded.org/mt/119151502/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-