scsi: storvsc: Replace symbolic permissions with octal
Subsystems (2)
PATCH 1/1 scsi: storvsc: Replace symbolic permissions with octal
Symbolic permissions like S_IRUGO and S_IWUSR are deprecated. Replace with their octal equivalents as preferred by checkpatch:
- S_IRUGO|S_IWUSR -> 0644
- S_IRUGO -> 0444 (3 instances)
--- drivers/scsi/storvsc_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/storvsc_drv.c +4 -4
@@ -156,7 +156,7 @@ static bool hv_dev_is_fc(struct hv_device *hv_dev);#define STORVSC_LOGGING_WARN 2static int logging_level =STORVSC_LOGGING_ERROR ; -module_param (logging_level, int,S_IRUGO |S_IWUSR ); +module_param (logging_level, int,0644 );MODULE_PARM_DESC (logging_level,"Logging level, 0 - None, 1 - Error (default), 2 - Warning." );
@@ -345,17 +345,17 @@ static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)static int storvsc_vcpus_per_sub_channel =4 ;static unsigned int storvsc_max_hw_queues; -module_param (storvsc_ringbuffer_size, int,S_IRUGO ); +module_param (storvsc_ringbuffer_size, int,0444 );MODULE_PARM_DESC (storvsc_ringbuffer_size,"Ring buffer size (bytes)" );module_param (storvsc_max_hw_queues, uint,0644 );MODULE_PARM_DESC (storvsc_max_hw_queues,"Maximum number of hardware queues" ); -module_param (storvsc_vcpus_per_sub_channel, int,S_IRUGO ); +module_param (storvsc_vcpus_per_sub_channel, int,0444 );MODULE_PARM_DESC (storvsc_vcpus_per_sub_channel,"Ratio of VCPUs to subchannels" );static int ring_avail_percent_lowater =10 ; -module_param (ring_avail_percent_lowater, int,S_IRUGO ); +module_param (ring_avail_percent_lowater, int,0444 );MODULE_PARM_DESC (ring_avail_percent_lowater,"Select a channel if available ring size > this in percent" );
Signature · 1 line
2.51.1
This patch is missing "Signed-off-by:".
"deprecated" is inaccurate - Symbolic permissions are not deprecated; they still compile fine. The message should say something like "not preferred".
Thanks,
Long
Quoted 47 lines
Symbolic permissions like
S_IRUGOandS_IWUSRare deprecated. Replace with their octal equivalents as preferred by checkpatch:
- S_IRUGO|S_IWUSR -> 0644
-S_IRUGO-> 0444 (3 instances)--- drivers/scsi/storvsc_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/scsi/storvsc_drv.c index renamed from drivers/scsi/storvsc_drv.c +0
-0
6977ca8a0..571ea5491100644drivers/scsi/storvsc_drv.c +1
-0@@ -156,7 +156,7 @@ static bool hv_dev_is_fc(struct hv_device *hv_dev);#define STORVSC_LOGGING_WARN 2static int logging_level =STORVSC_LOGGING_ERROR ; -module_param (logging_level, int,S_IRUGO |S_IWUSR ); +module_param (logging_level, int,0644 );MODULE_PARM_DESC (logging_level,"Logging level, 0 - None, 1 - Error (default), 2 - Warning." );@@ -345,17 +345,17 @@ static int storvsc_change_queue_depth(struct
scsi_device*sdev, intqueue_depth) static intstorvsc_vcpus_per_sub_channel= 4; static unsigned intstorvsc_max_hw_queues;drivers/scsi/storvsc_drv.c +1
-1-module_param (storvsc_ringbuffer_size, int,S_IRUGO ); +module_param (storvsc_ringbuffer_size, int,0444 );MODULE_PARM_DESC (storvsc_ringbuffer_size,"Ring buffer size (bytes)" );module_param (storvsc_max_hw_queues, uint,0644 );
MODULE_PARM_DESC(storvsc_max_hw_queues, "Maximum number of hardware queues");drivers/scsi/storvsc_drv.c +1
-1-module_param (storvsc_vcpus_per_sub_channel, int,S_IRUGO ); +module_param (storvsc_vcpus_per_sub_channel, int,0444 ); MODULE_PARM_DESC(storvsc_vcpus_per_sub_channel, "Ratio of VCPUs tosubchannels");
static int
ring_avail_percent_lowater= 10; -module_param(ring_avail_percent_lowater, int, S_IRUGO); +module_param(ring_avail_percent_lowater, int, 0444);
MODULE_PARM_DESC(ring_avail_percent_lowater,"Select a channel if available ring size > this in percent");--
2.51.1
From: Md Shofiqul Islam <[email protected]> Sent: Tuesday, May 5, 2026 3:53 PM
Quoted 1 line
Since storvsc is the driver for the synthetic SCSI controller provided by Hyper-V to its guest VMs, I'd suggest including the [email protected] mailing list on To: line. That's the mailing list for all things related to Hyper-V guests.
Michael
Quoted 48 lines
Symbolic permissions like
S_IRUGOandS_IWUSRare deprecated. Replace with their octal equivalents as preferred by checkpatch:
- S_IRUGO|S_IWUSR -> 0644
-S_IRUGO-> 0444 (3 instances)--- drivers/scsi/storvsc_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/scsi/storvsc_drv.c +4
-4@@ -156,7 +156,7 @@ static bool hv_dev_is_fc(struct hv_device *hv_dev);#define STORVSC_LOGGING_WARN 2static int logging_level =STORVSC_LOGGING_ERROR ; -module_param (logging_level, int,S_IRUGO |S_IWUSR ); +module_param (logging_level, int,0644 );MODULE_PARM_DESC (logging_level,"Logging level, 0 - None, 1 - Error (default), 2 - Warning." );@@ -345,17 +345,17 @@ static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)static int storvsc_vcpus_per_sub_channel =4 ;static unsigned int storvsc_max_hw_queues; -module_param (storvsc_ringbuffer_size, int,S_IRUGO ); +module_param (storvsc_ringbuffer_size, int,0444 );MODULE_PARM_DESC (storvsc_ringbuffer_size,"Ring buffer size (bytes)" );module_param (storvsc_max_hw_queues, uint,0644 );MODULE_PARM_DESC (storvsc_max_hw_queues,"Maximum number of hardware queues"); -module_param (storvsc_vcpus_per_sub_channel, int,S_IRUGO ); +module_param (storvsc_vcpus_per_sub_channel, int,0444 );MODULE_PARM_DESC (storvsc_vcpus_per_sub_channel,"Ratio of VCPUs to subchannels");static int ring_avail_percent_lowater =10 ; -module_param (ring_avail_percent_lowater, int,S_IRUGO ); +module_param (ring_avail_percent_lowater, int,0444 );MODULE_PARM_DESC(ring_avail_percent_lowater,
"Select a channel if available ring size > this in percent");--
2.51.1