Skip to contentSkip to conversation

fetch2/crate: guard against empty version list

PATCH New [email protected] 1 participant 1 message May 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fetch2/crate: guard against empty version list

From: Thomas Perrot <[email protected]>

Both latest_versionstring() and latest_versionstring_from_index() would raise IndexError on versions[-1] if the fetched index returns no usable versions.
Return ("", "") in that case, consistent with what callers expect when no upstream version can be determined.

---
 lib/bb/fetch2/crate.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/bb/fetch2/crate.py +2 -2
index d84bae0bcd1e..eb1fd5719e8c 100644
@@ -164,7 +164,7 @@ class Crate(Wget):
         versions = [(0, i["num"], "") for i in json_data["versions"]]
         versions = sorted(versions, key=cmp_to_key(bb.utils.vercmp))
 
-        return (versions[-1][1], "")
+        return (versions[-1][1], "") if versions else ("", "")
 
     def latest_versionstring_from_index(self, ud, d):
         """
@@ -182,4 +182,4 @@ class Crate(Wget):
                 versions.append((0, data["vers"], ""))
 
         versions = sorted(versions, key=cmp_to_key(bb.utils.vercmp))
-        return (versions[-1][1], "")
+        return (versions[-1][1], "") if versions else ("", "")
Signature · 1 line
2.54.0