Skip to contentSkip to conversation

sparc: Export mcount for Clang-built modules

PATCH Superseded Rosen Penev 2 participants 2 messages May 8 – Jun 12 SPARC + UltraSPARC (sparc/sparc64)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc: Export mcount for Clang-built modules

Clang emits calls to mcount for -pg on sparc64, while the existing ftrace support only exports the _mcount name. With FUNCTION_TRACER enabled, modules can therefore keep relocations against mcount and fail during modpost:

ERROR: modpost: "mcount" [arch/sparc/kernel/chmc.ko] undefined!

_mcount and mcount are aliases in arch/sparc/lib/mcount.S. Export the plain mcount alias as well so Clang-built modules can resolve their profiling call target.

Assisted-by Codex:GPT-5
---
 arch/sparc/lib/mcount.S | 1 +
 1 file changed, 1 insertion(+)
arch/sparc/lib/mcount.S +1 -0
index f7f7910eb41e..0309ba2c4712 100644
@@ -21,6 +21,7 @@
 	EXPORT_SYMBOL(_mcount)
 	.globl		mcount
 	.type		mcount,#function
+	EXPORT_SYMBOL(mcount)
 _mcount:
 mcount:
 #ifdef CONFIG_FUNCTION_TRACER
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 22 lines · Rosen Penev

Clang emits calls to mcount for -pg on sparc64, while the existing ftrace support only exports the _mcount name. With FUNCTION_TRACER enabled, modules can therefore keep relocations against mcount and fail during modpost:

ERROR: modpost: "mcount" [arch/sparc/kernel/chmc.ko] undefined!

_mcount and mcount are aliases in arch/sparc/lib/mcount.S. Export the plain mcount alias as well so Clang-built modules can resolve their profiling call target.

Assisted-by Codex:GPT-5
---
 arch/sparc/lib/mcount.S | 1 +
 1 file changed, 1 insertion(+)
arch/sparc/lib/mcount.S +0 -0
index f7f7910eb41e..0309ba2c4712 100644

arch/sparc/lib/mcount.S line 27

Quoted 7 lines
arch/sparc/lib/mcount.S +1 -0
@@ -21,6 +21,7 @@
 	EXPORT_SYMBOL(_mcount)
 	.globl		mcount
 	.type		mcount,#function
+	EXPORT_SYMBOL(mcount)
 _mcount:
 mcount:
 #ifdef CONFIG_FUNCTION_TRACER

Hi,

Please also add it to arch/sparc/include/asm/asm-prototypes.h, like in
https://lore.kernel.org/sparclinux/[email protected]
to not get an added warning about mcount in modpost.

Thanks,
Andreas