Skip to contentSkip to conversation

mips: n64: add __iomem for writel call

PATCH Applied Rosen Penev 2 participants 2 messages May 9 – May 26 MIPS

lore
Share & tools
lore

Rosen Penev

author
#0 lore raw

PATCH 1/1 mips: n64: add __iomem for writel call

sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@
got unsigned int [usertype] *

Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Fixes baec970aa5ba ("mips: Add N64 machine type")
Signed-off-by Rosen Penev <[email protected]>
---
 arch/mips/n64/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/n64/init.c +1 -1
index dfbd864f4667..66ec28ab41f3 100644
@@ -50,7 +50,7 @@ void __init prom_init(void)
 
 #define W 320
 #define H 240
-#define REG_BASE ((u32 *) CKSEG1ADDR(0x4400000))
+#define REG_BASE ((u32 __iomem *) CKSEG1ADDR(0x4400000))
 
 static void __init n64rdp_write_reg(const u8 reg, const u32 value)
 {
Signature · 1 line
2.54.0
maintainer Applied
#1 lore raw
Quoted 11 lines · Rosen Penev

sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@
got unsigned int [usertype] *

Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Fixes baec970aa5ba ("mips: Add N64 machine type")
Signed-off-by Rosen Penev <[email protected]>
---
 arch/mips/n64/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]