staging: rtl8723bs: replace msleep with usleep_range for short delays
PATCH 1/1 staging: rtl8723bs: replace msleep with usleep_range for short delays
The checkpatch.pl tool warns that msleep() for values less than 20ms can be inaccurate. This patch converts the 10ms msleep to usleep_range(10000, 11000) to provide more precise timing using high-resolution timers.
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +2 -1
@@ -5834,7 +5834,8 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) { -msleep (10 );/* 10ms, ATIM(HIQ) Windows */ +/* 10ms - 11ms, ATIM(HIQ) Windows */ +usleep_range (10000 ,11000 );/* spin_lock_bh(&psta_bmc->sleep_q.lock); */ spin_lock_bh (&pxmitpriv->lock);
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 28 lines · Sridhar Arra
The checkpatch.pl tool warns that
msleep()for values less than 20ms can be inaccurate. This patch converts the 10ms msleep tousleep_range(10000, 11000)to provide more precise timing using high-resolution timers.Signed-off-by Sridhar Arra <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +2
-1@@ -5834,7 +5834,8 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) { -msleep (10 );/* 10ms, ATIM(HIQ) Windows */ +/* 10ms - 11ms, ATIM(HIQ) Windows */ +usleep_range (10000 ,11000 );/* spin_lock_bh(&psta_bmc->sleep_q.lock); */ spin_lock_bh (&pxmitpriv->lock);Signature · 1 line
2.34.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot