staging: rtl8723bs: replace msleep with usleep_range for 1ms delay
PATCH 1/1 staging: rtl8723bs: replace msleep with usleep_range for 1ms delay
The checkpatch.pl tool warns that msleep() for values less than 20ms can be inaccurate and oversleep. This patch converts the 1ms msleep to usleep_range(1000, 2000) to ensure more precise timing in the power control path.
--- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2 -2
@@ -414,7 +414,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) err =-1 ;break ; } -msleep (1 ); +usleep_range (1000 ,2000 ); }return err;
@@ -567,7 +567,7 @@ void LPS_Leave_check(struct adapter *padapter)if (jiffies_to_msecs (jiffies - start_time) >100 )break ; -msleep (1 ); +usleep_range (1000 ,2000 ); } }
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 35 lines · Sridhar Arra
The checkpatch.pl tool warns that
msleep()for values less than 20ms can be inaccurate and oversleep. This patch converts the 1ms msleep tousleep_range(1000, 2000)to ensure more precise timing in the power control path.Signed-off-by Sridhar Arra <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +2
-2@@ -414,7 +414,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) err =-1 ;break ; } -msleep (1 ); +usleep_range (1000 ,2000 ); }return err;@@ -567,7 +567,7 @@ void LPS_Leave_check(struct adapter *padapter)if (jiffies_to_msecs (jiffies - start_time) >100 )break ; -msleep (1 ); +usleep_range (1000 ,2000 ); } }Signature · 1 line
2.34.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot