usb: onboard-hub: Add support for Corechips SL6341 USB 2.0/3.0 hub controller
PATCH v2 1/1 usb: onboard-hub: Add support for Corechips SL6341 USB 2.0/3.0 hub controller
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always requires external 1V1 power and can optionally use external 3V3 power (or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as commit bfcb86e58f3a ("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0 hub controller") [1]
---
Changes in v2:
- Fixed the comment to correctly indicate the USB 3.0 entry
- Added an upstream commit reference for the DT binding
- V for volts in captials (commit message, thanks Marek)
- Reordered the compatibles by lexical order, not hex order (thanks Marek)
- Link to v1: https://lore.kernel.org/r/[email protected]
--- common/usb_onboard_hub.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
common/usb_onboard_hub.c +13 -1
@@ -262,6 +262,12 @@ static int usb_onboard_hub_remove(struct udevice *dev)return ret; } +static const struct onboard_hub_data corechips_sl6341_data = { + .reset_us =10000 , + .num_supplies =2 , + .supply_names = {"vdd1v1-supply" ,"vdd3v3-supply" }, +}; +static const struct onboard_hub_data usb2514_data = { .power_on_delay_us =500 , .reset_us =1 ,
@@ -285,7 +291,13 @@ static const struct onboard_hub_data usbhx3_data = {static const struct udevice_id usb_onboard_hub_ids[] = {/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */ - { .compatible ="usb424,2514" ,/* USB2514B USB 2.0 */ + { .compatible ="usb3431,6241" ,/* Corechips SL6341 USB 2.0 */ + .data = (ulong)&corechips_sl6341_data, + }, { + .compatible ="usb3431,6341" ,/* Corechips SL6341 USB 3.0 */ + .data = (ulong)&corechips_sl6341_data, + }, { + .compatible ="usb424,2514" ,/* USB2514B USB 2.0 */ .data = (ulong)&usb2514_data, }, { .compatible ="usb424,2744" ,/* USB2744 USB 2.0 */
---
base-commit: 5732bd0f457b4c671e46574d64d4acb099c0f0a5
change-id: 20260512-sl6341-d7898a895c4e
Best regards,
Signature · 1 line
Alexey Charkov <[email protected]>
Quoted 11 lines · Alexey Charkov
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always requires external 1V1 power and can optionally use external 3V3 power (or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as commit
bfcb86e58f3a("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0 hub controller") [1]
Thanks !
Hi Alexey, Tom,
Quoted 40 lines · Alexey Charkov
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always requires external 1V1 power and can optionally use external 3V3 power (or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as commit
bfcb86e58f3a("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0 hub controller") [1]Signed-off-by Alexey Charkov <[email protected]>---
Changes in v2:
- Fixed the comment to correctly indicate the USB 3.0 entry
- Added an upstream commit reference for the DT binding
- V for volts in captials (commit message, thanks Marek)
- Reordered the compatibles by lexical order, not hex order (thanks Marek)
- Link to v1: https://lore.kernel.org/r/[email protected]--- common/usb_onboard_hub.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)common/usb_onboard_hub.c +6
-0@@ -262,6 +262,12 @@ static int usb_onboard_hub_remove(struct udevice *dev)return ret; } +static const struct onboard_hub_data corechips_sl6341_data = { + .reset_us =10000 , + .num_supplies =2 , + .supply_names = {"vdd1v1-supply" ,"vdd3v3-supply" }, +}; +static const struct onboard_hub_data usb2514_data = { .power_on_delay_us =500 , .reset_us =1 ,
common/usb_onboard_hub.c static const struct onboard_hub_data usbhx3_data = { · line 294
Quoted 5 lines
common/usb_onboard_hub.c +1
-1@@ -285,7 +291,13 @@ static const struct onboard_hub_data usbhx3_data = {static const struct udevice_id usb_onboard_hub_ids[] = {/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */ - { .compatible ="usb424,2514" ,/* USB2514B USB 2.0 */ + { .compatible ="usb3431,6241" ,/* Corechips SL6341 USB 2.0 */
Would be nice to have an additional newline after the opening curly bracket to avoid this unnecessary chunk in the diff next time we add support for yet another USB hub. It's also a bit surprising to add it first in the list instead of last, but eh, nothing too important.
@Tom, can you take this for next please?
Cheers,
Quentin
Quoted 52 lines · Quentin Schulz
Hi Alexey, Tom,
Quoted 42 lines · Alexey Charkov
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always requires external 1V1 power and can optionally use external 3V3 power (or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as commit
bfcb86e58f3a("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0 hub controller") [1]Link https://github.com/torvalds/linux/commit/ bfcb86e58f3a58d05b95970d81b94cb011982780 [1]Signed-off-by Alexey Charkov <[email protected]>---
Changes in v2:
- Fixed the comment to correctly indicate the USB 3.0 entry
- Added an upstream commit reference for the DT binding
- V for volts in captials (commit message, thanks Marek)
- Reordered the compatibles by lexical order, not hex order (thanks Marek)
- Link to v1: https://lore.kernel.org/r/20260512-sl6341-
[email protected]
---
common/usb_onboard_hub.c| 14 +++++++++++++-1 file changed, 13 insertions(+), 1 deletion(-)common/usb_onboard_hub.c +6
-0@@ -262,6 +262,12 @@ static int usb_onboard_hub_remove(struct udevice *dev) return ret; } +static const struct onboard_hub_data corechips_sl6341_data = { + .reset_us = 10000, + .num_supplies = 2, + .supply_names = { "vdd1v1-supply", "vdd3v3-supply" }, +}; + static const struct onboard_hub_data usb2514_data = { .power_on_delay_us = 500, .reset_us = 1,common/usb_onboard_hub.c static const struct onboard_hub_data usbhx3_data = { · line 293
Quoted 4 lines
common/usb_onboard_hub.c +1
-1@@ -285,7 +291,13 @@ static const struct onboard_hub_data usbhx3_data = { static const struct udevice_id usb_onboard_hub_ids[] = { /* Use generic usbVID,PID dt-bindings (usb-device.yaml) */ - { .compatible = "usb424,2514", /* USB2514B USB 2.0 */ + { .compatible = "usb3431,6241", /* Corechips SL6341 USB 2.0 */Would be nice to have an additional newline after the opening curly bracket to avoid this unnecessary chunk in the diff next time we add support for yet another USB hub. It's also a bit surprising to add it first in the list instead of last, but eh, nothing too important.
Quoted 3 lines
Reviewed-by Quentin Schulz <[email protected]>@Tom, can you take this for next please?
Why would Tom collect USB patches ?
Hi Marek,
Quoted 55 lines · Marek Vasut
Quoted 54 lines · Quentin Schulz
Hi Alexey, Tom,
Quoted 47 lines · Alexey Charkov
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always requires external 1V1 power and can optionally use external 3V3 power (or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as commit
bfcb86e58f3a("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0 hub controller") [1]Link https://eur02.safelinks.protection.outlook.com/? url=https%3A%2F%2Fgithub.com%2Ftorvalds%2Flinux%2Fcommit%2F&data=05%7C02%7Cquentin.schulz%40cherry.de%7Ca44d3da6a7cf48b547ca08ded1fcee13%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639179081433018185%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=FecJhM5NGeAK%2Bo6iln1t3m52BN1DPNVV6tuQA4K4KWc%3D&reserved=0 bfcb86e58f3a58d05b95970d81b94cb011982780 [1]Signed-off-by Alexey Charkov <[email protected]>---
Changes in v2:
- Fixed the comment to correctly indicate the USB 3.0 entry
- Added an upstream commit reference for the DT binding
- V for volts in captials (commit message, thanks Marek)
- Reordered the compatibles by lexical order, not hex order (thanks
Marek)
- Link to v1: https://eur02.safelinks.protection.outlook.com/?
url=https%3A%2F%2Flore.kernel.org%2Fr%2F20260512-sl6341- &data=05%7C02%7Cquentin.schulz%40cherry.de%7Ca44d3da6a7cf48b547ca08ded1fcee13%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639179081433057206%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Te0MkaUEYkT9gxZvlDl8HlVJKQMpKAS2PHjMjtNK5Q8%3D&reserved=0 [email protected]
---
common/usb_onboard_hub.c| 14 +++++++++++++-1 file changed, 13 insertions(+), 1 deletion(-)common/usb_onboard_hub.c +7
-1@@ -262,6 +262,12 @@ static int usb_onboard_hub_remove(struct udevice *dev) return ret; } +static const struct onboard_hub_data corechips_sl6341_data = { + .reset_us = 10000, + .num_supplies = 2, + .supply_names = { "vdd1v1-supply", "vdd3v3-supply" }, +}; + static const struct onboard_hub_data usb2514_data = { .power_on_delay_us = 500, .reset_us = 1,@@ -285,7 +291,13 @@ static const struct onboard_hub_data usbhx3_data = { static const struct udevice_id usb_onboard_hub_ids[] = { /* Use generic usbVID,PID dt-bindings (usb-device.yaml) */ - { .compatible = "usb424,2514", /* USB2514B USB 2.0 */ + { .compatible = "usb3431,6241", /* Corechips SL6341 USBQuoted 1 line
2.0 */
Would be nice to have an additional newline after the opening curly bracket to avoid this unnecessary chunk in the diff next time we add support for yet another USB hub. It's also a bit surprising to add it first in the list instead of last, but eh, nothing too important.
Quoted 4 lines
Quoted 3 lines
Reviewed-by Quentin Schulz <[email protected]>@Tom, can you take this for next please?
Why would Tom collect USB patches ?
$ ./scripts/get_maintainer.pl -f common/usb_onboard_hub.c Tom Rini <[email protected]> (maintainer:THE REST)
and this patch has been sitting reviewed for 6 weeks and the status in patchwork is still "new" so I thought it somehow got lost. I did miss that you were the delegate (or did this change recently?). My intention was not to bypass you, my apologies if it was taken this way.
Would you mind if I send a patch to MAINTAINERS to add common/usb_onboard_hub.c to the USB entry so that it's clear you're the maintainer?
Cheers,
Quentin
On 6/24/26 5:22 PM, Quentin Schulz wrote:
Hello Quentin,
Quoted 2 lines
$ ./scripts/get_maintainer.pl -f common/usb_onboard_hub.c Tom Rini <[email protected]> (maintainer:THE REST)
Sigh ...
Quoted 1 line
and this patch has been sitting reviewed for 6 weeks and the status in patchwork is still "new" so I thought it somehow got lost. I did miss that you were the delegate (or did this change recently?). My intention was not to bypass you, my apologies if it was taken this way.
No worries.
Quoted 1 line
Would you mind if I send a patch to
MAINTAINERSto add common/usb_onboard_hub.cto the USB entry so that it's clear you're the maintainer?
I'll send one, and an update to email addresses in general, thank you for the reminder.