crypto: atmel - use min3 to simplify atmel_sha_append_sg
Subsystems (2)
PATCH 1/1 crypto: atmel - use min3 to simplify atmel_sha_append_sg
Replace two consecutive min() calls with min3() to simplify the code.
And since count is unsigned and cannot be less than zero, adjust the if check and update the comment accordingly.
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/crypto/atmel-sha.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/crypto/atmel-sha.c +4 -4
@@ -305,12 +305,12 @@ static size_t atmel_sha_append_sg(struct atmel_sha_reqctx *ctx)size_t count;while ((ctx->bufcnt < ctx->buflen) && ctx->total) { - count =min (ctx->sg->length - ctx->offset, ctx->total); - count =min (count, ctx->buflen - ctx->bufcnt); + count =min3 (ctx->sg->length - ctx->offset, ctx->total, + ctx->buflen - ctx->bufcnt); -if (count <=0 ) { +if (count ==0 ) {/* -* Check if count <= 0 because the buffer is full or +* Check if count == 0 because the buffer is full or * because the sg length is 0. In the latest case, * check if there is another sg in the list, a 0 length * sg doesn't necessarily mean the end of the sg list.
Herbert Xu
maintainerQuoted 9 lines · Thorsten Blum
Replace two consecutive
min()calls withmin3()to simplify the code.And since count is unsigned and cannot be less than zero, adjust the if check and update the comment accordingly.
Signed-off-by Thorsten Blum <[email protected]>--- drivers/crypto/atmel-sha.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt