ASoC: cs35l56: Log SoundWire status updates only on changes
Subsystems (3)
Richard Fitzgerald
maintainerPATCH 1/1 ASoC: cs35l56: Log SoundWire status updates only on changes
From: Simon Trimmer <[email protected]>
The SoundWire slave update_status() callback can be invoked when the status has not changed. To prevent large amounts of log noise with debug enabled, log them only when the status changes. This also helps with understanding them, because they now log an actual change in state.
--- sound/soc/codecs/cs35l56-sdw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
sound/soc/codecs/cs35l56-sdw.c +3 -2
@@ -385,18 +385,19 @@ static int cs35l56_sdw_update_status(struct sdw_slave *peripheral,switch (status) {case SDW_SLAVE_ATTACHED : -dev_dbg (cs35l56->base.dev,"%s: ATTACHED\n" , __func__); cs35l56->sdw_in_clock_stop_1 = false;if (cs35l56->sdw_attached)break ; +dev_dbg (cs35l56->base.dev,"%s: ATTACHED\n" , __func__);if (!cs35l56->base.init_done || cs35l56->soft_resetting)cs35l56_sdw_init (peripheral); cs35l56->sdw_attached = true;break ;case SDW_SLAVE_UNATTACHED : -dev_dbg (cs35l56->base.dev,"%s: UNATTACHED\n" , __func__); +if (cs35l56->sdw_attached) +dev_dbg (cs35l56->base.dev,"%s: UNATTACHED\n" , __func__); cs35l56->sdw_attached = false;break ;default :
Signature · 1 line
2.47.3
Mark Brown
maintainerQuoted 1 line · Richard Fitzgerald
ASoC: cs35l56: Log SoundWire status updates only on changes
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/1] ASoC: cs35l56: Log SoundWire status updates only on changes
https://git.kernel.org/broonie/sound/c/9c0f5bbff146
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark