FAILED: patch "[PATCH] spi: ch341: fix devres lifetime" failed to apply to 6.12-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x abe572f630bc1f0e77041012ab075869036ede4f
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026051545-hemlock-october-cd7a@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From abe572f630bc1f0e77041012ab075869036ede4f Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Fri, 27 Mar 2026 11:43:05 +0100
Subject: [PATCH] spi: ch341: fix devres lifetime
USB drivers bind to USB interfaces and any device managed resources should have their lifetime tied to the interface rather than parent USB device. This avoids issues like memory leaks when drivers are unbound without their devices being physically disconnected (e.g. on probe deferral or configuration changes).
Fix the controller and driver data lifetime so that they are released on driver unbind.
Note that this also makes sure that the SPI controller is placed correctly under the USB interface in the device tree.
drivers/spi/spi-ch341.c +3 -4
@@ -152,7 +152,7 @@ static int ch341_probe(struct usb_interface *intf,if (ret)return ret; - ctrl =devm_spi_alloc_host (&udev->dev,sizeof (struct ch341_spi_dev )); + ctrl =devm_spi_alloc_host (&intf->dev,sizeof (struct ch341_spi_dev ));if (!ctrl)return -ENOMEM ;
@@ -163,7 +163,7 @@ static int ch341_probe(struct usb_interface *intf, ch341->read_pipe =usb_rcvbulkpipe (udev,usb_endpoint_num (in)); ch341->rx_len =usb_endpoint_maxp (in); - ch341->rx_buf =devm_kzalloc (&udev->dev, ch341->rx_len,GFP_KERNEL ); + ch341->rx_buf =devm_kzalloc (&intf->dev, ch341->rx_len,GFP_KERNEL );if (!ch341->rx_buf)return -ENOMEM ;
@@ -171,8 +171,7 @@ static int ch341_probe(struct usb_interface *intf,if (!ch341->rx_urb)return -ENOMEM ; - ch341->tx_buf = -devm_kzalloc (&udev->dev,CH341_PACKET_LENGTH ,GFP_KERNEL ); + ch341->tx_buf =devm_kzalloc (&intf->dev,CH341_PACKET_LENGTH ,GFP_KERNEL );if (!ch341->tx_buf) { ret = -ENOMEM ; goto err_free_urb;