Skip to contentSkip to conversation

Documentation: hwmon: adt7411: document supported sysfs attributes

PATCH Applied Chen-Shi-Hong 4 participants 5 messages May 16

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: hwmon: adt7411: document supported sysfs attributes

The adt7411 driver exposes additional standard hwmon attributes beyond the ones currently listed in Documentation/hwmon/adt7411.rst.

Document voltage min/max/alarm attributes, temperature min/max and min_alarm/max_alarm attributes, and the temp2_fault attribute for the external temperature channel.

Also update the documentation to clarify that analog inputs in1 and in2 are not available when the external temperature sensor is enabled, and remove the outdated statement claiming that external temperature support and limit registers are unsupported.

---
 Documentation/hwmon/adt7411.rst | 37 +++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 6 deletions(-)
Documentation/hwmon/adt7411.rst +31 -6
index 57ad16fb216a..28b6f3cb6b86 100644
@@ -30,11 +30,36 @@ Check the datasheet for details.
 sysfs-Interface
 ---------------
 
-================ =================
-in0_input	 vdd voltage input
-in[1-8]_input	 analog 1-8 input
-temp1_input	 temperature input
-================ =================
+================    =================================
+in0_input           vdd voltage input
+in0_min             vdd low limit
+in0_max             vdd high limit
+in0_alarm           vdd alarm
+in[1-8]_input       analog 1-8 input
+in[1-8]_min         analog input low limit
+in[1-8]_max         analog input high limit
+in[1-8]_alarm       analog input alarm
+temp1_input         internal temperature input
+temp1_min           internal temperature low limit
+temp1_max           internal temperature high limit
+temp1_min_alarm     internal temperature low alarm
+temp1_max_alarm     internal temperature high alarm
+================    =================================
+
+If the external temperature sensor is enabled, the following attributes are
+also available:
+
+================ ================================================
+temp2_input      external temperature input
+temp2_min        external temperature low limit
+temp2_max        external temperature high limit
+temp2_min_alarm  external temperature low alarm
+temp2_max_alarm  external temperature high alarm
+temp2_fault      external temperature sensor fault
+================ ================================================
+
+If the external temperature sensor is enabled, analog inputs in1 and in2 are
+not available.
 
 Besides standard interfaces, this driver adds (0 = off, 1 = on):
 
@@ -47,4 +72,4 @@ Besides standard interfaces, this driver adds (0 = off, 1 = on):
 Notes
 -----
 
-SPI, external temperature sensor and limit registers are not supported yet.
+SPI is not supported yet.
Signature · 1 line
2.53.0
AI review Reviewed-by on v1 1/1
#1 lore raw
Reviewed-by: Sashiko <[email protected]>
Quoted 7 lines

The adt7411 driver exposes additional standard hwmon attributes beyond the ones currently listed in Documentation/hwmon/adt7411.rst.

Document voltage min/max/alarm attributes, temperature min/max and min_alarm/max_alarm attributes, and the temp2_fault attribute for the external temperature channel.

Quoted 6 lines

Also update the documentation to clarify that analog inputs in1 and in2 are not available when the external temperature sensor is enabled, and remove the outdated statement claiming that external temperature support and limit registers are unsupported.

#2 lore raw
Quoted 7 lines · On 16/05/2026 05:57, [email protected] wrote:
Quoted 7 lines

The adt7411 driver exposes additional standard hwmon attributes beyond the ones currently listed in Documentation/hwmon/adt7411.rst.

Document voltage min/max/alarm attributes, temperature min/max and min_alarm/max_alarm attributes, and the temp2_fault attribute for the external temperature channel.

Quoted 9 lines
Quoted 6 lines

Also update the documentation to clarify that analog inputs in1 and in2 are not available when the external temperature sensor is enabled, and remove the outdated statement claiming that external temperature support and limit registers are unsupported.

NAK, fake tag.

https://lore.kernel.org/linux-devicetree/[email protected]/T/#u

Best regards,
Krzysztof

#3 lore raw
In reply to [email protected]
Quoted 7 lines · On 16/05/2026 05:57, [email protected] wrote:
Quoted 7 lines

The adt7411 driver exposes additional standard hwmon attributes beyond the ones currently listed in Documentation/hwmon/adt7411.rst.

Document voltage min/max/alarm attributes, temperature min/max and min_alarm/max_alarm attributes, and the temp2_fault attribute for the external temperature channel.

Quoted 8 lines
Quoted 6 lines

Also update the documentation to clarify that analog inputs in1 and in2 are not available when the external temperature sensor is enabled, and remove the outdated statement claiming that external temperature support and limit registers are unsupported.

NAK, fake tag, fake review from tool. Stop this nonsense! You cannot make a reviewer statement of oversight.

Best regards,
Krzysztof

maintainer Applied
#4 lore raw
In reply to Chen-Shi-Hong
Quoted 7 lines · Chen-Shi-Hong

The adt7411 driver exposes additional standard hwmon attributes beyond the ones currently listed in Documentation/hwmon/adt7411.rst.

Document voltage min/max/alarm attributes, temperature min/max and min_alarm/max_alarm attributes, and the temp2_fault attribute for the external temperature channel.

Quoted 6 lines

Also update the documentation to clarify that analog inputs in1 and in2 are not available when the external temperature sensor is enabled, and remove the outdated statement claiming that external temperature support and limit registers are unsupported.

Applied.

Thanks,
Guenter