Skip to contentSkip to conversation

staging: media: atomisp: remove redundant comparison to false

PATCH In review Diego Fernando Mancera Gómez 2 participants 2 messages May 17

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: remove redundant comparison to false

Repetitive comparisons to boolean values are error-prone and visually noisy. Clean up the codebase by removing the explicit '== false' check and utilizing the logical negation operator instead.

---
 drivers/staging/media/atomisp/pci/sh_css_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/sh_css_params.c +1 -1
index fcebace11..bcd84efd3 100644
@@ -1466,7 +1466,7 @@ sh_css_set_morph_table(struct ia_css_isp_parameters *params,
 	IA_CSS_ENTER_PRIVATE("table=%p", table);
 
 	assert(params);
-	if (table->enable == false)
+	if (!table->enable)
 		table = NULL;
 	params->morph_table = table;
 	params->morph_table_changed = true;
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · Diego Fernando Mancera Gómez

Repetitive comparisons to boolean values are error-prone and visually noisy. Clean up the codebase by removing the explicit '== false' check and utilizing the logical negation operator instead.

Only a single problem like this in the entire driver?!

Signature · 2 lines
With Best Regards,
Andy Shevchenko