Skip to contentSkip to conversation

Makefile: fix extra dash in KBUILD_CFLAGS

PATCH In review Giovanni Santini 3 participants 3 messages May 18 – Jun 3 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix extra dash in KBUILD_CFLAGS

Remove an extra leading dash from the KBUILD_CFLAGS assignment under the CONFIG_CC_OPTIMIZE_FOR_DEBUG conditional block. The extra dash breaks the build when CONFIG_CC_OPTIMIZE_FOR_DEBUG is enabled.

Fixes 56ae3c2a44fc ("Makefile: repair CONFIG_CC_OPTIMIZE_FOR_DEBUG support")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 552328f9f2c..e3b6788f848 100644
@@ -920,7 +920,7 @@ endif
 ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
 KBUILD_CFLAGS	+= -Os
 else ifdef CONFIG_CC_OPTIMIZE_FOR_DEBUG
--KBUILD_CFLAGS  += -Og
+KBUILD_CFLAGS  += -Og
 # Avoid false positives -Wmaybe-uninitialized
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394
 KBUILD_CFLAGS  += -Wno-maybe-uninitialized
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Giovanni Santini

Makefile: fix extra dash in KBUILD_CFLAGS

Remove an extra leading dash from the KBUILD_CFLAGS assignment under the CONFIG_CC_OPTIMIZE_FOR_DEBUG conditional block. The extra dash breaks the build when CONFIG_CC_OPTIMIZE_FOR_DEBUG is enabled.

Quoted 6 lines
Fixes 56ae3c2a44fc ("Makefile: repair CONFIG_CC_OPTIMIZE_FOR_DEBUG support")

Makefile | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw
In reply to Giovanni Santini
Quoted 8 lines · Giovanni Santini

Remove an extra leading dash from the KBUILD_CFLAGS assignment under the CONFIG_CC_OPTIMIZE_FOR_DEBUG conditional block. The extra dash breaks the build when CONFIG_CC_OPTIMIZE_FOR_DEBUG is enabled.

Fixes 56ae3c2a44fc ("Makefile: repair CONFIG_CC_OPTIMIZE_FOR_DEBUG support")

[...]

Applied to u-boot/master, thanks!

[1/1] Makefile: fix extra dash in KBUILD_CFLAGS

      commit: 81d60060831afa50a43a6dcaf8e34932e6b8ccc2
Signature · 1 line
Tom