Skip to contentSkip to conversation

perf test: probe_vfs_getname add do_getname() probing fallback

PATCH New Thomas Richter 2 participants 2 messages May 19

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: probe_vfs_getname add do_getname() probing fallback

The following tests are skipped for some time now on platforms s390 and x86_64:

 # perf test vfs_getname
 138: Add vfs_getname probe to get syscall args filenames    : Skip
 140: Use vfs_getname probe to get syscall args filenames    : Skip
 154: Check open filename arg using perf trace + vfs_getname : Skip
 #

This is caused by a change in kernel code of function getname_flags(), see
commit 9fa3ec84587c ("allow incomplete imports of filenames")
This commit changed the function getname_flags() implementation.

Now the perf probe 'vfs_getname parameter=xxx' does not match any more. Extend the test logic to fall back to probing do_getname(). This reflects the updated kernel code.

Output after:

 # perf test vfs_getname
 138: Add vfs_getname probe to get syscall args filenames    : Ok
 140: Use vfs_getname probe to get syscall args filenames    : Ok
 154: Check open filename arg using perf trace + vfs_getname : Ok
 #
---
 tools/perf/tests/shell/lib/probe_vfs_getname.sh | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
tools/perf/tests/shell/lib/probe_vfs_getname.sh +15 -1
index 88cd0e26d5f6..9156a79212b9 100644
@@ -12,6 +12,8 @@ cleanup_probe_vfs_getname() {
 
 add_probe_vfs_getname() {
 	add_probe_verbose=$1
+	do_getname=0
+
 	if [ $had_vfs_getname -eq 1 ] ; then
 		result_initname_re="[[:space:]]+([[:digit:]]+)[[:space:]]+initname.*"
 		line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_initname_re" | sed -r "s/$result_initname_re/\1/")
@@ -28,12 +30,24 @@ add_probe_vfs_getname() {
 			line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_aname_re" | sed -r "s/$result_aname_re/\1/")
 		fi
 
+		if [ -z "$line" ] ; then
+			do_getname=1
+			result_iname_re="[[:space:]]+([[:digit:]]+)[[:space:]]+initname\(result\);"
+			line=$(perf probe -L do_getname 2>&1 | grep -E "$result_iname_re" | sed -r "s/$result_iname_re/\1/")
+		fi
+
 		if [ -z "$line" ] ; then
 			echo "Could not find probeable line"
 			return 2
 		fi
 
-		perf probe -q       "vfs_getname=getname_flags:${line} pathname=result->name:string" || \
+		if [ "$do_getname" -eq 1 ]
+		then
+			param="vfs_getname=do_getname:${line} pathname=result->iname:string"
+			perf probe -q "$param" || perf probe $add_probe_verbose "$param" || return 1
+			return 0
+		fi
+		perf probe -q "vfs_getname=getname_flags:${line} pathname=result->name:string" || \
 		perf probe $add_probe_verbose "vfs_getname=getname_flags:${line} pathname=filename:ustring" || return 1
 	fi
 }
Signature · 1 line
2.53.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The fallback perf probe uses `result->iname:string` instead of `result->name:string`, causing…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The fallback perf probe uses result->iname:string instead of result->name:string, causing out-of-bounds kernel memory reads for long paths.
- [Medium] The do_getname probe registration drops the reliable userspace string fallback (pathname=filename:ustring).
--

commit eda643d967c95ab86fa0ef1c44c37f4ff13cc45a
Author: Thomas Richter <[email protected]>

perf test: probe_vfs_getname add do_getname() probing fallback

The perf vfs_getname test skips on some platforms because getname_flags() no longer matches the expected perf probe format after kernel changes. This commit falls back to probing do_getname() if the initial getname_flags() lookup fails.

Quoted 4 lines
tools/perf/tests/shell/lib/probe_vfs_getname.sh +0 -0
index 88cd0e26d5f67..9156a79212b9e 100644

[ ... ]

Quoted 9 lines
tools/perf/tests/shell/lib/probe_vfs_getname.sh +5 -0
@@ -28,12 +30,24 @@ add_probe_vfs_getname() {
 			line=$(perf probe -L getname_flags 2>&1 | grep -E "$result_aname_re" | sed -r "s/$result_aname_re/\1/")
 		fi
 
+		if [ -z "$line" ] ; then
+			do_getname=1
+			result_iname_re="[[:space:]]+([[:digit:]]+)[[:space:]]+initname\(result\);"
+			line=$(perf probe -L do_getname 2>&1 | grep -E "$result_iname_re" | sed -r "s/$result_iname_re/\1/")
+		fi

tools/perf/tests/shell/lib/probe_vfs_getname.sh add_probe_vfs_getname() { · line 46

Quoted 10 lines
tools/perf/tests/shell/lib/probe_vfs_getname.sh +4 -1
+
 		if [ -z "$line" ] ; then
 			echo "Could not find probeable line"
 			return 2
 		fi
 
-		perf probe -q       "vfs_getname=getname_flags:${line} pathname=result->name:string" || \
+		if [ "$do_getname" -eq 1 ]
+		then
+			param="vfs_getname=do_getname:${line} pathname=result->iname:string"

Does probing result->iname:string read out-of-bounds kernel memory when paths are longer than EMBEDDED_NAME_MAX (192 bytes)?

In fs/namei.c, struct filename uses the flexible array iname for short paths, but dynamically allocates a separate buffer for longer ones. When paths are long, iname is filled without a null terminator, and result->name points to the newly allocated buffer.

Reading iname as a string might record garbage data or cause a kprobe fault if it reads past the end of the slab allocation.

Would it be better to use pathname=result->name:string here, mirroring the getname_flags behavior?

tools/perf/tests/shell/lib/probe_vfs_getname.sh add_probe_vfs_getname() { · line 47

Quoted 1 line
tools/perf/tests/shell/lib/probe_vfs_getname.sh +1 -0
+			perf probe -q "$param" || perf probe $add_probe_verbose "$param" || return 1

Does this logic inadvertently drop the userspace string fallback pathname=filename:ustring?

The original probe logic gracefully falls back to probing the userspace pointer directly if the compiler optimizes out the result pointer at the probed line.

Since do_getname() receives const char __user *filename as its first argument exactly like getname_flags(), could we retain the pathname=filename:ustring fallback here to improve test reliability across different compiler environments?

Quoted 6 lines
tools/perf/tests/shell/lib/probe_vfs_getname.sh +3 -0
+			return 0
+		fi
+		perf probe -q "vfs_getname=getname_flags:${line} pathname=result->name:string" || \
 		perf probe $add_probe_verbose "vfs_getname=getname_flags:${line} pathname=filename:ustring" || return 1
 	fi
 }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1