Skip to contentSkip to conversation

mm/damon: minor improvements for code readability and tests

RFC PATCH In review SeongJae Park 2 participants 25 messages May 20

Subsystems (3)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

cover mm/damon: minor improvements for code readability and tests

Implement minor improvements on code readability and tests for DAMON.

First seven patches are for DAMON code readability and resulting maintenance. Patches 1 and 2 make damon_set_regions() safer and easier to read. Patches 3 and 4 remove fragmented DAMON API use cases. Patches 5-7 hides unused core functions that are unnecessarily exposed to API callers.

The following seven patches are for DAMON tests improvement. Patches 8 and 9 adds and removes DAMON_DEBUG_SANITY verifications to ensure reasonable test coverage without too high overhead. Patch 10 adds a new kunit test for damon_set_regions(). Patch 11 makes sysfs.py selftest more gracefully finishes under test failures. Patches 12-13 adds simple sysfs.sh test cases for the monitoring intervals goal directory, the addr_unit file and the pause file.

SeongJae Park (14):
mm/damon/core: safely handle no region case in damon_set_regions() mm/damon/core: do not use region out of a loop in damon_set_regions() samples/damon/mtier: replace damon_add_region() with
damon_set_regions()
mm/damon/tests/vaddr-kunit: replace damon_add_region() with
damon_set_regions()
mm/damon/core: hide damon_add_region()
mm/damon/core: hide damon_insert_region()
mm/damon/core: hide damon_destroy_region()
mm/damon/core: add kdamond_call() debug_sanity check mm/damon/core: remove damon_verify_nr_regions() mm/damon/tests/core-kunit: add damon_set_regions() test cases selftests/damon/sysfs.py: stop kdamonds before failing selftests/damon/sysfs.sh: test monitoring intervals goal dir selftests/damon/sysfs.sh: test addr_unit file existence selftests/damon/sysfs.sh: test pause file existence

 include/linux/damon.h                  |  13 ---
 mm/damon/core.c                        |  92 ++++++++++++----
 mm/damon/tests/core-kunit.h            | 142 +++++++++++++++++++++----
 mm/damon/tests/vaddr-kunit.h           |  16 +--
 samples/damon/mtier.c                  |  10 +-
 tools/testing/selftests/damon/sysfs.py |   4 +
 tools/testing/selftests/damon/sysfs.sh |  14 +++
 7 files changed, 223 insertions(+), 68 deletions(-)

base-commit: 8b8727a18b7f247aed7e0476b92d07fc59c04cb8

Signature · 1 line
2.47.3
author maintainer
#1 lore raw

RFC PATCH 1/14 mm/damon/core: safely handle no region case in damon_set_regions()

damon_set_regions() calls damon_first_region() regardless of the number of DAMON regions in a given DAMON target. damon_first_region() internally uses list_first_entry(), which clearly documents the list is expected to be not empty. Due to the internal implementation of the macro, damon_set_regions() is safe for now. But the internal implementation of the macro can be changed in future. Refactor the function to explicitly and safely handle the empty region list case without depending on the internal implementation.

No behavioral change is intended.

---
 mm/damon/core.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
mm/damon/core.c +13 -0
index 0267faf216b95..40946a7f6f549 100644
@@ -356,6 +356,19 @@ int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 			damon_destroy_region(r, t);
 	}
 
+	if (!damon_nr_regions(t)) {
+		for (i = 0; i < nr_ranges; i++) {
+			r = damon_new_region(
+					ALIGN_DOWN(ranges[i].start,
+						min_region_sz),
+					ALIGN(ranges[i].end, min_region_sz));
+			if (!r)
+				return -ENOMEM;
+			damon_add_region(r, t);
+		}
+		return 0;
+	}
+
 	r = damon_first_region(t);
 	/* Add new regions or resize existing regions to fit in the ranges */
 	for (i = 0; i < nr_ranges; i++) {
Signature · 1 line
2.47.3
author maintainer
#2 lore raw

RFC PATCH 2/14 mm/damon/core: do not use region out of a loop in damon_set_regions()

In reply to SeongJae Park

damon_set_regions() assumes the DAMON region iterator is referencing the last region after the region iteration loop is completed. The code is indeed implemented in the way, but that is not a documented safe behavior. Hence it is unreliable and difficult to read. Cleanup the code to avoid the case.

No behavioral change is intended.

---
 mm/damon/core.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
mm/damon/core.c +9 -2
index 40946a7f6f549..e8cf3632115e5 100644
@@ -374,6 +374,7 @@ int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 	for (i = 0; i < nr_ranges; i++) {
 		struct damon_region *first = NULL, *last, *newr;
 		struct damon_addr_range *range;
+		bool insert_before_r = false;
 
 		range = &ranges[i];
 		/* Get the first/last regions intersecting with the range */
@@ -383,8 +384,10 @@ int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 					first = r;
 				last = r;
 			}
-			if (r->ar.start >= range->end)
+			if (r->ar.start >= range->end) {
+				insert_before_r = true;
 				break;
+			}
 		}
 		if (!first) {
 			/* no region intersects with this range */
@@ -394,7 +397,11 @@ int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 					ALIGN(range->end, min_region_sz));
 			if (!newr)
 				return -ENOMEM;
-			damon_insert_region(newr, damon_prev_region(r), r, t);
+			if (insert_before_r)
+				damon_insert_region(newr, damon_prev_region(r),
+						r, t);
+			else
+				damon_add_region(newr, t);
 		} else {
 			/* resize intersecting regions to fit in this range */
 			first->ar.start = ALIGN_DOWN(range->start,
Signature · 1 line
2.47.3
author maintainer
#3 lore raw

RFC PATCH 3/14 samples/damon/mtier: replace damon_add_region() with damon_set_regions()

In reply to SeongJae Park

mtier DAMON sample module and DAMON virtual address operation set (vaddr) unit tests are using damon_add_region() for setup of DAMON monitoring target region boundaries setup. But, damon_set_regions() is designed for exactly the purpose. All other DAMON API callers use the function for the purpose. Replace damon_add_region() usage in mtier sample module with damon_set_regions(), for unifying the use case and reducing the maintenance cost.

---
 samples/damon/mtier.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
samples/damon/mtier.c +6 -4
index 775838a23d935..eb1143de8df17 100644
@@ -75,11 +75,11 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote)
 	struct damon_ctx *ctx;
 	struct damon_attrs attrs;
 	struct damon_target *target;
-	struct damon_region *region;
 	struct damos *scheme;
 	struct damos_quota_goal *quota_goal;
 	struct damos_filter *filter;
 	struct region_range addr;
+	struct damon_addr_range range;
 	int ret;
 
 	ctx = damon_new_ctx();
@@ -120,10 +120,12 @@ static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote)
 		addr.end = promote ? node1_end_addr : node0_end_addr;
 	}
 
-	region = damon_new_region(addr.start, addr.end);
-	if (!region)
+	range.start = addr.start;
+	range.end = addr.end;
+
+	ret = damon_set_regions(target, &range, 1, DAMON_MIN_REGION_SZ);
+	if (ret)
 		goto free_out;
-	damon_add_region(region, target);
 
 	scheme = damon_new_scheme(
 			/* access pattern */
Signature · 1 line
2.47.3
author maintainer
#4 lore raw

RFC PATCH 4/14 mm/damon/tests/vaddr-kunit: replace damon_add_region() with damon_set_regions()

In reply to SeongJae Park

DAMON virtual address operation set (vaddr) unit tests is using damon_add_region() for setup of DAMON monitoring target region boundaries setup. But, damon_set_regions() is designed for exactly the purpose. All other DAMON API callers use the function for the purpose. Replace damon_add_region() usage in the unit tests with damon_set_regions(), for unifying the use case and reducing the maintenance cost.

---
 mm/damon/tests/vaddr-kunit.h | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
mm/damon/tests/vaddr-kunit.h +10 -6
index 98e734d77d517..23be9c3be75fa 100644
@@ -132,20 +132,24 @@ static void damon_do_test_apply_three_regions(struct kunit *test,
 				unsigned long *expected, int nr_expected)
 {
 	struct damon_target *t;
+	struct damon_addr_range *ranges;
 	struct damon_region *r;
 	int i;
 
 	t = damon_new_target();
 	if (!t)
 		kunit_skip(test, "target alloc fail");
+
+	ranges = kmalloc_array(nr_regions / 2, sizeof(*ranges), GFP_KERNEL);
+	if (!ranges) {
+		damon_destroy_target(t, NULL);
+		kunit_skip(test, "ranges alloc fail");
+	}
 	for (i = 0; i < nr_regions / 2; i++) {
-		r = damon_new_region(regions[i * 2], regions[i * 2 + 1]);
-		if (!r) {
-			damon_destroy_target(t, NULL);
-			kunit_skip(test, "region alloc fail");
-		}
-		damon_add_region(r, t);
+		ranges[i].start = regions[i * 2];
+		ranges[i].end = regions[i * 2 + 1];
 	}
+	damon_set_regions(t, ranges, nr_regions / 2, DAMON_MIN_REGION_SZ);
 
 	damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION_SZ);
 
Signature · 1 line
2.47.3
author maintainer
#7 lore raw

RFC PATCH 5/14 mm/damon/core: hide damon_add_region()

In reply to SeongJae Park

damon_add_region() is being used by only DAMON core, but exposed to DAMON API callers. Exposing something that is not really being used by others will only increase the maintenance cost. Hide it.

---
 include/linux/damon.h | 1 -
 mm/damon/core.c       | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
include/linux/damon.h +0 -1
index 4014fd0d463cb..b9370c1779cba 100644
@@ -1024,7 +1024,6 @@ static inline void damon_insert_region(struct damon_region *r,
 	t->nr_regions++;
 }
 
-void damon_add_region(struct damon_region *r, struct damon_target *t);
 void damon_destroy_region(struct damon_region *r, struct damon_target *t);
 int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 		unsigned int nr_ranges, unsigned long min_region_sz);
mm/damon/core.c +1 -1
index e8cf3632115e5..7d1de6ff54eba 100644
@@ -250,7 +250,7 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end)
 	return region;
 }
 
-void damon_add_region(struct damon_region *r, struct damon_target *t)
+static void damon_add_region(struct damon_region *r, struct damon_target *t)
 {
 	list_add_tail(&r->list, &t->regions_list);
 	t->nr_regions++;
Signature · 1 line
2.47.3
author maintainer
#8 lore raw

RFC PATCH 6/14 mm/damon/core: hide damon_insert_region()

In reply to SeongJae Park

damon_insert_region() is being used by only DAMON core, but exposed to DAMON API callers. Exposing something that is not really being used by others will only increase the maintenance cost. Hide it.

---
 include/linux/damon.h | 11 -----------
 mm/damon/core.c       | 11 +++++++++++
 2 files changed, 11 insertions(+), 11 deletions(-)
include/linux/damon.h +0 -11
index b9370c1779cba..3acca7deb1693 100644
@@ -1013,17 +1013,6 @@ void damon_add_probe(struct damon_ctx *ctx, struct damon_probe *probe);
 
 struct damon_region *damon_new_region(unsigned long start, unsigned long end);
 
-/*
- * Add a region between two other regions
- */
-static inline void damon_insert_region(struct damon_region *r,
-		struct damon_region *prev, struct damon_region *next,
-		struct damon_target *t)
-{
-	__list_add(&r->list, &prev->list, &next->list);
-	t->nr_regions++;
-}
-
 void damon_destroy_region(struct damon_region *r, struct damon_target *t);
 int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 		unsigned int nr_ranges, unsigned long min_region_sz);
mm/damon/core.c +11 -0
index 7d1de6ff54eba..53b4bdd27b39d 100644
@@ -256,6 +256,17 @@ static void damon_add_region(struct damon_region *r, struct damon_target *t)
 	t->nr_regions++;
 }
 
+/*
+ * Add a region between two other regions
+ */
+static inline void damon_insert_region(struct damon_region *r,
+		struct damon_region *prev, struct damon_region *next,
+		struct damon_target *t)
+{
+	__list_add(&r->list, &prev->list, &next->list);
+	t->nr_regions++;
+}
+
 #ifdef CONFIG_DAMON_DEBUG_SANITY
 static void damon_verify_del_region(struct damon_target *t)
 {
Signature · 1 line
2.47.3
author maintainer
#9 lore raw

RFC PATCH 7/14 mm/damon/core: hide damon_destroy_region()

In reply to SeongJae Park

damon_destroy_region() is being used by only DAMON core, but exposed to DAMON API callers. Exposing something that is not really being used by others will only increase the maintenance cost. Hide it.

---
 include/linux/damon.h | 1 -
 mm/damon/core.c       | 3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/damon.h +0 -1
index 3acca7deb1693..638ee65f88dcb 100644
@@ -1013,7 +1013,6 @@ void damon_add_probe(struct damon_ctx *ctx, struct damon_probe *probe);
 
 struct damon_region *damon_new_region(unsigned long start, unsigned long end);
 
-void damon_destroy_region(struct damon_region *r, struct damon_target *t);
 int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges,
 		unsigned int nr_ranges, unsigned long min_region_sz);
 void damon_update_region_access_rate(struct damon_region *r, bool accessed,
mm/damon/core.c +2 -1
index 53b4bdd27b39d..8a9202937781c 100644
@@ -291,7 +291,8 @@ static void damon_free_region(struct damon_region *r)
 	kmem_cache_free(damon_region_cache, r);
 }
 
-void damon_destroy_region(struct damon_region *r, struct damon_target *t)
+static void damon_destroy_region(struct damon_region *r,
+		struct damon_target *t)
 {
 	damon_del_region(r, t);
 	damon_free_region(r);
Signature · 1 line
2.47.3
author maintainer
#10 lore raw

RFC PATCH 8/14 mm/damon/core: add kdamond_call() debug_sanity check

In reply to SeongJae Park

kdamond_call() is the place where DAMON API callers are allowed to access the DAMON context's public internal state including the monitoring results. Hence it is important to ensure it is called with the expected DAMON context state. Do the check under DAMON_DEBUG_SANITY.

---
 mm/damon/core.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
mm/damon/core.c +33 -0
index 8a9202937781c..22327a23c7e57 100644
@@ -3331,6 +3331,37 @@ static void kdamond_usleep(unsigned long usecs)
 		usleep_range_idle(usecs, usecs + 1);
 }
 
+#ifdef CONFIG_DAMON_DEBUG_SANITY
+static void damon_verify_ctx(struct damon_ctx *c)
+{
+	struct damon_target *t;
+	struct damon_region *r;
+
+	damon_for_each_target(t, c) {
+		struct damon_region *prev_r = NULL;
+		unsigned int nr_regions = 0;
+
+		damon_for_each_region(r, t) {
+			WARN_ONCE(r->ar.start <= r->ar.end,
+					"region start (%lu) <= end (%lu)\n",
+					r->ar.start, r->ar.end);
+			WARN_ONCE(prev_r && prev_r->ar.end > r->ar.start,
+					"region overlap (%lu > %lu)\n",
+					prev_r->ar.end, r->ar.start);
+			prev_r = r;
+			nr_regions++;
+		}
+		WARN_ONCE(damon_nr_regions(t) != nr_regions,
+				"nr_regions mismatch: %u != %u\n",
+				damon_nr_regions(t), nr_regions);
+	}
+}
+#else
+static void damon_verify_ctx(struct damon_ctx *c)
+{
+}
+#endif
+
 /*
  * kdamond_call() - handle damon_call_control objects.
  * @ctx:	The &struct damon_ctx of the kdamond.
@@ -3346,6 +3377,8 @@ static void kdamond_call(struct damon_ctx *ctx, bool cancel)
 	struct damon_call_control *control, *next;
 	LIST_HEAD(controls);
 
+	damon_verify_ctx(ctx);
+
 	mutex_lock(&ctx->call_controls_lock);
 	list_splice_tail_init(&ctx->call_controls, &controls);
 	mutex_unlock(&ctx->call_controls_lock);
Signature · 1 line
2.47.3
author maintainer
#14 lore raw

RFC PATCH 9/14 mm/damon/core: remove damon_verify_nr_regions()

In reply to SeongJae Park

When CONFIG_DAMON_DEBUG_SANITY is enabled, damon_verify_nr_regions() is called for each damon_nr_regions() invocation. damon_veify_nr_regions() iterates all regions. damon_nr_regions() is called for each region in kdamond_reset_aggregated() and damos_apply_scheme(). Hence it imposes O(n**2) overhead where n is the number of regions.

Though the verification is enabled only under DAMON_DEBUG_SANITY, which is not for production use cases, it could be too high overhead. Meanwhile, damon_verify_ctx() is doing the damon_nr_regions() test. Because damon_verify_ctx() is called for each kdamond_call(), the test coverage from damon_verify_ctx() could be sufficient. Remove damon_nr_regions() verification.

---
 mm/damon/core.c | 19 -------------------
 1 file changed, 19 deletions(-)
mm/damon/core.c +0 -19
index 22327a23c7e57..b2d268c4102db 100644
@@ -686,27 +686,8 @@ void damon_destroy_target(struct damon_target *t, struct damon_ctx *ctx)
 	damon_free_target(t);
 }
 
-#ifdef CONFIG_DAMON_DEBUG_SANITY
-static void damon_verify_nr_regions(struct damon_target *t)
-{
-	struct damon_region *r;
-	unsigned int count = 0;
-
-	damon_for_each_region(r, t)
-		count++;
-	WARN_ONCE(count != t->nr_regions, "t->nr_regions (%u) != count (%u)\n",
-			t->nr_regions, count);
-}
-#else
-static void damon_verify_nr_regions(struct damon_target *t)
-{
-}
-#endif
-
 unsigned int damon_nr_regions(struct damon_target *t)
 {
-	damon_verify_nr_regions(t);
-
 	return t->nr_regions;
 }
 
Signature · 1 line
2.47.3
author maintainer
#15 lore raw

RFC PATCH 10/14 mm/damon/tests/core-kunit: add damon_set_regions() test cases

In reply to SeongJae Park

damon_set_regions() is one of the main DAMON kernel API functions that set up the monitoring target memory region boundaries. Implement unit tests for verifying its basic functionalities.

---
 mm/damon/tests/core-kunit.h | 142 ++++++++++++++++++++++++++++++------
 1 file changed, 120 insertions(+), 22 deletions(-)
mm/damon/tests/core-kunit.h +120 -22
index 866f716e5760d..1cfb8c176b873 100644
@@ -390,41 +390,139 @@ static void damon_test_ops_registration(struct kunit *test)
 	}
 }
 
-static void damon_test_set_regions(struct kunit *test)
+static void damon_test_set_regions_for(struct kunit *test,
+		struct damon_addr_range *old_ranges, int sz_old_ranges,
+		struct damon_addr_range *new_ranges, int sz_new_ranges,
+		unsigned long min_region_sz,
+		struct damon_addr_range *expect_ranges, int sz_expect_ranges)
 {
-	struct damon_target *t = damon_new_target();
-	struct damon_region *r1, *r2;
-	struct damon_addr_range range = {.start = 8, .end = 28};
-	unsigned long expects[] = {8, 16, 16, 24, 24, 28};
-	int expect_idx = 0;
+	struct damon_target *t;
 	struct damon_region *r;
+	int i;
 
+	t = damon_new_target();
 	if (!t)
 		kunit_skip(test, "target alloc fail");
-	r1 = damon_new_region(4, 16);
-	if (!r1) {
-		damon_free_target(t);
-		kunit_skip(test, "region alloc fail");
-	}
-	r2 = damon_new_region(24, 32);
-	if (!r2) {
-		damon_free_target(t);
-		damon_free_region(r1);
-		kunit_skip(test, "second region alloc fail");
+	for (i = 0; i < sz_old_ranges; i++) {
+		r = damon_new_region(old_ranges[i].start, old_ranges[i].end);
+		if (!r) {
+			damon_destroy_target(t, NULL);
+			kunit_skip(test, "%d-th r alloc fail\n", i);
+		}
+		damon_add_region(r, t);
 	}
 
-	damon_add_region(r1, t);
-	damon_add_region(r2, t);
-	damon_set_regions(t, &range, 1, 1);
+	damon_set_regions(t, new_ranges, sz_new_ranges, min_region_sz);
 
-	KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 3);
+	KUNIT_EXPECT_EQ(test, damon_nr_regions(t), sz_expect_ranges);
+	if (damon_nr_regions(t) != sz_expect_ranges) {
+		damon_destroy_target(t, NULL);
+		return;
+	}
+	i = 0;
 	damon_for_each_region(r, t) {
-		KUNIT_EXPECT_EQ(test, r->ar.start, expects[expect_idx++]);
-		KUNIT_EXPECT_EQ(test, r->ar.end, expects[expect_idx++]);
+		KUNIT_EXPECT_EQ(test, r->ar.start, expect_ranges[i].start);
+		KUNIT_EXPECT_EQ(test, r->ar.end, expect_ranges[i++].end);
 	}
+
 	damon_destroy_target(t, NULL);
 }
 
+static void damon_test_set_regions(struct kunit *test)
+{
+	/* Initial build up on empty target. */
+	damon_test_set_regions_for(test,
+			(struct damon_addr_range[]){}, 0,
+			(struct damon_addr_range[]){
+			{.start = 5, .end = 15},
+			{.start = 15, .end = 25},
+			}, 2,
+			1,
+			(struct damon_addr_range[]){
+			{.start = 5, .end = 15},
+			{.start = 15, .end = 25},
+			}, 2);
+	/* Un-intersecting regions should be removed. */
+	damon_test_set_regions_for(test,
+			(struct damon_addr_range[]){
+			{.start = 4, .end = 16},
+			{.start = 24, .end = 32},
+			}, 2,
+			(struct damon_addr_range[]){
+			{.start = 18, .end = 23},
+			}, 1,
+			1,
+			(struct damon_addr_range[]){
+			{.start = 18, .end = 23},
+			}, 1);
+	/*
+	 * Holes should be filled up with new regions.
+	 *
+	 * old:       [4,   16)        [24,     32)
+	 * new:         [8,                 28)
+	 * expect:      [8, 16)[16,24),[24, 28)
+	 */
+	damon_test_set_regions_for(test,
+			(struct damon_addr_range[]){
+			{.start = 4, .end = 16},
+			{.start = 24, .end = 32},
+			}, 2,
+			(struct damon_addr_range[]){
+			{.start = 8, .end = 28},
+			}, 1,
+			1,
+			(struct damon_addr_range[]){
+			{.start = 8, .end = 16},
+			{.start = 16, .end = 24},
+			{.start = 24, .end = 28},
+			}, 3);
+	/*
+	 * New regions should be able to be appended.
+	 *
+	 * old:       [0, 4)[4,    17)
+	 * new:       [0,       15)     [25, 40)
+	 * expect:    [0, 4)[4, 15)     [25, 40)
+	 */
+	damon_test_set_regions_for(test,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 4},
+			{.start = 4, .end = 17},
+			}, 2,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 15},
+			{.start = 25, .end = 40},
+			}, 2,
+			1,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 4},
+			{.start = 4, .end = 15},
+			{.start = 25, .end = 40},
+			}, 3);
+	/*
+	 * New regions should be able to be inserted.
+	 *
+	 * old:       [0, 4)                      [42,    52)
+	 * new:       [0,       15)     [25, 40)    [44, 50)
+	 * expect:    [0,       15)     [25, 40)    [44, 50)
+	 */
+	damon_test_set_regions_for(test,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 4},
+			{.start = 42, .end = 52},
+			}, 2,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 15},
+			{.start = 25, .end = 40},
+			{.start = 44, .end = 50},
+			}, 3,
+			1,
+			(struct damon_addr_range[]){
+			{.start = 0, .end = 15},
+			{.start = 25, .end = 40},
+			{.start = 44, .end = 50},
+			}, 3);
+}
+
 static void damon_test_nr_accesses_to_accesses_bp(struct kunit *test)
 {
 	struct damon_attrs attrs = {
Signature · 1 line
2.47.3
author maintainer
#16 lore raw

RFC PATCH 11/14 selftests/damon/sysfs.py: stop kdamonds before failing

In reply to SeongJae Park

When an assertion is failed, sysfs.py DAMON selftest immediately exits the test program leaving the DAMON running behind. Many of the following tests need to start DAMON on their own. But because DAMON that was started by sysfs.py is still running, those start attempts fail, and the tests are failed or skipped. Update sysfs.py to stop DAMON before exiting the test program due to the assertion failure.

---
 tools/testing/selftests/damon/sysfs.py | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/selftests/damon/sysfs.py +4 -0
index cd4d82c852113..aa03a1187489f 100755
@@ -24,9 +24,12 @@ def dump_damon_status_dict(pid):
     except Exception as e:
         return None, 'json.load fail (%s)' % e
 
+kdamonds = None
 def fail(expectation, status):
     print('unexpected %s' % expectation)
     print(json.dumps(status, indent=4))
+    if kdamonds is not None:
+        kdamonds.stop()
     exit(1)
 
 def assert_true(condition, expectation, status):
@@ -248,6 +251,7 @@ def assert_ctxs_committed(kdamonds):
                 ctx.pause = False
 
 def main():
+    global kdamonds
     kdamonds = _damon_sysfs.Kdamonds(
             [_damon_sysfs.Kdamond(
                 contexts=[_damon_sysfs.DamonCtx(
Signature · 1 line
2.47.3
author maintainer
#17 lore raw

RFC PATCH 12/14 selftests/damon/sysfs.sh: test monitoring intervals goal dir

In reply to SeongJae Park

sysfs.sh DAMON selftest is not testing monitoring intervals goal directory. Add the test.

---
 tools/testing/selftests/damon/sysfs.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)
tools/testing/selftests/damon/sysfs.sh +12 -0
index 1ac3e2ce8e448..b3418214ed358 100755
@@ -282,6 +282,17 @@ test_targets()
 	ensure_dir "$targets_dir/1" "not_exist"
 }
 
+
+test_intervals_goal()
+{
+	goal_dir=$1
+	ensure_dir "$goal_dir" "exist"
+	ensure_file "$goal_dir/access_bp" "exist" "600"
+	ensure_file "$goal_dir/aggrs" "exist" "600"
+	ensure_file "$goal_dir/min_sample_us" "exist" "600"
+	ensure_file "$goal_dir/max_sample_us" "exist" "600"
+}
+
 test_intervals()
 {
 	intervals_dir=$1
@@ -289,6 +300,7 @@ test_intervals()
 	ensure_file "$intervals_dir/aggr_us" "exist" "600"
 	ensure_file "$intervals_dir/sample_us" "exist" "600"
 	ensure_file "$intervals_dir/update_us" "exist" "600"
+	test_intervals_goal "$intervals_dir/intervals_goal"
 }
 
 test_damon_filter()
Signature · 1 line
2.47.3
author maintainer
#18 lore raw

RFC PATCH 13/14 selftests/damon/sysfs.sh: test addr_unit file existence

In reply to SeongJae Park

sysfs.sh DAMON selftest is not testing the existence of addr_unit sysfs file. Add the test.

---
 tools/testing/selftests/damon/sysfs.sh | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/damon/sysfs.sh +1 -0
index b3418214ed358..1e10881afabb6 100755
@@ -365,6 +365,7 @@ test_context()
 	ensure_dir "$context_dir" "exist"
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
+	ensure_file "$context_dir/addr_unit" "exit" 600
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
2.47.3
author maintainer
#22 lore raw

RFC PATCH 14/14 selftests/damon/sysfs.sh: test pause file existence

In reply to SeongJae Park

sysfs.sh DAMON selftest is not testing the existence of the 'pause' sysfs file. Add the test.

---
 tools/testing/selftests/damon/sysfs.sh | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/damon/sysfs.sh +1 -0
index 1e10881afabb6..ae002dd3c0797 100755
@@ -366,6 +366,7 @@ test_context()
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
 	ensure_file "$context_dir/addr_unit" "exit" 600
+	ensure_file "$context_dir/pause" "exit" 600
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
2.47.3
#5 lore raw

Re: [RFC PATCH 04/14] mm/damon/tests/vaddr-kunit: replace damon_add_region() with damon_set_regions()

In reply to SeongJae Park
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The dynamically allocated `ranges` array is never freed, resulting in a memory leak. - [Medium]…

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The dynamically allocated ranges array is never freed, resulting in a memory leak.
- [Medium] The return value of damon_set_regions() is ignored, which can lead to a NULL pointer dereference if memory allocation fails. --

commit 178b94e956635731d61e076b1aa09699c5f9b686
Author: SeongJae Park <[email protected]>

mm/damon/tests/vaddr-kunit: replace damon_add_region() with damon_set_regions()

This commit updates the DAMON vaddr unit tests to use damon_set_regions() for setting up target region boundaries. This replaces the manual setup loop that previously used damon_add_region().

Quoted 4 lines
mm/damon/tests/vaddr-kunit.h +0 -0
index 98e734d77d517..23be9c3be75fa 100644

[ ... ]

Quoted 18 lines
mm/damon/tests/vaddr-kunit.h +7 -0
@@ -132,20 +132,24 @@ static void damon_do_test_apply_three_regions(struct kunit *test,
 				unsigned long *expected, int nr_expected)
 {
 	struct damon_target *t;
+	struct damon_addr_range *ranges;
 	struct damon_region *r;
 	int i;
 
 	t = damon_new_target();
 	if (!t)
 		kunit_skip(test, "target alloc fail");
+
+	ranges = kmalloc_array(nr_regions / 2, sizeof(*ranges), GFP_KERNEL);
+	if (!ranges) {
+		damon_destroy_target(t, NULL);
+		kunit_skip(test, "ranges alloc fail");
+	}
 	for (i = 0; i < nr_regions / 2; i++) {

mm/damon/tests/vaddr-kunit.h static void damon_do_test_apply_three_regions(struct kunit *test, · line 152

Quoted 10 lines
mm/damon/tests/vaddr-kunit.h +3 -6
-		r = damon_new_region(regions[i * 2], regions[i * 2 + 1]);
-		if (!r) {
-			damon_destroy_target(t, NULL);
-			kunit_skip(test, "region alloc fail");
-		}
-		damon_add_region(r, t);
+		ranges[i].start = regions[i * 2];
+		ranges[i].end = regions[i * 2 + 1];
 	}
+	damon_set_regions(t, ranges, nr_regions / 2, DAMON_MIN_REGION_SZ);

[Severity: Medium]
Is it safe to ignore the return value of damon_set_regions() here?

If damon_set_regions() encounters an allocation failure, it returns -ENOMEM, leaving the target with fewer regions than intended. Could this lead to a NULL pointer dereference in the subsequent test code if it attempts to access regions that failed to allocate?

[Severity: Medium]
Does this code leak the ranges array?

It appears ranges is dynamically allocated via kmalloc_array() but is never freed before the function returns, and damon_set_regions() does not take ownership of this memory.

Quoted 3 lines
mm/damon/tests/vaddr-kunit.h +0 -0
 	damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION_SZ);
 
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
#19 lore raw

Re: [RFC PATCH 13/14] selftests/damon/sysfs.sh: test addr_unit file existence

In reply to SeongJae Park
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added test for the `addr_unit` sysfs file incorrectly passes 'exit' instead of 'exist'…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for the addr_unit sysfs file incorrectly passes 'exit' instead of 'exist' to ensure_file(), causing the test check to be silently skipped. --

commit a9bc6162fe06c0405081aeb68c3f5e9a54287e20
Author: SeongJae Park <[email protected]>

selftests/damon/sysfs.sh: test addr_unit file existence

This commit adds a test to verify the existence of the addr_unit sysfs file in the DAMON selftests.

tools/testing/selftests/damon/sysfs.sh test_context() · line 368

Quoted 9 lines
tools/testing/selftests/damon/sysfs.sh +1 -0
index b3418214ed358..1e10881afabb6 100755
@@ -365,6 +365,7 @@ test_context()
 	ensure_dir "$context_dir" "exist"
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
+	ensure_file "$context_dir/addr_unit" "exit" 600

[Severity: Medium]
Is "exit" a typo for "exist" in this new test?

If ensure_file() expects "exist" or "not_exist" as its second argument, passing "exit" might cause the function to return immediately without performing any file existence or permission checks, which would silently skip the intended test coverage.

Quoted 3 lines
tools/testing/selftests/damon/sysfs.sh +0 -0
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13
#23 lore raw

Re: [RFC PATCH 14/14] selftests/damon/sysfs.sh: test pause file existence

In reply to SeongJae Park
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added test for the 'pause' file passes the typoed string 'exit' instead of 'exist' to…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for the 'pause' file passes the typoed string 'exit' instead of 'exist' to ensure_file(), causing the test to silently do nothing. --

commit dfd394f0319e5426a9139ffa02a782a34b43e8ff
Author: SeongJae Park <[email protected]>

selftests/damon/sysfs.sh: test pause file existence

This commit adds a test to ensure the 'pause' sysfs file exists in DAMON's sysfs interface.

tools/testing/selftests/damon/sysfs.sh test_context() · line 369

Quoted 8 lines
tools/testing/selftests/damon/sysfs.sh +1 -0
@@ -366,6 +366,7 @@ test_context()
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
 	ensure_file "$context_dir/addr_unit" "exit" 600
+	ensure_file "$context_dir/pause" "exit" 600

[Severity: Medium]
Is this test unintentionally bypassed? The helper function ensure_file() checks for the strings "exist" or "not_exist" to determine what checks to perform. Because "exit" is passed instead of "exist", the function evaluates neither condition and returns immediately.

This prevents the test from verifying the file's presence or its permissions, causing it to silently do nothing.

Quoted 3 lines
tools/testing/selftests/damon/sysfs.sh +0 -0
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14
#11 lore raw

Re: [RFC PATCH 08/14] mm/damon/core: add kdamond_call() debug_sanity check

In reply to SeongJae Park
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] The sanity check for region bounds in `damon_verify_ctx` uses an inverted condition, causing it to…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The sanity check for region bounds in damon_verify_ctx uses an inverted condition, causing it to falsely trigger a kernel warning on all valid regions and fail to catch invalid ones. --

commit 7d803208aef5bc4f95dd9c37657de5b62618e8e6
Author: SeongJae Park <[email protected]>

mm/damon/core: add kdamond_call() debug_sanity check

This commit introduces a debug sanity check for the DAMON context state before handling damon_call_control objects in kdamond_call(). The check verifies region boundaries, overlaps, and the total region count under CONFIG_DAMON_DEBUG_SANITY.

Quoted 3 lines
mm/damon/core.c +0 -0

[ ... ]

Quoted 8 lines
mm/damon/core.c +4 -0
@@ -3326,6 +3326,37 @@ static void kdamond_usleep(unsigned long usecs)
 		usleep_range_idle(usecs, usecs + 1);
 }
 
+#ifdef CONFIG_DAMON_DEBUG_SANITY
+static void damon_verify_ctx(struct damon_ctx *c)
+{
+	struct damon_target *t;

mm/damon/core.c static void kdamond_usleep(unsigned long usecs) · line 3342

Quoted 10 lines
mm/damon/core.c +10 -0
+	struct damon_region *r;
+
+	damon_for_each_target(t, c) {
+		struct damon_region *prev_r = NULL;
+		unsigned int nr_regions = 0;
+
+		damon_for_each_region(r, t) {
+			WARN_ONCE(r->ar.start <= r->ar.end,
+					"region start (%lu) <= end (%lu)\n",
+					r->ar.start, r->ar.end);

[Severity: High]
Should this condition be inverted? WARN_ONCE triggers when the condition evaluates to true. Since a valid memory region typically has a start address strictly less than its end address, this evaluates to true for normal regions.

Could this trigger a spurious warning on the very first valid region encountered, and because it uses WARN_ONCE, prevent any actual regressions where start > end from being reported?

Quoted 6 lines
mm/damon/core.c +6 -0
+			WARN_ONCE(prev_r && prev_r->ar.end > r->ar.start,
+					"region overlap (%lu > %lu)\n",
+					prev_r->ar.end, r->ar.start);
+			prev_r = r;
+			nr_regions++;
+		}

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
author maintainer
#6 lore raw

Re: [RFC PATCH 04/14] mm/damon/tests/vaddr-kunit: replace damon_add_region() with damon_set_regions()

In reply to [email protected]
Quoted 51 lines · On Wed, 20 May 2026 06:38:41 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The dynamically allocated ranges array is never freed, resulting in a memory leak.
- [Medium] The return value of damon_set_regions() is ignored, which can lead to a NULL pointer dereference if memory allocation fails. --

commit 178b94e956635731d61e076b1aa09699c5f9b686
Author: SeongJae Park <[email protected]>

mm/damon/tests/vaddr-kunit: replace damon_add_region() with damon_set_regions()

This commit updates the DAMON vaddr unit tests to use damon_set_regions() for setting up target region boundaries. This replaces the manual setup loop that previously used damon_add_region().

Quoted 4 lines
mm/damon/tests/vaddr-kunit.h +0 -0
index 98e734d77d517..23be9c3be75fa 100644

[ ... ]

Quoted 18 lines
mm/damon/tests/vaddr-kunit.h +7 -0
@@ -132,20 +132,24 @@ static void damon_do_test_apply_three_regions(struct kunit *test,
 				unsigned long *expected, int nr_expected)
 {
 	struct damon_target *t;
+	struct damon_addr_range *ranges;
 	struct damon_region *r;
 	int i;
 
 	t = damon_new_target();
 	if (!t)
 		kunit_skip(test, "target alloc fail");
+
+	ranges = kmalloc_array(nr_regions / 2, sizeof(*ranges), GFP_KERNEL);
+	if (!ranges) {
+		damon_destroy_target(t, NULL);
+		kunit_skip(test, "ranges alloc fail");
+	}
 	for (i = 0; i < nr_regions / 2; i++) {

mm/damon/tests/vaddr-kunit.h static void damon_do_test_apply_three_regions(struct kunit *test, · line 152

Quoted 10 lines
mm/damon/tests/vaddr-kunit.h +3 -6
-		r = damon_new_region(regions[i * 2], regions[i * 2 + 1]);
-		if (!r) {
-			damon_destroy_target(t, NULL);
-			kunit_skip(test, "region alloc fail");
-		}
-		damon_add_region(r, t);
+		ranges[i].start = regions[i * 2];
+		ranges[i].end = regions[i * 2 + 1];
 	}
+	damon_set_regions(t, ranges, nr_regions / 2, DAMON_MIN_REGION_SZ);

[Severity: Medium]
Is it safe to ignore the return value of damon_set_regions() here?

Quoted 4 lines

If damon_set_regions() encounters an allocation failure, it returns -ENOMEM, leaving the target with fewer regions than intended. Could this lead to a NULL pointer dereference in the subsequent test code if it attempts to access regions that failed to allocate?

Nice catch. I will check the results and skip in the case of failure.

Quoted 7 lines

[Severity: Medium]
Does this code leak the ranges array?

It appears ranges is dynamically allocated via kmalloc_array() but is never freed before the function returns, and damon_set_regions() does not take ownership of this memory.

Good finding. I will free it.

Quoted 7 lines
Quoted 4 lines
mm/damon/tests/vaddr-kunit.h +0 -0
 	damon_set_regions(t, three_regions, 3, DAMON_MIN_REGION_SZ);
 
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4

Thanks,
SJ

author maintainer
#12 lore raw

Re: [RFC PATCH 08/14] mm/damon/core: add kdamond_call() debug_sanity check

In reply to [email protected]
Quoted 45 lines · On Wed, 20 May 2026 06:52:52 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The sanity check for region bounds in damon_verify_ctx uses an inverted condition, causing it to falsely trigger a kernel warning on all valid regions and fail to catch invalid ones. --

commit 7d803208aef5bc4f95dd9c37657de5b62618e8e6
Author: SeongJae Park <[email protected]>

mm/damon/core: add kdamond_call() debug_sanity check

This commit introduces a debug sanity check for the DAMON context state before handling damon_call_control objects in kdamond_call(). The check verifies region boundaries, overlaps, and the total region count under CONFIG_DAMON_DEBUG_SANITY.

Quoted 3 lines
mm/damon/core.c +0 -0

[ ... ]

Quoted 8 lines
mm/damon/core.c +4 -0
@@ -3326,6 +3326,37 @@ static void kdamond_usleep(unsigned long usecs)
 		usleep_range_idle(usecs, usecs + 1);
 }
 
+#ifdef CONFIG_DAMON_DEBUG_SANITY
+static void damon_verify_ctx(struct damon_ctx *c)
+{
+	struct damon_target *t;

mm/damon/core.c static void kdamond_usleep(unsigned long usecs) · line 3342

Quoted 10 lines
mm/damon/core.c +10 -0
+	struct damon_region *r;
+
+	damon_for_each_target(t, c) {
+		struct damon_region *prev_r = NULL;
+		unsigned int nr_regions = 0;
+
+		damon_for_each_region(r, t) {
+			WARN_ONCE(r->ar.start <= r->ar.end,
+					"region start (%lu) <= end (%lu)\n",
+					r->ar.start, r->ar.end);

[Severity: High]
Should this condition be inverted? WARN_ONCE triggers when the condition evaluates to true. Since a valid memory region typically has a start address strictly less than its end address, this evaluates to true for normal regions.

Quoted 3 lines

Could this trigger a spurious warning on the very first valid region encountered, and because it uses WARN_ONCE, prevent any actual regressions where start > end from being reported?

Nice catch. start == end is also invalid because we disallow empty regions. I will update it to start >= end in the next version.

Quoted 12 lines
Quoted 7 lines
mm/damon/core.c +6 -0
+			WARN_ONCE(prev_r && prev_r->ar.end > r->ar.start,
+					"region overlap (%lu > %lu)\n",
+					prev_r->ar.end, r->ar.start);
+			prev_r = r;
+			nr_regions++;
+		}

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8

Thanks,
SJ

author maintainer
#13 lore raw

Re: [RFC PATCH 08/14] mm/damon/core: add kdamond_call() debug_sanity check

In reply to [email protected]
Quoted 45 lines · On Wed, 20 May 2026 06:52:52 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The sanity check for region bounds in damon_verify_ctx uses an inverted condition, causing it to falsely trigger a kernel warning on all valid regions and fail to catch invalid ones. --

commit 7d803208aef5bc4f95dd9c37657de5b62618e8e6
Author: SeongJae Park <[email protected]>

mm/damon/core: add kdamond_call() debug_sanity check

This commit introduces a debug sanity check for the DAMON context state before handling damon_call_control objects in kdamond_call(). The check verifies region boundaries, overlaps, and the total region count under CONFIG_DAMON_DEBUG_SANITY.

Quoted 3 lines
mm/damon/core.c +0 -0

[ ... ]

Quoted 8 lines
mm/damon/core.c +4 -0
@@ -3326,6 +3326,37 @@ static void kdamond_usleep(unsigned long usecs)
 		usleep_range_idle(usecs, usecs + 1);
 }
 
+#ifdef CONFIG_DAMON_DEBUG_SANITY
+static void damon_verify_ctx(struct damon_ctx *c)
+{
+	struct damon_target *t;

mm/damon/core.c static void kdamond_usleep(unsigned long usecs) · line 3342

Quoted 10 lines
mm/damon/core.c +10 -0
+	struct damon_region *r;
+
+	damon_for_each_target(t, c) {
+		struct damon_region *prev_r = NULL;
+		unsigned int nr_regions = 0;
+
+		damon_for_each_region(r, t) {
+			WARN_ONCE(r->ar.start <= r->ar.end,
+					"region start (%lu) <= end (%lu)\n",
+					r->ar.start, r->ar.end);

[Severity: High]
Should this condition be inverted? WARN_ONCE triggers when the condition evaluates to true. Since a valid memory region typically has a start address strictly less than its end address, this evaluates to true for normal regions.

Quoted 3 lines

Could this trigger a spurious warning on the very first valid region encountered, and because it uses WARN_ONCE, prevent any actual regressions where start > end from being reported?

Good catch. start == end should also trigger warning though, because DAMON disallows empty regions. I will fix this in the next revision.

Quoted 12 lines
Quoted 7 lines
mm/damon/core.c +6 -0
+			WARN_ONCE(prev_r && prev_r->ar.end > r->ar.start,
+					"region overlap (%lu > %lu)\n",
+					prev_r->ar.end, r->ar.start);
+			prev_r = r;
+			nr_regions++;
+		}

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8

Thanks,
SJ

author maintainer
#20 lore raw

Re: [RFC PATCH 13/14] selftests/damon/sysfs.sh: test addr_unit file existence

In reply to [email protected]
Quoted 25 lines · On Wed, 20 May 2026 06:41:56 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for the addr_unit sysfs file incorrectly passes 'exit' instead of 'exist' to ensure_file(), causing the test check to be silently skipped. --

commit a9bc6162fe06c0405081aeb68c3f5e9a54287e20
Author: SeongJae Park <[email protected]>

selftests/damon/sysfs.sh: test addr_unit file existence

This commit adds a test to verify the existence of the addr_unit sysfs file in the DAMON selftests.

tools/testing/selftests/damon/sysfs.sh test_context() · line 368

Quoted 9 lines
tools/testing/selftests/damon/sysfs.sh +1 -0
index b3418214ed358..1e10881afabb6 100755
@@ -365,6 +365,7 @@ test_context()
 	ensure_dir "$context_dir" "exist"
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
+	ensure_file "$context_dir/addr_unit" "exit" 600

[Severity: Medium]
Is "exit" a typo for "exist" in this new test?

Quoted 4 lines

If ensure_file() expects "exist" or "not_exist" as its second argument, passing "exit" might cause the function to return immediately without performing any file existence or permission checks, which would silently skip the intended test coverage.

Good catch. The ensure_file() expects "not_exist" or anything else for the second argument, so this test is working as intended. But definitely "exit" is a typo. I will fix this in the next revision.

Quoted 7 lines
Quoted 4 lines
tools/testing/selftests/damon/sysfs.sh +0 -0
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13

Thanks,
SJ

author maintainer
#24 lore raw

Re: [RFC PATCH 14/14] selftests/damon/sysfs.sh: test pause file existence

In reply to [email protected]
Quoted 27 lines · On Wed, 20 May 2026 06:42:52 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for the 'pause' file passes the typoed string 'exit' instead of 'exist' to ensure_file(), causing the test to silently do nothing. --

commit dfd394f0319e5426a9139ffa02a782a34b43e8ff
Author: SeongJae Park <[email protected]>

selftests/damon/sysfs.sh: test pause file existence

This commit adds a test to ensure the 'pause' sysfs file exists in DAMON's sysfs interface.

tools/testing/selftests/damon/sysfs.sh test_context() · line 369

Quoted 8 lines
tools/testing/selftests/damon/sysfs.sh +1 -0
@@ -366,6 +366,7 @@ test_context()
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
 	ensure_file "$context_dir/addr_unit" "exit" 600
+	ensure_file "$context_dir/pause" "exit" 600

[Severity: Medium]
Is this test unintentionally bypassed? The helper function ensure_file() checks for the strings "exist" or "not_exist" to determine what checks to perform. Because "exit" is passed instead of "exist", the function evaluates neither condition and returns immediately.

Quoted 2 lines

This prevents the test from verifying the file's presence or its permissions, causing it to silently do nothing.

Good catch, I will fix this in the next revision.

Quoted 7 lines
Quoted 4 lines
tools/testing/selftests/damon/sysfs.sh +0 -0
 	test_monitoring_attrs "$context_dir/monitoring_attrs"
 	test_targets "$context_dir/targets"
 	test_schemes "$context_dir/schemes"
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14

Thanks,
SJ

author maintainer
#21 lore raw

Re: [RFC PATCH 13/14] selftests/damon/sysfs.sh: test addr_unit file existence

In reply to SeongJae Park
Quoted 27 lines · On Wed, 20 May 2026 07:08:17 -0700 SeongJae Park <[email protected]> wrote:
Quoted 25 lines · On Wed, 20 May 2026 06:41:56 +0000 [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for the addr_unit sysfs file incorrectly passes 'exit' instead of 'exist' to ensure_file(), causing the test check to be silently skipped. --

commit a9bc6162fe06c0405081aeb68c3f5e9a54287e20
Author: SeongJae Park <[email protected]>

selftests/damon/sysfs.sh: test addr_unit file existence

This commit adds a test to verify the existence of the addr_unit sysfs file in the DAMON selftests.

tools/testing/selftests/damon/sysfs.sh test_context() · line 368

Quoted 9 lines
tools/testing/selftests/damon/sysfs.sh +1 -0
index b3418214ed358..1e10881afabb6 100755
@@ -365,6 +365,7 @@ test_context()
 	ensure_dir "$context_dir" "exist"
 	ensure_file "$context_dir/avail_operations" "exit" 400
 	ensure_file "$context_dir/operations" "exist" 600
+	ensure_file "$context_dir/addr_unit" "exit" 600

[Severity: Medium]
Is "exit" a typo for "exist" in this new test?

Quoted 7 lines
Quoted 4 lines

If ensure_file() expects "exist" or "not_exist" as its second argument, passing "exit" might cause the function to return immediately without performing any file existence or permission checks, which would silently skip the intended test coverage.

Good catch. The ensure_file() expects "not_exist" or anything else for the second argument, so this test is working as intended.

Sashiko is correct. The test was doing nothing.

Quoted 2 lines

But definitely "exit" is
a typo. I will fix this in the next revision.

Anyway will be fixed in the next revision.

Thnks,
SJ

[...]