Skip to contentSkip to conversation

s390: crypto: add select CRYPTO_AEAD for aes

PATCH In review Arnd Bergmann 3 participants 3 messages May 20 – May 29

Subsystems (3)
Crypto API s390 s390 crypto modules, prng driver, arch random
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 s390: crypto: add select CRYPTO_AEAD for aes

From: Arnd Bergmann <[email protected]>

The aes driver registers both skcipher and aead algorithms, but when aead is not enabled this causes a link failure:

s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_fini':
arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to `crypto_unregister_aead'
s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_init':
arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined reference to `crypto_register_aead'

Add the missing 'select' statement.

Fixes bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm support.")
Signed-off-by Arnd Bergmann <[email protected]>
---
 arch/s390/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/s390/crypto/Kconfig +1 -0
index 00051d27db95..228570a1b233 100644
@@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU (s390)"
 
 config CRYPTO_AES_S390
 	tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
+	select CRYPTO_AEAD
 	select CRYPTO_SKCIPHER
 	help
 	  AEAD cipher: AES with GCM
Signature · 1 line
2.39.5
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The aes driver registers both skcipher and aead algorithms, but when aead is not enabled this causes a link failure:

s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_fini':
arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to `crypto_unregister_aead'
s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_init':
arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined reference to `crypto_register_aead'

Add the missing 'select' statement.

Fixes bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm support.")
Signed-off-by Arnd Bergmann <[email protected]>
---
 arch/s390/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/s390/crypto/Kconfig +0 -0
index 00051d27db95..228570a1b233 100644
@@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU

(s390)"

config CRYPTO_AES_S390

arch/s390/crypto/Kconfig menu "Accelerated Cryptographic Algorithms for CPU (s390)" · line 10

Quoted 5 lines
arch/s390/crypto/Kconfig +1 -0
 	tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
+	select CRYPTO_AEAD
 	select CRYPTO_SKCIPHER
 	help
 	  AEAD cipher: AES with GCM
Reviewed-by Harald Freudenberger <[email protected]>
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The aes driver registers both skcipher and aead algorithms, but when aead is not enabled this causes a link failure:

s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_fini':
arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to `crypto_unregister_aead'
s390-linux-ld: arch/s390/crypto/aes_s390.o: in function `aes_s390_init':
arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined reference to `crypto_register_aead'

Quoted 7 lines

Add the missing 'select' statement.

Fixes bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm support.")
Signed-off-by Arnd Bergmann <[email protected]>
---
 arch/s390/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt