ASoC: codecs: pcm512x: fix null-ptr dereference in pcm512x_overclock_xxx_put()
Subsystems (3)
PATCH 1/1 ASoC: codecs: pcm512x: fix null-ptr dereference in pcm512x_overclock_xxx_put()
In the pcm512x chipset driver, pcm512x_overclock_xxx_put() is defined as a general mixer kcontrol instead of a DAPM kcontrol, so struct snd_soc_dapm_context must not be accessed via snd_soc_dapm_kcontrol_to_dapm().
This causes a NULL pointer dereference, so it must be modified to use snd_soc_component_to_dapm().
--- sound/soc/codecs/pcm512x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/pcm512x.c +3 -3
@@ -235,7 +235,7 @@ static int pcm512x_overclock_pll_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) {struct snd_soc_component *component =snd_kcontrol_chip (kcontrol); -struct snd_soc_dapm_context *dapm =snd_soc_dapm_kcontrol_to_dapm (kcontrol); +struct snd_soc_dapm_context *dapm =snd_soc_component_to_dapm (component);struct pcm512x_priv *pcm512x =snd_soc_component_get_drvdata (component);switch (snd_soc_dapm_get_bias_level (dapm)) {
@@ -264,7 +264,7 @@ static int pcm512x_overclock_dsp_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) {struct snd_soc_component *component =snd_kcontrol_chip (kcontrol); -struct snd_soc_dapm_context *dapm =snd_soc_dapm_kcontrol_to_dapm (kcontrol); +struct snd_soc_dapm_context *dapm =snd_soc_component_to_dapm (component);struct pcm512x_priv *pcm512x =snd_soc_component_get_drvdata (component);switch (snd_soc_dapm_get_bias_level (dapm)) {
@@ -293,7 +293,7 @@ static int pcm512x_overclock_dac_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) {struct snd_soc_component *component =snd_kcontrol_chip (kcontrol); -struct snd_soc_dapm_context *dapm =snd_soc_dapm_kcontrol_to_dapm (kcontrol); +struct snd_soc_dapm_context *dapm =snd_soc_component_to_dapm (component);struct pcm512x_priv *pcm512x =snd_soc_component_get_drvdata (component);switch (snd_soc_dapm_get_bias_level (dapm)) {
--
Mark Brown
maintainerQuoted 1 line · Jeongjun Park
ASoC: codecs: pcm512x: fix null-ptr dereference in
pcm512x_overclock_xxx_put()
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/1] ASoC: codecs: pcm512x: fix null-ptr dereference in pcm512x_overclock_xxx_put()
https://git.kernel.org/broonie/sound/c/09e8f9a9aa19
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark