Skip to contentSkip to conversation

staging: rtl8723bs: remove unused rtl8192c function declarations

PATCH In review Pang-Chun Liu 2 participants 2 messages May 21 – May 22 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove unused rtl8192c function declarations

rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but neither has a definition anywhere in the driver, and there are no callers. Remove the dead declarations.

---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -3
index 1f86654f0403..b63625ab4e45 100644
@@ -30,7 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Pang-Chun Liu

rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() are declared in rtl8192c_recv.h but neither has a definition anywhere in the driver, and there are no callers. Remove the dead declarations.

---

This kind of commit doesn't get a Fixes tag since it's not a bug, but I'm always interested to see how mistakes happen. It's better if the commit message can say which commit added it. In this case the dead code was added when we initially merged the driver so it's fine.

regards,
dan carpenter