Skip to contentSkip to conversation

drm/i915/color: Fix plane color pipeline programming bugs

PATCH In review Sean Paul 5 participants 10 messages May 21 – May 28

Subsystems (3)
lore
Share & tools
lore

Sean Paul

author
#0 lore raw

PATCH 1/1 drm/i915/color: Fix plane color pipeline programming bugs

From: Sean Paul <[email protected]>

Fix two bugs in the plane-level color pipeline programming:
1. Fix a step discontinuity in the Post-CSC Gamma LUT when SDR dimming is active by clamping Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24).
2. Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity similar to the Post-CSC fix.

---
 drivers/gpu/drm/i915/display/intel_color.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +6 -5
index 2d318e922671..9b807b024ec3 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 	enum plane_id plane = to_intel_plane(state->plane)->id;
 	const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
 	u32 i, lut_size;
+	u32 lut_val = 1 << 24;
 
 	if (icl_is_hdr_plane(display, plane)) {
 		lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
 		if (pre_csc_lut) {
 			for (i = 0; i < lut_size; i++) {
-				u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+				lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,8 +3976,8 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
-			} while (i++ > 130);
+						   lut_val);
+			} while (i++ < 130);
 		} else {
 			for (i = 0; i < lut_size; i++) {
 				u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
@@ -4023,11 +4024,11 @@ xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
 						   lut_val);
 			}
 
-			/* Segment 2 */
+			/* Segment 2 - clamp to the last LUT value to prevent step discontinuity */
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
+						   lut_val);
 			} while (i++ < 34);
 		} else {
 			/*TODO: Add for segment 0 */
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
maintainer
#1 lore raw
Quoted 11 lines · Sean Paul

From: Sean Paul <[email protected]>

Fix two bugs in the plane-level color pipeline programming:
1. Fix a step discontinuity in the Post-CSC Gamma LUT when SDR dimming is active by clamping Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24).
2. Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity similar to the Post-CSC fix.

One fix per patch, please.

For #2 there's already [1].

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Quoted 52 lines
---
 drivers/gpu/drm/i915/display/intel_color.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +6 -5
index 2d318e922671..9b807b024ec3 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 	enum plane_id plane = to_intel_plane(state->plane)->id;
 	const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
 	u32 i, lut_size;
+	u32 lut_val = 1 << 24;
 
 	if (icl_is_hdr_plane(display, plane)) {
 		lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
 		if (pre_csc_lut) {
 			for (i = 0; i < lut_size; i++) {
-				u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+				lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,8 +3976,8 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
-			} while (i++ > 130);
+						   lut_val);
+			} while (i++ < 130);
 		} else {
 			for (i = 0; i < lut_size; i++) {
 				u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
@@ -4023,11 +4024,11 @@ xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
 						   lut_val);
 			}
 
-			/* Segment 2 */
+			/* Segment 2 - clamp to the last LUT value to prevent step discontinuity */
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
+						   lut_val);
 			} while (i++ < 34);
 		} else {
 			/*TODO: Add for segment 0 */
Signature · 1 line
Jani Nikula, Intel
#2 lore raw
Quoted 14 lines · Jani Nikula
Quoted 11 lines · Sean Paul

From: Sean Paul <[email protected]>

Fix two bugs in the plane-level color pipeline programming:
1. Fix a step discontinuity in the Post-CSC Gamma LUT when SDR dimming is active by clamping Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24).
2. Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity similar to the Post-CSC fix.

Quoted 1 line

One fix per patch, please.

Ack

Quoted 2 lines

For #2 there's already [1].

This isn't in drm-tip or drm-intel afaict. I'll drop it out of my set, but could you please apply it?

Sean

Quoted 61 lines

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Quoted 42 lines
---
 drivers/gpu/drm/i915/display/intel_color.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +4 -3
index 2d318e922671..9b807b024ec3 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
      enum plane_id plane = to_intel_plane(state->plane)->id;
      const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
      u32 i, lut_size;
+     u32 lut_val = 1 << 24;
 
      if (icl_is_hdr_plane(display, plane)) {
              lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
              if (pre_csc_lut) {
                      for (i = 0; i < lut_size; i++) {
-                             u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+                             lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,8 +3976,8 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
                      do {
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-                                                (1 << 24));
-                     } while (i++ > 130);
+                                                lut_val);
+                     } while (i++ < 130);
              } else {
                      for (i = 0; i < lut_size; i++) {
                              u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
@@ -4023,11 +4024,11 @@ xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
                                                 lut_val);
                      }
 

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb, · line 4034

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color.c +2 -2
-                     /* Segment 2 */
+                     /* Segment 2 - clamp to the last LUT value to prevent step discontinuity */
                      do {
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-                                                (1 << 24));
+                                                lut_val);
                      } while (i++ < 34);
              } else {
                      /*TODO: Add for segment 0 */

--
Jani Nikula, Intel

maintainer
#3 lore raw
Quoted 17 lines · Sean Paul
Quoted 14 lines · Jani Nikula
Quoted 11 lines · Sean Paul

From: Sean Paul <[email protected]>

Fix two bugs in the plane-level color pipeline programming:
1. Fix a step discontinuity in the Post-CSC Gamma LUT when SDR dimming is active by clamping Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24).
2. Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity similar to the Post-CSC fix.

Quoted 1 line

One fix per patch, please.

Quoted 7 lines

Ack

Quoted 2 lines

For #2 there's already [1].

This isn't in drm-tip or drm-intel afaict. I'll drop it out of my set, but could you please apply it?

It's been merged.

The v2 replies here confused poor patchwork, please resend the patches as a new thread.

BR,
Jani.

Quoted 64 lines

Sean

Quoted 61 lines

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Quoted 42 lines
---
 drivers/gpu/drm/i915/display/intel_color.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +4 -3
index 2d318e922671..9b807b024ec3 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
      enum plane_id plane = to_intel_plane(state->plane)->id;
      const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
      u32 i, lut_size;
+     u32 lut_val = 1 << 24;
 
      if (icl_is_hdr_plane(display, plane)) {
              lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
              if (pre_csc_lut) {
                      for (i = 0; i < lut_size; i++) {
-                             u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+                             lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,8 +3976,8 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
                      do {
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-                                                (1 << 24));
-                     } while (i++ > 130);
+                                                lut_val);
+                     } while (i++ < 130);
              } else {
                      for (i = 0; i < lut_size; i++) {
                              u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
@@ -4023,11 +4024,11 @@ xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
                                                 lut_val);
                      }
 

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb, · line 4034

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color.c +2 -2
-                     /* Segment 2 */
+                     /* Segment 2 - clamp to the last LUT value to prevent step discontinuity */
                      do {
                              intel_de_write_dsb(display, dsb,
                                                 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-                                                (1 << 24));
+                                                lut_val);
                      } while (i++ < 34);
              } else {
                      /*TODO: Add for segment 0 */

--
Jani Nikula, Intel

Signature · 1 line
Jani Nikula, Intel
author
#4 lore raw

PATCH v2 1/2 drm/i915/color: Fix step discontinuity in Post-CSC Gamma LUT

In reply to Jani Nikula

From: Sean Paul <[email protected]>

Fix a step discontinuity in the Post-CSC Gamma LUT when SDR dimming is active by clamping Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24).

Changes in v2:
- Split out into separate patches for pre/post csc fixes
- Dropped loop bounds fix in favor of [1]

[1]- https://lore.kernel.org/r/[email protected]

---
 drivers/gpu/drm/i915/display/intel_color.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +2 -2
index 2d318e922671..90d5dc2ef3e4 100644
@@ -4023,11 +4023,11 @@ xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
 						   lut_val);
 			}
 
-			/* Segment 2 */
+			/* Segment 2 - clamp to the last LUT value to prevent step discontinuity */
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
+						   lut_val);
 			} while (i++ < 34);
 		} else {
 			/*TODO: Add for segment 0 */
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
author
#5 lore raw

PATCH v2 2/2 drm/i915/color: Fix Pre-CSC degamma LUT bounds

From: Sean Paul <[email protected]>

Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity.

Changes in v2:
- Split out into separate patches for pre/post csc fixes
- Dropped loop bounds fix in favor of [1]

[1]- https://lore.kernel.org/r/[email protected]

---
 drivers/gpu/drm/i915/display/intel_color.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +3 -2
index 90d5dc2ef3e4..469011c83f9b 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 	enum plane_id plane = to_intel_plane(state->plane)->id;
 	const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
 	u32 i, lut_size;
+	u32 lut_val = 1 << 24;
 
 	if (icl_is_hdr_plane(display, plane)) {
 		lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
 		if (pre_csc_lut) {
 			for (i = 0; i < lut_size; i++) {
-				u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+				lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,7 +3976,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 			do {
 				intel_de_write_dsb(display, dsb,
 						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
+						   lut_val);
 			} while (i++ > 130);
 		} else {
 			for (i = 0; i < lut_size; i++) {
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
#6 lore raw

Re: [PATCH v2 2/2] drm/i915/color: Fix Pre-CSC degamma LUT bounds

Hello Sean,

Quoted 7 lines · Sean Paul

From: Sean Paul <[email protected]>

Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity.

The commit message needs an update.
Is there an easy way to reproduce the problem you are seeing (e.g. IGT)? I am wondering if we have to do the same on the pipe Gamma and Degamma.

==
Chaitanya

Quoted 43 lines

Changes in v2:
- Split out into separate patches for pre/post csc fixes
- Dropped loop bounds fix in favor of [1]

[1]- https://lore.kernel.org/r/[email protected]

---
  drivers/gpu/drm/i915/display/intel_color.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +3 -2
index 90d5dc2ef3e4..469011c83f9b 100644
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
  	enum plane_id plane = to_intel_plane(state->plane)->id;
  	const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
  	u32 i, lut_size;
+	u32 lut_val = 1 << 24;
 
  	if (icl_is_hdr_plane(display, plane)) {
  		lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
 
  		if (pre_csc_lut) {
  			for (i = 0; i < lut_size; i++) {
-				u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
+				lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
 
  				intel_de_write_dsb(display, dsb,
  						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
@@ -3975,7 +3976,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
  			do {
  				intel_de_write_dsb(display, dsb,
  						   PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
-						   (1 << 24));
+						   lut_val);
  			} while (i++ > 130);
  		} else {
  			for (i = 0; i < lut_size; i++) {
#7 lore raw

Re: [PATCH v2 2/2] drm/i915/color: Fix Pre-CSC degamma LUT bounds

Quoted 5 lines · Chaitanya Kumar

Hello Sean,

Quoted 2 lines · Sean Paul

From: Sean Paul <[email protected]>

Quoted 8 lines
Quoted 5 lines

Fix a typo in the loop condition in xelpd_program_plane_pre_csc_lut for Segment 2 degamma programming, changing 'while (i++ > 130)' to 'while (i++ < 130)'. Also clamp Segment 2 to the last user-provided LUT entry value instead of hardcoding it to 1.0 (1 << 24) to fix a step discontinuity.

The commit message needs an update.

Ack.

Quoted 2 lines

Is there an easy way to reproduce the problem you are seeing (e.g. IGT)?

Unfortunately I don't have an IGT test, it's reproducing readily with our userspace.

Sean

I am wondering if we have to do the same on the pipe Gamma and Degamma.

Quoted 61 lines

==
Chaitanya

Quoted 2 lines

Link:

https://lore.kernel.org/intel-gfx/[email protected]/
#v1

Quoted 7 lines

Changes in v2:
- Split out into separate patches for pre/post csc fixes
- Dropped loop bounds fix in favor of [1]

[1]-

https://lore.kernel.org/r/[email protected]

Review

Quoted 5 lines
---
  drivers/gpu/drm/i915/display/intel_color.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_color.c

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb

Quoted 4 lines

index 90d5dc2ef3e4..469011c83f9b 100644

drivers/gpu/drm/i915/display/intel_color.c +0 -0
@@ -3953,6 +3953,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb

*dsb,

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb · line 3954

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
      enum plane_id plane = to_intel_plane(state->plane)->id;
      const struct drm_color_lut32 *pre_csc_lut =

plane_state->hw.degamma_lut->data;

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
      u32 i, lut_size;
+     u32 lut_val = 1 << 24;
 
      if (icl_is_hdr_plane(display, plane)) {
              lut_size = 128;
@@ -3963,7 +3964,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb

*dsb,

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -1
              if (pre_csc_lut) {
                      for (i = 0; i < lut_size; i++) {
-                             u32 lut_val =

drm_color_lut32_extract(pre_csc_lut[i].green, 24);

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb · line 3966

Quoted 1 line
drivers/gpu/drm/i915/display/intel_color.c +1 -0
+                             lut_val =

drm_color_lut32_extract(pre_csc_lut[i].green, 24);

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb · line 3968

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
                              intel_de_write_dsb(display, dsb,
 

PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb

Quoted 1 line
drivers/gpu/drm/i915/display/intel_color.c +0 -0
@@ -3975,7 +3976,7 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb

*dsb,

drivers/gpu/drm/i915/display/intel_color.c xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
                      do {
                              intel_de_write_dsb(display, dsb,
 

PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -1
-                                                (1 << 24));
+                                                lut_val);
                      } while (i++ > 130);
              } else {
                      for (i = 0; i < lut_size; i++) {
#8 lore raw

✗ LGCI.VerificationFailed: failure for drm/i915/color: Fix plane color pipeline programming bugs

In reply to Sean Paul
== Series Details ==

== Series Details ==

Series: drm/i915/color: Fix plane color pipeline programming bugs
URL : https://patchwork.freedesktop.org/series/167042/
State : failure

== Summary ==

Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!

#9 lore raw

✗ LGCI.VerificationFailed: failure for drm/i915/color: Fix plane color pipeline programming bugs

In reply to Sean Paul
== Series Details ==

== Series Details ==

Series: drm/i915/color: Fix plane color pipeline programming bugs
URL : https://patchwork.freedesktop.org/series/167093/
State : failure

== Summary ==

Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1166713/ (on master)