Skip to contentSkip to conversation

monitor: Add support for HCI Event Encryption Change v2

PATCH Applied Archie Pusaka 3 participants 3 messages May 22 – May 26 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 monitor: Add support for HCI Event Encryption Change v2

From: Archie Pusaka <[email protected]>

Quoted 1 line

HCI Event: Encryption Change v2 (0x59) plen 5

        Status: Success (0x00)
        Handle: 256 (BR-ACL) Address: 00:11:22:34:56:78
        Encryption: Enabled with E0 (0x01)
        Key size: 16

---

 monitor/bt.h     |  8 ++++++++
 monitor/packet.c | 13 +++++++++++++
 2 files changed, 21 insertions(+)
monitor/bt.h +8 -0
index 147b76537..eac6b5ed7 100644
@@ -3696,6 +3696,14 @@ struct bt_hci_evt_auth_payload_timeout_expired {
 	uint16_t handle;
 } __attribute__ ((packed));
 
+#define BT_HCI_EVT_ENCRYPT_CHANGE_V2		0x59
+struct bt_hci_evt_encrypt_change_v2 {
+	uint8_t  status;
+	uint16_t handle;
+	uint8_t  encr_mode;
+	uint8_t  encr_key_size;
+} __attribute__ ((packed));
+
 #define BT_HCI_EVT_LE_CONN_COMPLETE		0x01
 struct bt_hci_evt_le_conn_complete {
 	uint8_t  status;
monitor/packet.c +13 -0
index ff0b1cac2..0de7e6f57 100644
@@ -12008,6 +12008,17 @@ static void auth_payload_timeout_expired_evt(struct timeval *tv, uint16_t index,
 	print_handle(evt->handle);
 }
 
+static void encrypt_change_evt_v2(struct timeval *tv, uint16_t index,
+					const void *data, uint8_t size)
+{
+	const struct bt_hci_evt_encrypt_change_v2 *evt = data;
+
+	print_status(evt->status);
+	print_handle(evt->handle);
+	print_encr_mode_change(evt->encr_mode, evt->handle);
+	print_key_size(evt->encr_key_size);
+}
+
 static void le_conn_complete_evt(struct timeval *tv, uint16_t index,
 					const void *data, uint8_t size)
 {
@@ -13737,6 +13748,8 @@ static const struct event_data event_table[] = {
 	{ 0x57, "Authenticated Payload Timeout Expired",
 				auth_payload_timeout_expired_evt, 2, true },
 	{ 0x58, "SAM Status Change" },
+	{ 0x59, "Encryption Change v2",
+				encrypt_change_evt_v2, 5, true },
 	{ 0xfe, "Testing" },
 	{ 0xff, "Vendor", vendor_evt, 0, false },
 	{ }
Signature · 1 line
2.54.0.746.g67dd491aae-goog
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1099306

---Test result---

Test Summary:

CheckPatch                    FAIL      0.50 seconds
GitLint                       PASS      0.41 seconds
BuildEll                      PASS      20.30 seconds
BluezMake                     PASS      661.62 seconds
MakeCheck                     PASS      0.95 seconds
MakeDistcheck                 FAIL      235.11 seconds
CheckValgrind                 PASS      228.16 seconds
CheckSmatch                   WARNING   359.26 seconds
bluezmakeextell               PASS      182.87 seconds
IncrementalBuild              PASS      688.00 seconds
ScanBuild                     PASS      1069.98 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] monitor: Add support for HCI Event Encryption Change v2 WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed)) #114: FILE: monitor/bt.h:3705:
+} __attribute__ ((packed));

/github/workspace/src/patch/14589097.patch total: 0 errors, 1 warnings, 39 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/patch/14589097.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:

make[4]: *** [Makefile:10239: test-suite.log] Error 1
make[3]: *** [Makefile:10347: check-TESTS] Error 2
make[2]: *** [Makefile:10818: check-am] Error 2
make[1]: *** [Makefile:10820: check] Error 2
make: *** [Makefile:10741: distcheck] Error 1
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c:2002:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3917:52: warning: array of flexible structuresmonitor/bt.h:3905:40: warning: array of flexible structures

https://github.com/bluez/bluez/pull/2146

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Archie Pusaka
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 9 lines · On Fri, 22 May 2026 19:15:12 +0800 you wrote:

From: Archie Pusaka <[email protected]>

Quoted 1 line

HCI Event: Encryption Change v2 (0x59) plen 5

        Status: Success (0x00)
        Handle: 256 (BR-ACL) Address: 00:11:22:34:56:78
        Encryption: Enabled with E0 (0x01)
        Key size: 16

[...]

Here is the summary with links:
- [BlueZ] monitor: Add support for HCI Event Encryption Change v2

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b493164ffbff

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html