iio: adc: qcom-spmi-iadc: balance enable_irq_wake() on driver unbind
Subsystems (2)
PATCH v2 1/1 iio: adc: qcom-spmi-iadc: balance enable_irq_wake() on driver unbind
iadc_probe() calls enable_irq_wake() after a successful devm_request_irq(), but the driver has no remove callback or matching disable_irq_wake(), so the wake reference count on the IRQ is leaked on module unload or driver unbind.
Check the IRQ request error first, then register a devm action that calls disable_irq_wake() so the wake reference is released in the same scope as the enable. While here, drop the inverted "if (!ret) ... else return ret" in favour of the standard "if (ret) return ret;" pattern.
---
v2:
- Use (long) instead of (unsigned long) for the int<->void* casts (Jonathan)
v1: https://lore.kernel.org/all/[email protected]/
drivers/iio/adc/qcom-spmi-iadc.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)
drivers/iio/adc/qcom-spmi-iadc.c +15 -3
@@ -481,6 +481,11 @@ static const struct iio_chan_spec iadc_channels[] = { }, }; +static void iadc_disable_irq_wake (void *data) +{ +disable_irq_wake ((long )data); +} +static int iadc_probe (struct platform_device *pdev) {struct device_node *node = pdev->dev.of_node;
@@ -538,9 +543,16 @@ static int iadc_probe(struct platform_device *pdev)if (!iadc->poll_eoc) { ret =devm_request_irq (dev, irq_eoc, iadc_isr,0 ,"spmi-iadc" , iadc); -if (!ret) -enable_irq_wake (irq_eoc); -else +if (ret) +return ret; + + ret =enable_irq_wake (irq_eoc); +if (ret) +return ret; + + ret =devm_add_action_or_reset (dev, iadc_disable_irq_wake, + (void *)(long )irq_eoc); +if (ret)return ret; }else { ret =devm_device_init_wakeup (iadc->dev);
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerQuoted 11 lines · On Sat, 23 May 2026 18:46:13 +0500 Stepan Ionichev <[email protected]> wrote:
iadc_probe()callsenable_irq_wake()after a successfuldevm_request_irq(), but the driver has no remove callback or matchingdisable_irq_wake(), so the wake reference count on the IRQ is leaked on module unload or driver unbind.Check the IRQ request error first, then register a devm action that calls
disable_irq_wake()so the wake reference is released in the same scope as the enable. While here, drop the inverted "if (!ret) ... else return ret" in favour of the standard "if (ret) return ret;" pattern.
Quoted 4 lines
Signed-off-by Stepan Ionichev <[email protected]>---
v2:
- Use (long) instead of (unsigned long) for the int<->void* casts (Jonathan)
Ah. I think this was me being wrong on necessity of original casts..
patch v1 was fine in this respect.. Sorry for waste of time!
One other thing though - seems like a fix so why no Fixes tag?
Jonathan
Quoted 42 lines
v1: https://lore.kernel.org/all/[email protected]/
drivers/iio/adc/qcom-spmi-iadc.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)drivers/iio/adc/qcom-spmi-iadc.c +15
-3@@ -481,6 +481,11 @@ static const struct iio_chan_spec iadc_channels[] = { }, }; +static void iadc_disable_irq_wake (void *data) +{ +disable_irq_wake ((long )data); +} +static int iadc_probe (struct platform_device *pdev) {struct device_node *node = pdev->dev.of_node;@@ -538,9 +543,16 @@ static int iadc_probe(struct platform_device *pdev)if (!iadc->poll_eoc) { ret =devm_request_irq (dev, irq_eoc, iadc_isr,0 ,"spmi-iadc" , iadc); -if (!ret) -enable_irq_wake (irq_eoc); -else +if (ret) +return ret; + + ret =enable_irq_wake (irq_eoc); +if (ret) +return ret; + + ret =devm_add_action_or_reset (dev, iadc_disable_irq_wake, + (void *)(long )irq_eoc); +if (ret)return ret; }else { ret =devm_device_init_wakeup (iadc->dev);